Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp358755rwb; Sat, 14 Jan 2023 01:24:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXsSHJZJqKDKi76uLUsNJZSARPH2c6Na5fuluywiqkrujWo8PTiwo36KVMS2NNRYGbhfHgT3 X-Received: by 2002:a17:906:6dcb:b0:7c0:d60b:2887 with SMTP id j11-20020a1709066dcb00b007c0d60b2887mr72004383ejt.69.1673688260661; Sat, 14 Jan 2023 01:24:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673688260; cv=none; d=google.com; s=arc-20160816; b=YOpoJLUsPz0SXRuB3821SbzZ/7700q5IM18yWqybQaVM0UN7Y3tIbeJj1+YqkDAt60 JJvFsEIAfJDJiPOJoUXb54REr3TEduQ5EE3qQg7oAz18jFUuLTByrmlDSARyndvnK4fM YAu5hcVz9CMwq5L6jT6AUeB4wkjF2PnrEVrW/ictL/E5dJEjD9E/HxchN1MG/6NczTKn 8gRDbKKnuAsYCnCMp/fM+V8hB1S6sPXEyWPniQ2MgvU5At4tNfpSxmM7G3UJTvGl71H9 hjE2x2IP/zyWGMgk2JeXF9DDwYccRPRV4jGajWU3VLJUAe9X8VyqIBFlDRvB+rG6edC/ ebFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:ui-outboundreport:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1ZPzE/x/V9gRI1TogFetowagFJHEvIpVuCJrtMlLBXM=; b=IgbN4karaZqP6vZMgxDi5RRUf3K2o68qAfa1E9V245UspIaxCtJD4jnysTIU6LYo59 FW1Kbxvk4A62jM6M0Mdi2QKTXfkVAn7hWpFT2o5g8MjhrF8aE5N6PPapT4WqatyZf+zF hGthZQPMZE5GqH8qNkKird++ZPTwxaR7ihVWQqL/82KdDRoEtv5qhYol2dtBkSoPXtHb 3IWMuWypwmaaF2aTNp2gWOeNSYw/pvkvODX3YR8IA1Y5Rd9+vNzmT/LEfPQaAQ90/L0Y 2DeNEt4mgLU/fPJA8MV73n9PsZPyKhi8f3lgY2AWohHFvqOnjedNkGnHuMYwtKNGwTKR LnAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=pLvDoi+U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv13-20020a17090760cd00b007ad8bd5b636si25646899ejc.377.2023.01.14.01.24.08; Sat, 14 Jan 2023 01:24:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=pLvDoi+U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmx.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjANIvg (ORCPT + 51 others); Sat, 14 Jan 2023 03:51:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbjANIvH (ORCPT ); Sat, 14 Jan 2023 03:51:07 -0500 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 789AD5BA6; Sat, 14 Jan 2023 00:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1673686260; bh=ZRXDOHGn9yZu57/DPz1iMB9OlkHhVNY+RiI8eWQZy7Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=pLvDoi+UkLmHCYXsNyLYXYV53IObWoyJZafOBDM7/xWU9N2OdOERE+YWsiX9kr8QE 21sD5GeM4fvtVk6H6wp4rQWv/rJhUhl9RsSVar35f6QYxod2K3jsgDJCTLQo6hAQrp G/U58GQ/193DUoulcnHyjjsIcWiqInNdAKuZ2dG061FCKGu9//lzxnRkPCrGoC1/w6 L9Xy+Usbspusw79LnqU1iX8jN/Gu5IsepspIfmflkTIxSKr3d3lJ7d7H4OoO95znmd IYef5GOS8GZSdeJCd8FnWxUvZgxkYAlJmF91wH23ZjvhEvC60LPHv6baZVILvbnXSt taDtekps0eb7w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from esprimo-mx.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTzb8-1p7AIr3qJG-00R4ov; Sat, 14 Jan 2023 09:51:00 +0100 From: Armin Wolf To: rafael@kernel.org, lenb@kernel.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] ACPI: battery: Replace strncpy() with strscpy() Date: Sat, 14 Jan 2023 09:50:52 +0100 Message-Id: <20230114085053.72059-4-W_Armin@gmx.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230114085053.72059-1-W_Armin@gmx.de> References: <20230114085053.72059-1-W_Armin@gmx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:nEZOIaBECnOJgOL0HPTpdVTEJLBlJu+3+2Qk7c4CHM64oEsNvM1 MK0Qc6IY/nXmbWlmjtoA3YNvPu6SlIutDmjNGhyAgJkBBCnjS2QM3oAA41zn3pVqda0cl0X WalSa89lF1lXyN1vhpmY51SrfzKOBdQUWq29Nz9Za4mobsWriR1Wa1ghgzOMBQJexaP3pxI qSyVkUsUSAt0aQ/nXocvQ== UI-OutboundReport: notjunk:1;M01:P0:GnJcBRdBtq4=;Ih+YY7KENBNCd2SSEcHJVwizecw 8vH04p9rGNR7wfwwdEm7hVxG3LGtkwXvYI2ISa+hEassqfFELz/MvpMsm/RWhSTIXvebUBpZ0 wpdiPxQGhP+QbOaLaXekf7xxXyLAk0yZ1U9X0e0M9LuxwzeblUZ8Oxqi3a5ixf8gTBonesvh1 mfQY9PGjIzr1SW/zuGDxeZd//lFQvmD/Ybt9OuRAyWxexeE1B8XcEFA/QcvsodqAOpJ9vwtyE JANYGX+zhf3saM9AnWiNVGW74VXHV2NtVIjdgEPYaUJqJE4y56c9xXzkQQOPnm2awUWKX3nvU Iy0Ta2A1oi8HH/PNEYAHj0G8qVWlykOntQNJdt+I+pbI9CUf+0icaYx+vAR3HzIoN0iYvlZ5C AhKw+fYAMpDHhirhHDjhUw8/y332L/xRKkjp+Ex83xHuOsxjpLTYn7bmNNVflBL+F9D/3oUed MPcNYKkO8YH1xICNqkS8xj56RUMm3e8Hd/IWHGUZwK5UTs7mnIk0usmTzDjUd8dypX/rqkACt m+d5jnC7NvNFk1apjGHAols2Dt0LwkqtOEShsOK1Dje0SNxZAJTOoj26uVZGEHG1bB6+2nROT KalYmx4mwVOFJdeYw3259r3PmXB+OcN1sKOtYlIsGClSM/1mOq6PIlV0JZ61P7R/nf+KT1I6W gOUPJTTO6Iib0kSLJkWxXNRoyNsjRxgIRVbFP/S5iyFXZnjXRteqrAZSgv7jGOWFkfs5Zhkoq Nya1kljngMTHGQMW1ZT0CQrDe+z+mQju0oD1ehrKJyGo7n0QvNLUrVeY354GeHtakIn89w9Yy CnmJyQg6EHpEQIrm8sOuvacuHP5uu5YPMHs05GI+pL3uN9p9xvwlI4dxKo1Qbrl/2TMxRCkZ5 qIXa7C54LuMA/pBLa03jlKCAX2Lmfg4tZUKJkXaDOj/x+7lc55qELSZLy2QpqTa72kATGk8hH JEsOV7fJW2zrZoFZkISpQqkHTak= X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, strncpy() and manual NUL-termination is used when copying integers. Switch to strscpy() which takes care of NUL-terminating the result. Signed-off-by: Armin Wolf =2D-- drivers/acpi/battery.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 9f6daa9f2010..b39b84b8f3ae 100644 =2D-- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -449,8 +449,7 @@ static int extract_package(struct acpi_battery *batter= y, break; case ACPI_TYPE_INTEGER: - strncpy(ptr, (u8 *)&element->integer.value, sizeof(u64)); - ptr[sizeof(u64)] =3D 0; + strscpy(ptr, (u8 *)&element->integer.value, sizeof(u64) + 1); break; default: =2D- 2.30.2