Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230113142718.3038265-1-o.rempel@pengutronix.de> <20230113142718.3038265-9-o.rempel@pengutronix.de>
In-Reply-To: <20230113142718.3038265-9-o.rempel@pengutronix.de>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Sat, 14 Jan 2023 08:39:27 -0300
Message-ID: <CAOMZO5C8SSVZF8z2HngxG-d59aa=CmAQRThxkC3xaR695uKFSA@mail.gmail.com>
Subject: Re: [PATCH v1 08/20] ARM: dts: imx6dl-plybas: configure ethernet
 reference clock parent
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Abel Vesa <abelvesa@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Richard Cochran <richardcochran@gmail.com>,
        kernel@pengutronix.de, NXP Linux Team <linux-imx@nxp.com>,
        Lee Jones <lee@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Oleksij,

On Fri, Jan 13, 2023 at 11:27 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>
> Configure Ethernet reference clock parent in an obvious way instead of
> using cryptic ptp way.

Could you please improve the commit log?

The "obvious way" is not obvious for people that don't have the board
schematics.

I like better the way you described the 20/20 patch:

"On this board the PHY is the ref clock provider. So, configure ethernet
reference clock as input."

Please use this format globally in the series, as it becomes clear who
is providing the ref clock.

Thanks