Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230112-inet_hash_connect_bind_head-v2-1-5ec926ddd985@diag.uniroma1.it>
 <CANn89iJekPT_HsJ6vfQf=Vk8AXqgQjoU=FscBHGVSRcvdfaKDA@mail.gmail.com> <CAEih1qWQf1JK4vbdzcTb1yXADxTV4+AqtJkvnK1T895obUTtOQ@mail.gmail.com>
In-Reply-To: <CAEih1qWQf1JK4vbdzcTb1yXADxTV4+AqtJkvnK1T895obUTtOQ@mail.gmail.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Sat, 14 Jan 2023 13:21:36 +0100
Message-ID: <CANn89iJCphvKBWcV1iGdTe9OXWiv1gQCTub60b1v2qi=pYLoSw@mail.gmail.com>
Subject: Re: [PATCH v2] inet: fix fast path in __inet_hash_connect()
To:     Pietro Borrello <borrello@diag.uniroma1.it>
Cc:     Kuniyuki Iwashima <kuniyu@amazon.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>, Jakob Koschel <jkl820.git@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jan 14, 2023 at 1:18 PM Pietro Borrello
<borrello@diag.uniroma1.it> wrote:
>
> On Fri, 13 Jan 2023 at 13:16, Eric Dumazet <edumazet@google.com> wrote:
> > 1) Given this path was never really used, we have no coverage.
> >
> > 2) Given that we do not check inet_ehash_nolisten() return code here.
>
> It seems there are a bunch of call sites where inet_ehash_nolisten() return
> code is not checked, thus I didn't think of it to be a problem.
>
> >
> > I would recommend _not_ adding the Fixes: tag, and target net-next tree
> >
> > In fact, I would remove this dead code, and reduce complexity.
> >
>
> This makes a lot of sense. I can post a v3 patch completely removing
> the fast path.
>
> However, this patch's v1 was already reviewed by
> Kuniyuki Iwashima <kuniyu@amazon.com>, v2 is a nit, if posting a v3
> I think I should remove the Reviewed-by: since it would completely
> change the patch, but what is the preferred fix?
>

Yes, remove it, and Kuniyuki will review it again, thanks.