Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 15 Jan 2023 01:22:14 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Kubecek <mkubecek@suse.cz>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Rui Sousa <rui.sousa@nxp.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v2 net-next 04/12] net: ethtool: netlink: retrieve stats
 from multiple sources (eMAC, pMAC)
Message-ID: <20230114232214.tj6bsfhmhfg3zjxw@skbuf>
References: <20230111161706.1465242-1-vladimir.oltean@nxp.com>
 <20230111161706.1465242-5-vladimir.oltean@nxp.com>
 <20230113204336.401a2062@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230113204336.401a2062@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m6x1qDvXOTBFgrU9do9hkTSe17q5J1tRS/HiYM4F5Tdj1FxR6/0TJh+FcGAc?=
 =?us-ascii?Q?yMUALahtHpXjLCQdE2DJNX/mHVUwoJs6/Af0G5ESUUcmaRQlJtfGE2yt9F1m?=
 =?us-ascii?Q?/cVeM1wD5xobvH/8ONfka1JeQXdOMYPFIN7viVG1wtP8J5xkmcJIWbP6o9pO?=
 =?us-ascii?Q?eOGDIrFL8MCGDhob8jSbRmxsUYfFDcsu/mMJp6Rfmpv/bpo4LgVapm0v5XYo?=
 =?us-ascii?Q?enVcChEk8pYZjFxOt5B3vzEdL+lFtyZGPg2L06hri0DoCaeW1IBEreU7dY5k?=
 =?us-ascii?Q?UTQ3B4aUCtTCONCW4hKkR9xURjzVjgMOcYuzjyVjMlJgL/wIHmD03M9qm8iJ?=
 =?us-ascii?Q?I6QdgGAAm98H2RHg+9Vfj6sJ2z0F3bHNfTkHHDJUs30l+1Uj3JWFyCyUFip5?=
 =?us-ascii?Q?sFavXfgE2KD+C37QTUy4xgdf4yGu7bofvRbb7PzoQq5+WpX+KJ1CXjuwu0k1?=
 =?us-ascii?Q?mrHP0oocou1FGDJeu7AXx41A/zlPWyp8MeIWkwfyZC0qoNgwmWPQx6YilrUm?=
 =?us-ascii?Q?xE0rZJ0e/bI/LG+8IHwoJQtf+n5soSNqz9WvGkWkFsK0sQOxZgusrLRyBtI2?=
 =?us-ascii?Q?eeD8olb1yRcp6N97fzyLgcK9kSecstIzgcK1KELGk8BjIM2Uk1jwirEetkfE?=
 =?us-ascii?Q?7O75f7qygAUMKQyKyfiWsNTdq1lkhRQ5btKoO+0tfuy2m8H+DrGG5x3cUGyb?=
 =?us-ascii?Q?6jGSvFbKvSUrz/WhRlW6Fb6EU3u8fjs9MtLL+jkElurlJAFm1YISHwkbOjdp?=
 =?us-ascii?Q?VGR4DXFyra/gHuteyx4XiZhHXALUxbbkpsxf5urFX63u1v6YIRS9TB1nD7Ja?=
 =?us-ascii?Q?bGWvvmiChUGKwweybk7uXFmTKgZ0wu4s7q/cFn3JXw095Xgz9QxWunsid7ES?=
 =?us-ascii?Q?dhfrrfzDaAtiJHfSv1EGXUmesYVX1BKj1cI3Q0KiknKGf8lti7bS+7H62YeL?=
 =?us-ascii?Q?1uztg/5qTnyt3KkqMp7/A5DhCEey6k796ZIzK0TkLGYPynqj7aze2ftAsSdp?=
 =?us-ascii?Q?vBdqD23oyulxGPWkkv6l1C3vjPWC+3b08nbRdSQ275tPe68EccZlnwaMm+Iu?=
 =?us-ascii?Q?oHH7bTqg6zju9+l8vniOO7wTaEBhKNGmP+ciXrVBQw/ipKVy3SSXSUnllWiW?=
 =?us-ascii?Q?w4275i7gOqdMh3nLm25A0rhAmOq/UpqTPWOtt/JVZP9erhXqotbXzcItA2xj?=
 =?us-ascii?Q?ExE7wDsSm1x38vYg8HHt0b2rpC6bWyI6NMr0fNT9W8d6TxPI5+j/JHrcqEi/?=
 =?us-ascii?Q?5dmJm420wHTHrlj5GFuBBgaNk8lqliCOZe7FP7RB14CHKGVRT0fVrKy4PXez?=
 =?us-ascii?Q?k336KMJS7Ug5EVjooe8CCSROqzqV4oLWrEXamcmeQWu/wZQ9t6Esj6vNthwi?=
 =?us-ascii?Q?JVjQqwcG6cab2z6MJWqS1YoM45hP7ZTa5LLMf01qD0Nm8088Uqq8guJOR0JX?=
 =?us-ascii?Q?kUn6okM3waBpRmrqb4FHVuHYpgjJAaz04qITy9Hcg9F4+jtJPtCntAbGlqbt?=
 =?us-ascii?Q?5uFcH/h6Uf7kGOktDmcLNt2j3Lj7oK2reryGvoO0D6mA81G3iHVg7Io7OW4t?=
 =?us-ascii?Q?7XGklzvY9lZteRexpS4sKx55KfPV9Pe5t7L8N9ey5b4aWoKUixRWxEVzUkcd?=
 =?us-ascii?Q?uw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0141a9ff-56fc-4cc9-da89-08daf6862e3d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2023 23:22:19.7108
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9+GZ+5JQzROqFESUddTrvarurIKnMs800863dnxG6/+d95KcAKXEziIdBUKL6EdTmg0Lbr8/uST8oLlBFvvqog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7147
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 13, 2023 at 08:43:36PM -0800, Jakub Kicinski wrote:
> On Wed, 11 Jan 2023 18:16:58 +0200 Vladimir Oltean wrote:
> > +/**
> > + * enum ethtool_stats_src - source of ethtool statistics
> > + * @ETHTOOL_STATS_SRC_AGGREGATE:
> > + *	if device supports a MAC merge layer, this retrieves the aggregate
> > + *	statistics of the eMAC and pMAC. Otherwise, it retrieves just the
> > + *	statistics of the single (express) MAC.
> > + * @ETHTOOL_STATS_SRC_EMAC:
> > + *	if device supports a MM layer, this retrieves the eMAC statistics.
> > + *	Otherwise, it retrieves the statistics of the single (express) MAC.
> > + * @ETHTOOL_STATS_SRC_PMAC:
> > + *	if device supports a MM layer, this retrieves the pMAC statistics.
> > + */
> > +enum ethtool_stats_src {
> > +	ETHTOOL_STATS_SRC_AGGREGATE,
> > +	ETHTOOL_STATS_SRC_EMAC,
> > +	ETHTOOL_STATS_SRC_PMAC,
> > +};
> 
> Should we somehow call it "MAC stats"?
> 
> Right now its named like a generic attribute, but it's not part of 
> the header nest (ETHTOOL_A_HEADER_*).
> 
> I'm not sure myself which way is better, but feels like either it
> should be generic, in the header nest, and parsed by the common code;
> or named more specifically and stay in the per-cmd attrs.

Considering that I currently have separate netlink attributes for
ETHTOOL_MSG_STATS_GET (ETHTOOL_A_STATS_SRC) and for
ETHTOOL_MSG_PAUSE_GET (ETHTOOL_A_PAUSE_STATS_SRC), I'm going to add just
a single attribute right under ETHTOOL_A_HEADER_FLAGS for v3 and go from
there. Is it ok if I keep naming it ETHTOOL_A_STATS_SRC, or would you
prefer something else?