Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1409371rwb; Sat, 14 Jan 2023 20:30:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXsBsoyE0pnOMcIQW5XzQVSNUmC5JVIx9RvpChqbC+jmwjuT7NrVk+G4H8jddgVWR6AZcTJN X-Received: by 2002:a17:902:8309:b0:189:469c:dc0 with SMTP id bd9-20020a170902830900b00189469c0dc0mr54993746plb.7.1673757014640; Sat, 14 Jan 2023 20:30:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673757014; cv=none; d=google.com; s=arc-20160816; b=tlq4nhueJcU/W+jd/Kb8ISM/IGEfUG4xI5dpQ3pwPb+hWtBax/5ZJgADSjhJAcpV1G 2Oh40jl4ZXp6aLYFqY3jYJc/Ecl9waVRCrD1RrdwqcvUU7WAMMupfNrIqbTRkw59tGAP gv4VCX7Vwwdi3t/PJBkJcQxMeKk+moututj5WDWeGBx4qG0F1TktXttbyAxpGPV8dAWu jJEo84Z7rszNENYCq6nkUvDnvTxIEAP45QrNOW9HbqrSQbR7dooaKf/YD6NPp8Oe83Xx UN2AmJTfQPjV+54ughZQoZIEedSlIy9EbXeZeUkWj0B7O153/KQfH5+4VLhtJiT7x4JE rurA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ALsjGopWf+hZuhs7nMXhO/pSXNTGv/26Xn0WdBaHFYg=; b=f2UhElGoe0Yup9DOKRZ6W66dCEA0gFcQiKURaVgELaWPDm9CLqfnxCZ8eTr8K8W6r6 bK95993rW9AlOS785AB/5RgeXXLWJ8b8xJA1EqWFSMPVmFNOsu6P1tTGTYukhhvl3tEe JeCEr+4T9pvfkFDoSHOCNAiiMNM/M+qY3dT6sG0dh77R4KYTvxsjWY+oyfntD87phQgE pEfZC8yqFzbzYbPOICI+4Re4CgyqAyA9RsY2pduRHQ7eDTenkF04nYJduXBqQgPKZr5F 8jl/Byp1CZ/0CcXhsQ/D0o7KaLysqRPYe6H0sbzSpE8hKjwczR4kLg/hd9CAKNlSUMQR xQzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="b0b/7owM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b17-20020a170902d89100b001947e86f0acsi3285709plz.76.2023.01.14.20.30.07; Sat, 14 Jan 2023 20:30:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="b0b/7owM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbjAOEVs (ORCPT + 54 others); Sat, 14 Jan 2023 23:21:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230368AbjAOEVk (ORCPT ); Sat, 14 Jan 2023 23:21:40 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33A0D4689 for ; Sat, 14 Jan 2023 20:21:39 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id 200so12621946pfx.7 for ; Sat, 14 Jan 2023 20:21:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ALsjGopWf+hZuhs7nMXhO/pSXNTGv/26Xn0WdBaHFYg=; b=b0b/7owMlcYKKx6n44kgErJ0X4MpjPnAodIgILqAjx2U7yjvSdxiXkLLbGACuOgZc4 yrCdHqkodXVWTtbOoqjItH+Jr5TRL1BkFhbY6sZrJsCah3dE4BjAgVj7nWl/2Zk0QdDX TvlVurRKhQhnZb/t78+SPyHJcARCWA0BwVd20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ALsjGopWf+hZuhs7nMXhO/pSXNTGv/26Xn0WdBaHFYg=; b=RURKao52aLzNiJBrBP9Ocktb/y5Rdb2OHvafPI0mYtlrJQHgRUefvlwd8k7IbfQzXC xJGeETFpdGuNBhD7D7PpoUtDqZB5POHCf3m4lrUhJaLoLDZ21PROmaLrZZHtLeSc4ION 3XJxavyguyj6oh/znhx4C1+kJKO0G/OxkzXCv37JeVYoBgDmgTXuWIhljqlHzl18DNSD 72jv0zfnPehoU/9TKSWxVEc3TtesI5XjR+UxehxsUnWXthzBB7JTCCV1LARy6yRG+vqz ir4g+a8tM9awAJA+3NEKI9fEjHQX/m9MwUND5bKRePTYWC2uxpH4Vb/WXhktAsH5e36a UlUw== X-Gm-Message-State: AFqh2krBq6hFkwVuWA2rcOkUCoI+VnaYCqh6b1tG0fQGNjqHyxnwbYUs tbJo1K47z8MzRZ1zrDg24zNI+Q== X-Received: by 2002:a62:1684:0:b0:587:8d47:acdd with SMTP id 126-20020a621684000000b005878d47acddmr21290384pfw.34.1673756498581; Sat, 14 Jan 2023 20:21:38 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id 4-20020a620404000000b00576ee69c130sm15797537pfe.4.2023.01.14.20.21.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 20:21:37 -0800 (PST) Date: Sun, 15 Jan 2023 13:21:33 +0900 From: Sergey Senozhatsky To: Mike Kravetz Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 0/4] zsmalloc: make zspage chain size configurable Message-ID: References: <20230109033838.2779902-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/01/14 13:34), Mike Kravetz wrote: > I did the following: > > - Start with clean v6.2-rc3 > Perform echo, did not see issue > > - Applied your 5 patches (includes the zsmalloc: turn chain size config option > into UL constant patch). Took default value for ZSMALLOC_CHAIN_SIZE of 8. > Performed echo, recreated issue. > > - Changed ZSMALLOC_CHAIN_SIZE to 1. > Perform echo, did not see issue The patch set basically just adjusts $NUM in calculate_zspage_chain_size(): for (i = 1; i <= $NUM; i++) It changes default 4 to 8. Can't really see how this can cause problems.