Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757051AbXHWIpi (ORCPT ); Thu, 23 Aug 2007 04:45:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759885AbXHWIpZ (ORCPT ); Thu, 23 Aug 2007 04:45:25 -0400 Received: from brick.kernel.dk ([87.55.233.238]:1775 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759227AbXHWIpX (ORCPT ); Thu, 23 Aug 2007 04:45:23 -0400 Date: Thu, 23 Aug 2007 10:45:19 +0200 From: Jens Axboe To: Dhaval Giani Cc: Balbir Singh , Srivatsa Vaddagiri , lkml Subject: Re: [PATCH] Corrections in Documentation/block/ioprio.txt Message-ID: <20070823084519.GJ23758@kernel.dk> References: <20070823081817.GA27439@linux.vnet.ibm.com> <20070823082929.GI23758@kernel.dk> <20070823082836.GB27439@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070823082836.GB27439@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2973 Lines: 83 On Thu, Aug 23 2007, Dhaval Giani wrote: > On Thu, Aug 23, 2007 at 10:29:30AM +0200, Jens Axboe wrote: > > On Thu, Aug 23 2007, Dhaval Giani wrote: > > > Hi Jens, > > > > > > The newer glibc does not allow system calls to be made via _syscallN() > > > wrapper. They have to be made through syscall(). The ionice code used > > > the older interface. Correcting it to use syscall. > > > > > > Signed-of-by: Dhaval Giani > > > > > > > > > Index: linux-2.6.23-rc3-mm1/Documentation/block/ioprio.txt > > > =================================================================== > > > --- linux-2.6.23-rc3-mm1.orig/Documentation/block/ioprio.txt 2007-07-09 05:02:17.000000000 +0530 > > > +++ linux-2.6.23-rc3-mm1/Documentation/block/ioprio.txt 2007-08-23 13:23:28.000000000 +0530 > > > @@ -86,8 +86,9 @@ extern int sys_ioprio_get(int, int); > > > #error "Unsupported arch" > > > #endif > > > > > > -_syscall3(int, ioprio_set, int, which, int, who, int, ioprio); > > > -_syscall2(int, ioprio_get, int, which, int, who); > > > +#define ioprio_set(which, who, ioprio) syscall(__NR_ioprio_set, which,\ > > > + who, ioprio) > > > +#define ioprio_get(which, who) syscall(__NR_ioprio_get, which, who) > > > > Agree, it fails as-of recent distros. But I prefer a function instead, > > can you resend with something ala: > > > > static inline int ioprio_set(int which, int who, int ioprio) > > { > > return syscall(__NR_ioprio_set, which, who, ioprio); > > } > > > > and ditto for ioprio_get()? > > > > -- > > Jens Axboe > > Done.. > > ---------------------- > > The newer glibc does not allow system calls to be made via _syscallN() > wrapper. They have to be made through syscall(). The ionice code used > the older interface. Correcting it to use syscall. > > Signed-off-by: Dhaval Giani > > > Index: linux-2.6.23-rc3-mm1/Documentation/block/ioprio.txt > =================================================================== > --- linux-2.6.23-rc3-mm1.orig/Documentation/block/ioprio.txt 2007-07-09 05:02:17.000000000 +0530 > +++ linux-2.6.23-rc3-mm1/Documentation/block/ioprio.txt 2007-08-23 13:46:08.000000000 +0530 > @@ -86,8 +86,15 @@ extern int sys_ioprio_get(int, int); > #error "Unsupported arch" > #endif > > -_syscall3(int, ioprio_set, int, which, int, who, int, ioprio); > -_syscall2(int, ioprio_get, int, which, int, who); > +static inline int ioprio_set(int which, int who, int ioprio) > +{ > + return syscall(__NR_ioprio_set, which, who, ioprio); > +} > + > +static inline int ioprio_get(int which, int who) > +{ > + return syscall(__NR_ioprio_get, which, who); > +} > > enum { > IOPRIO_CLASS_NONE, Thanks, applied! -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/