Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1643335rwb; Sun, 15 Jan 2023 01:40:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXtYIeZqcQkYOEByXrV5+nAQPR3Q/We+UdLYCKIhyVcxGL/owBiMNg3LScFSTf6HfU5QkhG0 X-Received: by 2002:a05:6a00:1c8c:b0:582:8722:bf60 with SMTP id y12-20020a056a001c8c00b005828722bf60mr42409023pfw.3.1673775632040; Sun, 15 Jan 2023 01:40:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673775632; cv=none; d=google.com; s=arc-20160816; b=IbFFm+GrlVoFxMak0aAeq6QVkSBtvUO/CRYyzv7jtnSAgLdg0Gql1UJ+ySd9THaQMa aCD0Sd5Rs6Pp2beuOtg7gv2hrPsYgQX/9EyoHbHSP3wGyL3KnF3hasdhDwrB2wdUSigr 9aPQUkQ9pQPKFMb6fGyEp6pOqNlzGpWCXtBkDyxVrgIcFTxDNE84JwYEvSHI27ZU1jJg 5cHQmvNY7sbc12Aw3GKxSAildbGnwHtxeZ87EPaUH/jPdTHVeIlqp9I6Dt7/yXUsAvc3 NISLC67ZW7XLOmTqyE4aQd8YQbzJrO0lqRss8uEwlJ/0G42izzumRQ/9TsXAET6p32Iq wqOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=/fR/EDgs5QerW9DDTFd+U/+Ocmm/Je63W6qVVGcuBkU=; b=p44Bw4Akk3MagMmMpHxz+Js3dUvBVK67jM7EHC39F7aXwZV5PDanxkYk3xUanqnVHI 8SWK+QxWCh93x9/kK9MB6tnpg/lXro6wP4s1js14umBe6fRQZ/MKHDcUvsboqfGJKxW+ 8aIFHZlTETXeS3U9yqSWVp8UCFR4cOp3mSeceS74DqyQGEYOWXD6Cd96dfhc0iW2GA+l mk8Y8lV98vZAb4ajgX5Qb93g5GPwB3dR7/7nHOa7KzH+yGed3lIfVdlwCeN8ZeJUjlOr SulkSWJKSvGyQd+gxrfpor7GDZI5GML8Lvkn4RUqfZdj2sbdk2tieDrCcsEeuyveWWHk R5XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=XRtOftUN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a056a00124d00b00574b1311362si16347009pfi.104.2023.01.15.01.40.24; Sun, 15 Jan 2023 01:40:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=XRtOftUN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbjAOJcf (ORCPT + 54 others); Sun, 15 Jan 2023 04:32:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjAOJcc (ORCPT ); Sun, 15 Jan 2023 04:32:32 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 122959017 for ; Sun, 15 Jan 2023 01:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673775142; bh=h3BV35ExW4Qp8mSJAt5y1TYkCZQhRUQwk+nplpac6xs=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=XRtOftUNorQbmCMcA54sJ3NrwQZVSNveuKgJbOSftQ3YhAniPLLuZd6n26IXyzBvP IdBHzt9gQ8rZfCuwx8McAyz0q2H+nOcVA26wP9Ap4z+eD/nstnLbVAdBeEhuEjwYMk Yn3IEohbNoTvKG/x3Sfn3FqUK71GNlLbyu9dxWok= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sun, 15 Jan 2023 10:32:22 +0100 (CET) X-EA-Auth: DwObgLNILM2GtGPAI+00q8N5h+32tnvd/PwBaxq/eKJBAyAYbimivsEbXvC9hVqYG8F0mkVbytx8mh28znre75c7q2Kq5iw9 Date: Sun, 15 Jan 2023 15:02:17 +0530 From: Deepak R Varma To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: [PATCH] drm/amd/display: avoid variable reinitialization Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The member variable set_odm_combine is already initialized and hence the reinitialization instruction can be removed. Issue identified using the dubleinit.cocci Coccinelle semantic patch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c index 41edbd64ea21..777d8efee977 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c @@ -254,7 +254,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = { .get_hw_timing = optc1_get_hw_timing, .init_odm = optc3_init_odm, .set_odm_bypass = optc314_set_odm_bypass, - .set_odm_combine = optc314_set_odm_combine, .set_h_timing_div_manual_mode = optc314_set_h_timing_div_manual_mode, }; -- 2.34.1