Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e06a7758-1245-4353-7d62-fd6dc40b3164@ti.com>
Date:   Sun, 15 Jan 2023 17:48:52 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RESEND PATCH V3 2/3] arm64: dts: ti: Add initial support for
 AM68 SK System on Module
Content-Language: en-US
To:     Sinthu Raja M <sinthu.raja@mistralsolutions.com>,
        Vaishnav Achath <vaishnav.a@ti.com>
CC:     Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Sinthu Raja <sinthu.raja@ti.com>
References: <20230110110052.14851-1-sinthu.raja@ti.com>
 <20230110110052.14851-3-sinthu.raja@ti.com>
 <d109dbf8-ba51-7322-34e7-f688c5a18908@ti.com>
 <CAEd-yTQ9eEz_Q6ncNP3vc9oerqiXfhrGK7DvsAnm21OZzYUe2w@mail.gmail.com>
From:   Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <CAEd-yTQ9eEz_Q6ncNP3vc9oerqiXfhrGK7DvsAnm21OZzYUe2w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Sinthu,

On 13/01/23 5:56 pm, Sinthu Raja M wrote:
>>> +     reserved_memory: reserved-memory {
>>> +             #address-cells = <2>;
>>> +             #size-cells = <2>;
>>> +             ranges;
>>> +
>>> +             secure_ddr: optee@9e800000 {
>>> +                     reg = <0x00 0x9e800000 0x00 0x01800000>;
>>> +                     alignment = <0x1000>;
>> Is alignment needed here?
> This is used to mention the address boundary. Removing this will
> affect memory allocation. Isn't so?

No memory is allocated out of this region. This is reserved region where
OPTEE runs and thus ought not to be touched by Linux. Please drop the
property.

>>
>> Please see https://lore.kernel.org/lkml/cd5dbbb0-2d9f-8d7d-b051-f8d01d710c62@ti.com/
>>
>>> +                     no-map;
>>> +             };
>>> +     };
>>> +};
>> --
>> Regards,
>> Vaishnav

Regards
Vignesh