Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 15 Jan 2023 19:03:02 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Tom Rix <trix@redhat.com>
Cc:     jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, richardcochran@gmail.com, nathan@kernel.org,
        ndesaulniers@google.com, vinicius.gomes@intel.com,
        jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH] igc: return an error if the mac type is unknown in
 igc_ptp_systim_to_hwtstamp()
Message-ID: <Y8Q/1mFjuYXdJg/A@corigine.com>
References: <20230114140412.3975245-1-trix@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230114140412.3975245-1-trix@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4z2V8iUz93hUtjm7PMbt8Lyz1UE+3ij5jON2c/Tr453UkQTDrhqVuYDR82ha?=
 =?us-ascii?Q?e4YCPxMhI3h56whoqGWJW7CLS+fuoEh5MdymJroOS7lr+ugOQWdySzQw9WzT?=
 =?us-ascii?Q?nf1bEtU+/PNvE6oGkoyWQAPXcofJcVUoNblyya/wkAJ+GpLtD5/GgEl5vitV?=
 =?us-ascii?Q?fpp+BFkIzm89hxCg9scwnL3uUCgb+UjAjkQbupf63mrkCG9fOAznDZS8aGQP?=
 =?us-ascii?Q?H8z+KoGW/xItiMfUD6za4ABoYsCww/f5CTMt3VEWsx0ISiCfdx30lAP+Nd3g?=
 =?us-ascii?Q?uq/aI71zXm0gONI2JMarjAe7UvcFqfFjt8ipE0GbMfQvfA1IyGH92lS4KZ1v?=
 =?us-ascii?Q?cf7hgtp+zZgJSjKA7Go5YQWSbCakTHcQfmq/JCzSBEFyd40E9xr9VzK8cBBP?=
 =?us-ascii?Q?Vgu1fiYh/83ClpSfiVaPhj9rp825UkMrsnyW7uxr4gvyw8RFhG2QGsYs1sou?=
 =?us-ascii?Q?zEvMTsL9WB1iMBMCu+pLaXaoEn0FbfpKxM9E0TXt/Bn68ftnpo68A5rZ9ve5?=
 =?us-ascii?Q?LQGaPgM/su6dhEZb2y+4UsqTj0dNnI71s7MFYCApefd/VJuWCk9dDzuwO2Nl?=
 =?us-ascii?Q?5CDmUgqD4aEPtjv0lUvOJ4rtASHEiSZYzbleTWZhU51zCFrMEy0sI5UT+n1x?=
 =?us-ascii?Q?W1mct14PRcIfnr0SEbN2EYAL4ifwkNwa/1GN9R0p+5zwKEh2TkLJnG2LgMB1?=
 =?us-ascii?Q?FS9U/RxvAmFn9J8JvqZD9qyTcs30XwTAd/Q0NIK98Lv2ZBlYSRRn0WFAydrg?=
 =?us-ascii?Q?Rek3oheKOFWzSaKNoT+IUNAuRM9dzptfFlA7p+1yx+B6//fmOIlePbul69sG?=
 =?us-ascii?Q?/PkA5HDK29FzAiZuJkhQCToaa0uwSm3WGrDIPX29v2Q2dn2Ec2rpW3TOlKWw?=
 =?us-ascii?Q?y5ufF1AEPeav0FZiDVv1lFx/K7rPwBKMP0PR0RKmJuHkFo+Y/+ewFbnkJJfq?=
 =?us-ascii?Q?CAFQQ3faI/vljU5CjPvoTDDgrJ8PmWZr4+9YHR3BU3UBa9Gs6dfrQ1Xq6WXq?=
 =?us-ascii?Q?Q/esjHnNz2DjI+uwUYIUZOr7M3x807gMZphkFh8u06KdNt8qZDqJQfoovChY?=
 =?us-ascii?Q?E9ogdU3+UD8Ea2ojj8pzVKLNlVQyN7c4dyRQh+wj72sh26rPptptqdbSLh/r?=
 =?us-ascii?Q?d8Itub5BrmO0vD9CwEutf3hz8gre1/wwL9LKCdk2p8pnO+RwspvVwTCCEXDM?=
 =?us-ascii?Q?t9Zyk0sT3XTwbRTHKy7e6UrRK4se9kifoCSMiuNYWIPP3JKO4FeWCvZVT8FK?=
 =?us-ascii?Q?kSkXIM86CzrGfJq1ByO9PXyF4giqqTyCqzzKSZ3ccPTMerAmn43xlVw6dv+8?=
 =?us-ascii?Q?fnmVgxEDsyV6QT4SY/RNO8Lr390+5gtd3vF0RY+tMBpqJe0yS/BQtmx/HiLt?=
 =?us-ascii?Q?qiTYXsDy1lNWeUqftlx0jPzqTeKpvQ0vcPuohrcaj7TleiPmpR2IG+aMJ2II?=
 =?us-ascii?Q?GqODxu4QUJhmavvddM86bjfemYoKud3Pesu7Rg2g6AWuc3kO6oS4fVqzKkpw?=
 =?us-ascii?Q?jF6liog91niXVXvA4qyipgY382UzbtPS0RSrqgT7cgvrf8YqufNiJTI3D3ae?=
 =?us-ascii?Q?PXdSFPdbddN4sfBUAR7ZG6N0+RO2FASwhfXs4LWJjiPyrwiFrB76wBhe0Qxy?=
 =?us-ascii?Q?aIuubuQIQ73gaHJdMhPcsDrZf/A2wecq1ZYa1id3UeRjAezHGdsY3ddDYUyv?=
 =?us-ascii?Q?wfmwuw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 410b7116-c5ba-4d44-c25b-08daf722c478
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2023 18:03:12.6523
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U7nfl/C6FNuvRRzx0iai5Vh1EckGglEJk+V20a/+38J2CTTHaHeoheqguzKjHi3DTX+bMam/9YBsC5MsIhqGU7KOMHBiE103wfzKQKON+A4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5814
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 14, 2023 at 09:04:12AM -0500, Tom Rix wrote:
> clang static analysis reports
> drivers/net/ethernet/intel/igc/igc_ptp.c:673:3: warning: The left operand of
>   '+' is a garbage value [core.UndefinedBinaryOperatorResult]
>    ktime_add_ns(shhwtstamps.hwtstamp, adjust);
>    ^            ~~~~~~~~~~~~~~~~~~~~
> 
> igc_ptp_systim_to_hwtstamp() silently returns without setting the hwtstamp
> if the mac type is unknown.  This should be treated as an error.
> 
> Fixes: 81b055205e8b ("igc: Add support for RX timestamping")
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>