Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230112005223.2329802-1-joel@joelfernandes.org>
 <20230112005223.2329802-2-joel@joelfernandes.org> <20230115155455.0fb66c12@rorschach.local.home>
In-Reply-To: <20230115155455.0fb66c12@rorschach.local.home>
From:   Joel Fernandes <joel@joelfernandes.org>
Date:   Sun, 15 Jan 2023 16:29:38 -0500
Message-ID: <CAEXW_YRjV0CqoALU6F_9LZKD_e84gWQ3a8juucmXxLUuDQ7DHw@mail.gmail.com>
Subject: Re: [PATCH v2 rcu/dev 2/2] rcu: Disable laziness if lazy-tracking
 says so
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org,
        Josh Triplett <josh@joshtriplett.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        "Paul E. McKenney" <paulmck@kernel.org>, rcu@vger.kernel.org,
        fweisbec@gmail.com, urezki@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jan 15, 2023 at 3:55 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Thu, 12 Jan 2023 00:52:23 +0000
> "Joel Fernandes (Google)" <joel@joelfernandes.org> wrote:
>
> >
> >  static void
> > -__call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy)
> > +__call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy_in)
> >  {
> >       static atomic_t doublefrees;
> >       unsigned long flags;
> >       struct rcu_data *rdp;
> > -     bool was_alldone;
> > +     bool was_alldone, lazy;
>
> I'm curious to why the the extra variable.
>
> >
> >       /* Misaligned rcu_head! */
> >       WARN_ON_ONCE((unsigned long)head & (sizeof(void *) - 1));
> > @@ -2622,6 +2622,7 @@ __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy)
> >       kasan_record_aux_stack_noalloc(head);
> >       local_irq_save(flags);
> >       rdp = this_cpu_ptr(&rcu_data);
> > +     lazy = lazy_in && !rcu_async_should_hurry();
>
> Wouldn't just having:
>
>         lazy = lazy && !rcu_async_should_hurry();
>
> be sufficient?

I prefer to not overwrite function arguments, it makes debugging harder IMHO.

 - Joel


>
> -- Steve
>
> >
> >       /* Add the callback to our list. */
> >       if (unlikely(!rcu_segcblist_is_enabled(&rdp->cblist))) {
> > --