Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pierluigi Passaro <pierluigi.p@variscite.com>
To:     andrew@lunn.ch, wei.fang@nxp.com, shenwei.wang@nxp.com,
        xiaoning.wang@nxp.com, linux-imx@nxp.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     eran.m@variscite.com, nate.d@variscite.com,
        francesco.f@variscite.com, pierluigi.p@variscite.com,
        pierluigi.passaro@gmail.com
Subject: [PATCH v2] net: fec: manage corner deferred probe condition
Date:   Sun, 15 Jan 2023 22:38:04 +0100
Message-Id: <20230115213804.26650-1-pierluigi.p@variscite.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9yrxfr/9JiX2cP8SUY5ERZVM0rO+CC0XQ9olqqCDnabrJj3vKmBDeCkHN8p2?=
 =?us-ascii?Q?S4E0BZD8BGlB8o7swPtdA1ODKuSrem4YfhlU3NQRr7B5VmUYsSdMFsCQSuRF?=
 =?us-ascii?Q?AWzFKKs+epZrjUCjzDA0pQ7GVXiVduJcZy5g30sdnmSWv5wLEYHfrH5u1wJV?=
 =?us-ascii?Q?Wqv/KD03SrhUks72J+1zULLMkKP5Axt02VY7GVtTXUJqXusyoWKxCGM8ilJg?=
 =?us-ascii?Q?mpip/9yDjOQUctHEvR4sTrORsC32gzL2FgAZAFBbuJleNuSggSz+Gd1lFr2Z?=
 =?us-ascii?Q?xNL/akEmNrhIBB1mAxBClvfPcayl0Bb9Sr6XAxS48R+PjiBAVLOOB8SEHln4?=
 =?us-ascii?Q?hiV6XHvu9cD/aBreUohQNwqtxF2PdoGKwV5spk8DDeN7hRSWlzEb1xK+tdca?=
 =?us-ascii?Q?ZEqCs/4pDZGIKUes7YNDzM0uaLca5OU0SGXZW1M96fls93zB/3sYZS4EbKG7?=
 =?us-ascii?Q?W/5jGt097N1HzKlo63aBMyxqPSCPGL9Xboff+GYDp2DBi09afLSC2DUPVHrI?=
 =?us-ascii?Q?j0bb9qe6rA6X5U8QKfTcQjdl/SxKxHOhbZUhmKLXKuvEpRSVpMoHbn5NXulX?=
 =?us-ascii?Q?mg+38K6bdkBrGdM3FwE+l/V8y1NCJENJ7swQMh6b1YUbJUgs5Kn1z1rLuSS5?=
 =?us-ascii?Q?1myqtq55HX3TtYSloyrEIEjch2ggnPFjiT+5hdH5iQvVtBfBM4hpHTo0sLPO?=
 =?us-ascii?Q?ec6EUTvbnbYkLi7Mwtm3bK2pi6wZfVbTHM9Pn/SsYoQzlouHNnlqU07lgIhg?=
 =?us-ascii?Q?V18yhwiE7oZuNRwzR9f/t414KUWtjd7yGSfvb8M26gJ59WBcKC5pxW1IqoZ0?=
 =?us-ascii?Q?KMkxA2j/rX9VsVy/EaNn7p7sqL4LWSpn8GGMILqCuCEPyXO2nYQfLSpTJiRr?=
 =?us-ascii?Q?6fIyTKX5kDyeBlxVGfN8lAulcxKiDchG6iX0MMIW48+ClWJEF/kGyvTo0wri?=
 =?us-ascii?Q?IbK/EyzBd3L3lCk8wV8wTM0dGbxCgTX0Gr4RN4JiGmi84rdvlMZzbewdG7Rm?=
 =?us-ascii?Q?iL2hINWpN9ZHDFETohgiPoWhFnIdc0p3VWcCvQWUZHXbIge37UqSw0YFtM/A?=
 =?us-ascii?Q?M+nwlv3mofz5ZW3TuB940Op0GK3b2AzJqpDAr+aVyKBOpIUAN25y7VdXJQ8u?=
 =?us-ascii?Q?ImNCszsLDMg0mK6vzifG36nr6YoN048FtQb+n/29vfrqGGYIBBAXrqy76mu6?=
 =?us-ascii?Q?ZVZUUY6VNC+16bIyi0wtTpTyWUApLSEgOGWCQvhyIHKR2hioQf0wMAkLN2T4?=
 =?us-ascii?Q?Hd9LdeFJVvDrhjD1XPMoAJVxvicnvfJFGiINHAqDBOYW1V9dr16v352aCTD9?=
 =?us-ascii?Q?YpkUdpJBnvXRnd820EIhNELmpjIyMiPPJbaYKN3GJWT6954kPeAOh4Z7Zs72?=
 =?us-ascii?Q?46nZcijsOtWfH9Tk2jfZstr+afA71uIEgcJM+WGs3jfpMJmZE4zYh/yNkV53?=
 =?us-ascii?Q?rqT8mLx0D2vvqWB9nfUqjaPU7J+8LNAZNsNwebsxHBa+VxKM0osJ8dTjfW17?=
 =?us-ascii?Q?EN0j4iIM4QRM/ydAIzHfOwOOaBQ/y0xQD/CnCFVnUDwlfTtAEKdhdxU44PaP?=
 =?us-ascii?Q?GVSYmEGQeHNGsXevtS+84sPFiUAV3W44T4EtmicDkN6DMWkqwkcvwwoDqHFW?=
 =?us-ascii?Q?Qw=3D=3D?=
X-OriginatorOrg: variscite.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72b02d3a-b427-4649-a4b3-08daf740ce23
X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB4376.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2023 21:38:13.6162
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 399ae6ac-38f4-4ef0-94a8-440b0ad581de
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w/QAxQo+iN4/mo4roD5PyzDd+nW+dlh1bai83MYTEIsukQSULfYCQv8cGS7MhjAZhM5SOKZo7VxPvDU1sa/pTY06zCblT9LRphEbuWmVAH4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9607
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

For dual fec interfaces, external phys can only be configured by fec0.
When the function of_mdiobus_register return -EPROBE_DEFER, the driver
is lately called to manage fec1, which wrongly register its mii_bus as
fec0_mii_bus.
When fec0 retry the probe, the previous assignement prevent the MDIO bus
registration.
Use a static boolean to trace the orginal MDIO bus deferred probe and
prevent further registrations until the fec0 registration completed
succesfully.

Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
---
 drivers/net/ethernet/freescale/fec_main.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 644f3c963730..b4ca3bd4283f 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2284,6 +2284,18 @@ static int fec_enet_mii_init(struct platform_device *pdev)
 	int err = -ENXIO;
 	u32 mii_speed, holdtime;
 	u32 bus_freq;
+	static bool wait_for_mdio_bus = false;
+
+	bus_freq = 2500000; /* 2.5MHz by default */
+	node = of_get_child_by_name(pdev->dev.of_node, "mdio");
+	if (node) {
+		wait_for_mdio_bus = false;
+		of_property_read_u32(node, "clock-frequency", &bus_freq);
+		suppress_preamble = of_property_read_bool(node,
+							  "suppress-preamble");
+	}
+	if (wait_for_mdio_bus)
+		return -EPROBE_DEFER;
 
 	/*
 	 * The i.MX28 dual fec interfaces are not equal.
@@ -2311,14 +2323,6 @@ static int fec_enet_mii_init(struct platform_device *pdev)
 		return -ENOENT;
 	}
 
-	bus_freq = 2500000; /* 2.5MHz by default */
-	node = of_get_child_by_name(pdev->dev.of_node, "mdio");
-	if (node) {
-		of_property_read_u32(node, "clock-frequency", &bus_freq);
-		suppress_preamble = of_property_read_bool(node,
-							  "suppress-preamble");
-	}
-
 	/*
 	 * Set MII speed (= clk_get_rate() / 2 * phy_speed)
 	 *
@@ -2389,6 +2393,8 @@ static int fec_enet_mii_init(struct platform_device *pdev)
 	fep->mii_bus->parent = &pdev->dev;
 
 	err = of_mdiobus_register(fep->mii_bus, node);
+	if (err == -EPROBE_DEFER)
+		wait_for_mdio_bus = true;
 	if (err)
 		goto err_out_free_mdiobus;
 	of_node_put(node);
-- 
2.37.2