Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0a1f5f9f-7ff7-2b23-2c1a-9ccb1e944ad1@oss.nxp.com>
Date:   Mon, 16 Jan 2023 08:51:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0
Subject: Re: [PATCH V2 1/7] net: stmmac: add imx93 platform support
Content-Language: en-US
To:     Clark Wang <xiaoning.wang@nxp.com>, wei.fang@nxp.com,
        shenwei.wang@nxp.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, festevam@gmail.com, peppe.cavallaro@st.com,
        alexandre.torgue@foss.st.com, joabreu@synopsys.com,
        mcoquelin.stm32@gmail.com, richardcochran@gmail.com
Cc:     linux-imx@nxp.com, kernel@pengutronix.de, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-stm32@st-md-mailman.stormreply.com
References: <20230113033347.264135-1-xiaoning.wang@nxp.com>
 <20230113033347.264135-2-xiaoning.wang@nxp.com>
From:   Peng Fan <peng.fan@oss.nxp.com>
In-Reply-To: <20230113033347.264135-2-xiaoning.wang@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM8PR04MB7297:EE_
X-MS-Office365-Filtering-Correlation-Id: 0cc196b9-38e7-4fa9-e0da-08daf75bd8aa
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 0Byeamzkj4Kp8J7xqenJ679HFwlKkxEUgL8OmCKAxY0wGMqTk6M53qrKL65oAtu4/zSUpZAdho2tlrxPSxZ4cNQz6n9jRN3DMHdnIAcHEEtM2XLvOxQ8m+DVvnP4lX8JZV4a1MFX8Q8tEHDh1+GufuW/jYlh3VXXW0wBo2h2yaJiDMVBg1XPgblPYAHeSZLZsYX7ZrEMXfBppVm1Y4adXnZgSdDVAHih6j3ZrIilYbuIAnl9/jMhG2hMyVXRRg9HgT2WqYcT+OxtGROjJTVbOo1L6LwDo3D9BvQ8/zxPlxi36ohwrLesIDKoKnOC0Us1JILJzcHFqYrZH9vB5qhW+pmWcF9uEwTpNTCDBCfjsGOdGKHqOj2HReTvKSXSte/RWYm5UB5NyfoFv/5SnRsGzg+5ibpeGRxgvWUNv6P5qQkifEwwzvHFg2GcTMLVm1tJ61ZBB4pKwqpvrsM6fvqvcMHjTJFoUoumAQdajaAWK8+WjRiT5TYAyKODRfo1vTTBkH7i9hC0yzFToBGZD1s/mMhxsqkIDFSbTe1JsY6DIXsL33Qi4AkRZ3hLtnAyBSew5mGDzt/AuVMPQl2U7R5/nUpTn/Jz6Sgmvj68d7bnVVMWk5rW+JZQ2D7G0I2zbUpieMcvyOHxyOm9VB1EXylt36yy0aDC4og5s+VQHCHXY44/HCJ6w8dmbCS+2596MN5iLo8pvqqcVoXsLIpoDp6YXzCQS5F8cxDeicJgs8Hcg+75Pdc9xR5QLkOGa8P+vM9DpMbUjXEdtLyxRSt0KjY18Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(346002)(396003)(39860400002)(376002)(451199015)(921005)(2616005)(31696002)(86362001)(31686004)(316002)(8676002)(6486002)(66946007)(66556008)(66476007)(478600001)(186003)(26005)(6512007)(53546011)(52116002)(6666004)(6506007)(38350700002)(38100700002)(44832011)(83380400001)(2906002)(4326008)(41300700001)(7416002)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXZrZjhnNmlyKzcxNUJ4OTB2djA3dm40SzJyTE1IWmdNNVNTS2pGVGQ1SnY5?=
 =?utf-8?B?YkplUXJzbmxaZm5KemU3Z0w2NDN5aXM3ZTBDaWppU2tBQ0hNNTZNMkNzQk9W?=
 =?utf-8?B?NXpxU042YkROcDhiY2E5S0FHM0RpVXZ3MytPN2NCMmRVb0VwWktuYXc0L0FW?=
 =?utf-8?B?ZllDMTNaaDRkbzlxNEtnblRIRlVFeGk1clIxZXhMUENJdXl6U2NCWUlsTEYx?=
 =?utf-8?B?S3NDS25HZTY0aFVFU1lkYWlrQkhnLzBIbS84MkxoNUtKY1BtRHZBZHNGYlR0?=
 =?utf-8?B?Uk50cGRkTFNJQjRvTVZ5MTFOZWpkVFVkTEpRcmN4alJUd1JNdkZMc09EZ0w4?=
 =?utf-8?B?ektRcmFvTHNXWU1zTkVXQUdUWUlWVVVlYjI2T1J0L1hkQTg1YzNuQjc5eTNs?=
 =?utf-8?B?ZGxtdDVxSVFQR3JJSGpXWFowT3hxWS9qWWdCV0piTDdKOGp2TjBIQXM2Nzdm?=
 =?utf-8?B?a2kxSEllbi9vNnJEZG9yc1JLR1ZLMkh1aVVHYVBiKzJLR3o5K0tzZnF4NUtn?=
 =?utf-8?B?cGtsQjNjUUNQTlBKVEJ1VXk0eHlnRlYzdjlzOTE5M1ZmL0REanhZZzh2VUVV?=
 =?utf-8?B?Q0ZpTUJoNmtMMUVwWUpyZjFiYlJtUC9NeTB6MGFhVEUzZ1ZHL3k5VHBpSXhi?=
 =?utf-8?B?RHVKMXdwTGpEbm5rNjM2a1MyY1lRbExmWWJBU3p4bkQyNUlrUDQrMWczOUpo?=
 =?utf-8?B?NWxCSDAvWWRheTQvVkhiMWo0aml5V3lQZXNVZUpCTFEzeW1PQTdPNEVVS21Z?=
 =?utf-8?B?OHRWTzBXRVJBL0pST2VKbFlkM2orSC84NTE0YzVzTXJ4SHYreHRrYTBjcWps?=
 =?utf-8?B?RXRTNmpJNjUwY2loVnA1c094WlNDM092OG9ETk9lZnlwRjlvWWo2Mmd4MUlk?=
 =?utf-8?B?RFBUV3IrVXFhMStONXZaeUZMcmE3cTZPRS93SmR6dCtmb002S0tKZTUrcGdM?=
 =?utf-8?B?VjJRUGZqYUlqSE9CSlMwRXBwdWhQTkQwZENFaTRkWllabGg5NmxMZGZDWFdw?=
 =?utf-8?B?OHNnbSs0N1AvaG1rek5SUGgrZ0o3RzJKWXZESTB5SnRaL1l0VTkwcjF2eGJZ?=
 =?utf-8?B?ZGVaaTE4Z05zcEVEcDVQVkYwWVF1ZldIWExXLzBWVFBIalpYYVFHSGpDYVNs?=
 =?utf-8?B?Z2p2K1FIREpOYlpYTnZqNUpYZUlPc2pUTzlVb2FQUndYYnhybzljVVBlRHp0?=
 =?utf-8?B?alVoSzFIbnlHZkRYNjRZTDBBd2lXOCtEbDJaVnJvbHo4SHU0SzFRWlY2d1Bq?=
 =?utf-8?B?dDFiUnZ5c2JrYlFQZFhaRFV1Y3J5VkpJQVdiUFppYTJGV1BCTElyTTZ6UExu?=
 =?utf-8?B?cHVBQWR2RU9jbHBGZ0dZU1RoTlpSQk9GTkFOOGswUFNwamk1V2loT2lRTW8v?=
 =?utf-8?B?Vk8zUGJPaVk3NndyNGg1TmJHMlBrdFVZb1VCUEd5TTJoWlJHVWhlSG5nUHNO?=
 =?utf-8?B?Tko5VTZMRDA3UHd6dm1PQnBrYWRkQWEvTTIvTlBNSW05UzEwa0N3Ymc4bUhr?=
 =?utf-8?B?aHFtYUhmR0JDbnZTZW90aWNHVHpOc1BNTWtuS2crRFJEWnBpWjJHT3FHbEgr?=
 =?utf-8?B?L0c2b1FOdkxpMmJQdE1ySi9Fd0czT1NZRXQrTUxEQ3VvcVRBcUFTZHFEVExQ?=
 =?utf-8?B?Y0FkenVxVzVUYnU1L25MeE5lbmUzdVNQRVJVT0pNSVJidmJwVUY1VHVkMC9x?=
 =?utf-8?B?MW9nUG8vbktkWFBGbTFUaVZVNWt6RjFnZjR0N0lwZUEyMFE1L0F1ZjRKYW1z?=
 =?utf-8?B?Y29DMHBqbEtRaGJhTnNrdHJoTy9tZVV3ZjFvMXZqc21VUjBQekdvaWFiWUFl?=
 =?utf-8?B?d29TdXA5aWUzMkZCQ3ZaNVZJUzhDbFg1bUc3YU1RK2dkemRHV0JQWHBiakk5?=
 =?utf-8?B?WHVaKzRJYm1Vd2FTM2dxL3Bqc3pZTEFzYU91YTR5TGNQYmlXRHY4b1Vqa1l1?=
 =?utf-8?B?aDh6eFhldzdZeC9qanFQaG5oQlAyWW1VZmMzWk1zYjBtaHlQcU02YW10Q0w5?=
 =?utf-8?B?TjcreDdWYzd1czRUMWU2TXR1Kzdod2tUcnhZd0ViWS8xNXd4ejBvSFpVTits?=
 =?utf-8?B?cU5oTGZyR2RjMjJqWHdYMXc2TVR3bThKaW92YmR3QlpwUGg2ZXpkU1NRdjE4?=
 =?utf-8?Q?HgvRHkiNlesx3HPKJvFdn2YR2?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cc196b9-38e7-4fa9-e0da-08daf75bd8aa
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 00:51:47.9883
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N7nlEsKMDbPDYueYwQ2B9hBEzXqWqRrNy9lQGnQYaov4hs3HJF03xpd+q8pQXMvJqmskglNxg5lR8M1ZV+x8Lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7297
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/13/2023 11:33 AM, Clark Wang wrote:
> Add imx93 platform support for dwmac-imx driver.
> 
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
> V2 change:
>   - change pr_debug() to dev_dbg()
> ---
>   .../net/ethernet/stmicro/stmmac/dwmac-imx.c   | 55 +++++++++++++++++--
>   1 file changed, 50 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> index bd52fb7cf486..a7ea69d81c11 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> @@ -31,6 +31,12 @@
>   #define GPR_ENET_QOS_CLK_TX_CLK_SEL	(0x1 << 20)
>   #define GPR_ENET_QOS_RGMII_EN		(0x1 << 21)
>   
> +#define MX93_GPR_ENET_QOS_INTF_MODE_MASK	GENMASK(3, 0)
> +#define MX93_GPR_ENET_QOS_INTF_SEL_MII		(0x0 << 1)
> +#define MX93_GPR_ENET_QOS_INTF_SEL_RMII		(0x4 << 1)
> +#define MX93_GPR_ENET_QOS_INTF_SEL_RGMII	(0x1 << 1)
> +#define MX93_GPR_ENET_QOS_CLK_GEN_EN		(0x1 << 0)
> +
>   struct imx_dwmac_ops {
>   	u32 addr_width;
>   	bool mac_rgmii_txclk_auto_adj;
> @@ -90,6 +96,35 @@ imx8dxl_set_intf_mode(struct plat_stmmacenet_data *plat_dat)
>   	return ret;
>   }
>   
> +static int imx93_set_intf_mode(struct plat_stmmacenet_data *plat_dat)
> +{
> +	struct imx_priv_data *dwmac = plat_dat->bsp_priv;
> +	int val;
> +
> +	switch (plat_dat->interface) {
> +	case PHY_INTERFACE_MODE_MII:
> +		val = MX93_GPR_ENET_QOS_INTF_SEL_MII;
> +		break;
> +	case PHY_INTERFACE_MODE_RMII:
> +		val = MX93_GPR_ENET_QOS_INTF_SEL_RMII;
> +		break;
> +	case PHY_INTERFACE_MODE_RGMII:
> +	case PHY_INTERFACE_MODE_RGMII_ID:
> +	case PHY_INTERFACE_MODE_RGMII_RXID:
> +	case PHY_INTERFACE_MODE_RGMII_TXID:
> +		val = MX93_GPR_ENET_QOS_INTF_SEL_RGMII;
> +		break;
> +	default:
> +		dev_dbg(dwmac->dev, "imx dwmac doesn't support %d interface\n",
> +			 plat_dat->interface);
> +		return -EINVAL;
> +	}
> +
> +	val |= MX93_GPR_ENET_QOS_CLK_GEN_EN;
> +	return regmap_update_bits(dwmac->intf_regmap, dwmac->intf_reg_off,
> +				  MX93_GPR_ENET_QOS_INTF_MODE_MASK, val);
> +};
> +
>   static int imx_dwmac_clks_config(void *priv, bool enabled)
>   {
>   	struct imx_priv_data *dwmac = priv;
> @@ -188,7 +223,9 @@ imx_dwmac_parse_dt(struct imx_priv_data *dwmac, struct device *dev)
>   	}
>   
>   	dwmac->clk_mem = NULL;
> -	if (of_machine_is_compatible("fsl,imx8dxl")) {
> +
> +	if (of_machine_is_compatible("fsl,imx8dxl") ||
> +	    of_machine_is_compatible("fsl,imx93")) {
>   		dwmac->clk_mem = devm_clk_get(dev, "mem");
>   		if (IS_ERR(dwmac->clk_mem)) {
>   			dev_err(dev, "failed to get mem clock\n");
> @@ -196,10 +233,11 @@ imx_dwmac_parse_dt(struct imx_priv_data *dwmac, struct device *dev)
>   		}
>   	}
>   
> -	if (of_machine_is_compatible("fsl,imx8mp")) {
> -		/* Binding doc describes the property:
> -		   is required by i.MX8MP.
> -		   is optional for i.MX8DXL.
> +	if (of_machine_is_compatible("fsl,imx8mp") ||
> +	    of_machine_is_compatible("fsl,imx93")) {
> +		/* Binding doc describes the propety:
> +		 * is required by i.MX8MP, i.MX93.
> +		 * is optinoal for i.MX8DXL.
>   		 */
>   		dwmac->intf_regmap = syscon_regmap_lookup_by_phandle(np, "intf_mode");
>   		if (IS_ERR(dwmac->intf_regmap))
> @@ -296,9 +334,16 @@ static struct imx_dwmac_ops imx8dxl_dwmac_data = {
>   	.set_intf_mode = imx8dxl_set_intf_mode,
>   };
>   
> +static struct imx_dwmac_ops imx93_dwmac_data = {
> +	.addr_width = 32,
> +	.mac_rgmii_txclk_auto_adj = true,
> +	.set_intf_mode = imx93_set_intf_mode,
> +};
> +
>   static const struct of_device_id imx_dwmac_match[] = {
>   	{ .compatible = "nxp,imx8mp-dwmac-eqos", .data = &imx8mp_dwmac_data },
>   	{ .compatible = "nxp,imx8dxl-dwmac-eqos", .data = &imx8dxl_dwmac_data },
> +	{ .compatible = "nxp,imx93-dwmac-eqos", .data = &imx93_dwmac_data },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(of, imx_dwmac_match);