Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2581723rwb; Sun, 15 Jan 2023 18:27:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXviLheTAY0RtvBCaZlrnDob0biOOF1HJPR46yR9gZRRCJp4T57kKJItFMjEVOrc0zEvJ/nb X-Received: by 2002:a17:906:36c4:b0:85c:e3fd:d39 with SMTP id b4-20020a17090636c400b0085ce3fd0d39mr10830297ejc.37.1673836033983; Sun, 15 Jan 2023 18:27:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673836033; cv=none; d=google.com; s=arc-20160816; b=MoCKQX4Uh20igROmoQAE8X3zHuULELMu7vtu9cmO+X0WsNJ8w1AcAfQYX5nmxek3V9 tA7hTNejn2e+sE3ZL8TWLhOz0q4CFrSObA6DutDj3nQMPaDaz9WL+W7RtzwBGQR5Xpfv qBk3/EgmIedCqGeqcYBZTzMPMOIppJiKMyVrFIRIL7UH9odClpKP5Yg5VI5NM4R5GXWg dmu2kpu8DK3/qOI+BZ8G8oZMxJwqlCDYZE9o5CVRqrJ3qeD4XkrC9hHdiGVGJj7Juevr 8A+xK+F3dHTpHPtnl6t+RmRpmj50U9x/URS+dMZFSl0BeB6IdqJNF3vNdF4wcZ6nyq3X mImQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=YEcSalRdq8PQm6k5KRzq4k9w6eWd+RIVWF+/4DZnEgI=; b=bTd6Udd3UY/48erbMTNR7CqRqLUVV3nQ2ZeOxnijiFlZ2IEOjAhxLCsPftYmVdnJ9I kqYH+2B2yxjt+BF7Cvvh8ewCb+Z0WHChtFTP8OEjlMWRp+ElVAsGn/vrOjakCZpKNL/X pJVGlCx8lqqh3SX/UpIf6j4jAo1FyH1dk4CsYfvgR8ZsIJbZ79qmXD1gLPSCCsaHJnX4 owYP6DRtLRY000rqczYZst5D7B4iddy257HZkhSaVQ42Ojwsu5v/pzKBvREMvMfRch5q uey6lBUxd+P77VgzEJsItHVlCelUc3G47IUnG+uiSTUsgb6mWwLZ8jDmg+4Zj+jsFQHL FoWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne1-20020a1709077b8100b0086ffb73ac3asi2876728ejc.634.2023.01.15.18.27.01; Sun, 15 Jan 2023 18:27:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231531AbjAPCYM (ORCPT + 52 others); Sun, 15 Jan 2023 21:24:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231523AbjAPCYK (ORCPT ); Sun, 15 Jan 2023 21:24:10 -0500 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D95B6A6D for ; Sun, 15 Jan 2023 18:24:09 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VZbYG8A_1673835845; Received: from 30.221.131.155(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VZbYG8A_1673835845) by smtp.aliyun-inc.com; Mon, 16 Jan 2023 10:24:05 +0800 Message-ID: <7db7240f-cf5a-7d0e-6da9-af69641ff18e@linux.alibaba.com> Date: Mon, 16 Jan 2023 10:24:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/2] erofs: get rid of debug_one_dentry() Content-Language: en-US To: Gao Xiang , linux-erofs@lists.ozlabs.org, Chao Yu , Yue Hu Cc: LKML , Gao Xiang References: <20230114125746.399253-1-xiang@kernel.org> From: Jingbo Xu In-Reply-To: <20230114125746.399253-1-xiang@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/14/23 8:57 PM, Gao Xiang wrote: > From: Gao Xiang > > Since erofsdump is available, no need to keep this debugging > functionality at all. > > Also drop a useless comment since it's the VFS behavior. > > Signed-off-by: Gao Xiang The code LGTM. Reviewed-by: Jingbo Xu -- Thanks, Jingbo