Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2603096rwb; Sun, 15 Jan 2023 18:53:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXst0uKts0mXb6XR79eAsL3w/qtsQ+27Tj4ECBfh0BMiQO7pjIDycKSUHr9SJt0iUeMpf39c X-Received: by 2002:a17:907:a505:b0:871:3919:cbef with SMTP id vr5-20020a170907a50500b008713919cbefmr600879ejc.53.1673837608400; Sun, 15 Jan 2023 18:53:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673837608; cv=pass; d=google.com; s=arc-20160816; b=wP2dklCNKyptKApndOUChpEDb0CvkbJ83piarPVCJldxhMjtCAh2Vmo4pT5/D/N8Pf VeafoniCvceXc/WFKJkxKts85XB4SkhbMLY+JDNnPGGAX9JLvn2ydXcZ7vyUD/3AtQNs 8RT2gik4PWQ+wlU6nZeDu86zeJXFXz7Sw0rkzm5VAtFsOpMHlGT9yH9IPQmhXMwCQlTY p23JAzEwkFaPMNNEoGZ2hc8xRv6Q7jmeFdlvdUwu7flrkHFZfQuZplguriz8v5wuakeM 9L3Lc250Ck6AzIphODh7jBUjzuehrWRH11Ro2gubUpdbbF7coJpxnc0a9b63fKGwwxYm n99w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=52ztWwq17GRgIzvvV+YMsbbksgaHDM2xoJqljW6Xj6U=; b=Phr7fIZLSn11+5BzTvyzIYjhYEH7O6pV1LoQuONYbZNQJDKvx6hEcuNJVaOVJJ4wND Bu1XLj0HBh6xaKYnbYjfZAxN7hZ94+zCbw1SLekOeXWJdh1/lDHPoPqk4z0AkubQO9BF 2RLtQqICAZbRJV3mPPdeYIIM0KAhmvqsdjNQ4KJAxjPvYdDvSuXoVVKtwAJlKYY6+2Fr nFFjZi77PZS0bGB2Oudp2jNQ1MhIp+7M2OuDvR+oq6QL8RKDADLyjtPvTe4rEm6MUahn U45v8W9NaL258Fy0N3TNTq8iy6kO315Prhj2VG4g8FRwFQJ8p1kI8PmoyNpfJ9YmSiT9 La8Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=5tEEsvHE; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ae9-20020a17090725c900b007c10d4bddccsi28666930ejc.822.2023.01.15.18.53.15; Sun, 15 Jan 2023 18:53:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=5tEEsvHE; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231667AbjAPC1z (ORCPT + 52 others); Sun, 15 Jan 2023 21:27:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230358AbjAPC1w (ORCPT ); Sun, 15 Jan 2023 21:27:52 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2044.outbound.protection.outlook.com [40.107.243.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 778E1272C for ; Sun, 15 Jan 2023 18:27:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VL2f8OQVK/h6VBJkwLudhbK0PrYGjV1r5qMdMtxmzMdxEeMhTixtjS9TNaDJddxr7S/P2ter8vz/kxbK+05EiEGZc1dQcL4b125Dv7ZG9YDLODDC2DpRTH3WywGbmP2u8nMo/iPGJdEgNrPjMzCSdTISWr5uKDEl981ElIZO+7Azox34efDWgvb0Qbj8KZC+tlfHD8zOY44dVGS4f6ioWJ+34CFIEWCshsZFQ3ZJki+N4ZIs4bqSKrMirL5KrWF6ogcLuI+6/z/IOEfLOoWIjeJDcMgsgW6tCpPhTV/OWBVHRfqIh3jFdBZZ2hMz/MDCBduxxZ4x+gve0JwnmojbtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=52ztWwq17GRgIzvvV+YMsbbksgaHDM2xoJqljW6Xj6U=; b=f9EtOkEaBXR41aFD3gQIDAl6TNV/Xal99IaVsiwg5YtkVei125mFchiJBjuiQ9FbfLnVh1ot13RxMJfSz78WJbJ1BSPUAYhNlt/FXOFLrl2i8uloxcRdsdhXX31tc3WIG3/7oZrh1QQl549GIDs3nmTP0epEZkwNQJGR18kB0tnBQAzUnoT+Fdrgd6yyx4iiGyQJteX42z7G5ONlN5ai8s3DkqSdQS/f8b7MgkEfE8V4b2V1ze4fpZbbYRKOVmtnyhIOGvtmKyB3C4PktK8jLzLqDUXe2cjo2+SdNYW8C2O5dUFDU50i+j0lFfIAD4FMsVCS0UjLc3LGWFw4gl1+CQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=52ztWwq17GRgIzvvV+YMsbbksgaHDM2xoJqljW6Xj6U=; b=5tEEsvHEo6laA0Hiy5LAbVXEbIl5LJeenDlTB346PyitNzlu/ZzxjWSTMgWHE1XA9qDpk2mG/HU/axgXl1VXqkU/GNZ+EaO+UxJ84YIcqqsZaLTqTCqEUItu6QK/QzPrO/2XDlb5F439BtBL4veYGyCJlGu1eoU69IwOwYZwB1E= Received: from DM6PR12MB2619.namprd12.prod.outlook.com (2603:10b6:5:45::18) by PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Mon, 16 Jan 2023 02:27:36 +0000 Received: from DM6PR12MB2619.namprd12.prod.outlook.com ([fe80::5dc8:98e2:7b6e:a9db]) by DM6PR12MB2619.namprd12.prod.outlook.com ([fe80::5dc8:98e2:7b6e:a9db%5]) with mapi id 15.20.5986.018; Mon, 16 Jan 2023 02:27:36 +0000 From: "Quan, Evan" To: Deepak R Varma , "Deucher, Alexander" , "Koenig, Christian" , "Pan, Xinhui" , David Airlie , Daniel Vetter , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" CC: Saurabh Singh Sengar , Praveen Kumar Subject: RE: [PATCH 0/3] drm/amd/pm/powerplay: use bitwise or for bitmasks addition Thread-Topic: [PATCH 0/3] drm/amd/pm/powerplay: use bitwise or for bitmasks addition Thread-Index: AQHZKLE7fuzkAUEui02+QI2mNbwaFa6gUm5Q Date: Mon, 16 Jan 2023 02:27:36 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-16T02:27:28Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=7dfd49c4-0619-48d0-b9ab-5b014d2b1022; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB2619:EE_|PH7PR12MB6466:EE_ x-ms-office365-filtering-correlation-id: ba73e46e-5b10-4618-c1b7-08daf7693b4d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RaIt0e2d6H49KWCGv8Cw/cbMw+ad4vqouJ7177FDP1PN2e0g96UrDcjjKRiXUKRB4kboj2FXkqD4jUTT0YIRz3Zs+vPXc7msN/u+/sP7i8TclZi5DXMy8wj0CXuoleOt4YfpBt77+fUKw+Kptk8Ksa00fQCd6Lk8vBcZ0ba06AZcgzZdLvQQwPNexkDX+Auv0p1GUbF+xcAWouspmeET6FuMNYQ8tFLS3ToeaccrXjiijBvrbH/0RB6CT5k3QWMAmzvVFHjqKajNJowM8NvM3AGMR6jBDSKWXjiYK6SgTQaGy+ley+kBCGIkp5nQSifYK1F3ESbSMX6zaiUmPLvjVkpUWNlTeOmNvODOTqQ7gCtgUrEaE8aQOFGaMucYASk9rIztlUTlp8OmPTDhmX4BRhGNbnSZtjUzy+UD5Rcun6t1ZiyIM+i5K0iWkZjlIVfNqUF0fmmXhEvFfAg2kISinBIBeClhyXwC4PLbWPk1V7FNEP0EPkJ3NLdT8JfVi89UDepA4rnMu8eZk3BdFZZmgcxgZyxycwDcaoiml3UcSLkZtocQEyryq2X9xPm7fYQuYlwOsDDjO5iaixw8OCK9uDVAaKBxfRNogyUhpYu0BZFXGNmOS9giIrXE4+ivoR1gDQq6OGfuyyc7LuGOfKtT4NyNuZS9Ttrs8c0MpwEdNxSTe/VSrJ34FnWxFMnEqKZz2t68oDO/ivB9ol73bkRqm95MNEKDeUSII9YjkAcJPEI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2619.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(451199015)(9686003)(186003)(55016003)(71200400001)(7696005)(53546011)(26005)(2906002)(66446008)(478600001)(6506007)(76116006)(8676002)(110136005)(54906003)(4326008)(316002)(83380400001)(41300700001)(52536014)(66476007)(8936002)(86362001)(66556008)(5660300002)(921005)(64756008)(66946007)(122000001)(33656002)(38070700005)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v0fFXDTb2L9RCODrwC+uRO4LRv8oCsrzlomcyYBLtykuh+OxMJ1hP2OYTT20?= =?us-ascii?Q?IUOHdyNkCuxGs15ABPBcz9/msIFxQeMLRIIGm7Xm3TqVRexd7in/EKOLrExW?= =?us-ascii?Q?aJJzC1yCXQAgMu66KL1d+7GN3hLwsRTaWuFjzp694hVNSfU2YZQEL6N17lAp?= =?us-ascii?Q?fR88eJJKCVcao865WsMRHS2MUCowi5W8uqP4vSkg0iApwns4E1cD79MR/CEB?= =?us-ascii?Q?aAwBUhu8pblvNbbEpH5P1FA+7xTdqV3aO12FIZIgSJhn7tyVwsbd1VC1Uk3T?= =?us-ascii?Q?aJcAxJoTg30DjHe8Moq0Qcpqbg7UyUhRDH5VTm5PZTCgGCNQiL0G58f0mssn?= =?us-ascii?Q?JsEKsgj71Ot0OU41yU1NdsFqCaayM0iWLA72U8p8cNrU+tHJsUtVM3y/R85F?= =?us-ascii?Q?D4GgWpB4NRZV4dkpLxM/2dUtAn2UYFii9CpE1kohokyxE4Vjtv1DIs5RbSNo?= =?us-ascii?Q?aQny0JkKzh/bNSVkAPB5u7JUey/Y/4hOnIaSnz2V5oFKyz3CZIybRBcgsYiZ?= =?us-ascii?Q?PPDMP9+usUfXhOy0VQNcAOceRdcvsGffFcszy8uYaXZbIXjwuOZUIjJ/XV0v?= =?us-ascii?Q?5nTHn2j9jwKg4EJ3pBNYJqLG+Xm5KMW1Bm16ubMzy4ETiZ0CnMK3nEAeSsx6?= =?us-ascii?Q?eAhk0bzbRVOiz+9hfHDOm3XRr/TKuP22xj+AG+X89U/vHHDEQY4rWbUl4pcu?= =?us-ascii?Q?nHZUo853gm/NaQ12ZwMJ1/AAcKXAiyAodU0/sNBrQ3i2hjPShKVGY767HzcO?= =?us-ascii?Q?D4yy2x3KYXQGe0NytgdfyJ+mYb4Da4xUF9ZH9tOB/BDRZrPVXv+DsS1jlS4/?= =?us-ascii?Q?wocNgbLFlj31UeqInNJ3hGLSlLitHB/ZoTr4+iuMzNBeGwu6/6GQ/b3SnBej?= =?us-ascii?Q?ltAgAtue08Ded19MD7nrN5jbeYlq1h+mHHfQ6FG4vCHqBZCY9faeK597qNxN?= =?us-ascii?Q?KM8Xt/8JSCkC6dXE+PlVyByFXDWy1/kS985DM6AamSLD9I2IW+RYL/RGWKj9?= =?us-ascii?Q?rc0lWeUUUsow2gIPzXn/FFchBe8bBgAcB3kKY2FPgI3o5xdTCwq/VgOn2XeG?= =?us-ascii?Q?0PAqbcwJy2ny1uO9x17SZqT0DzygPcKrfwX1KOa0J6Rf7Z0cn5jPEu2JfsgY?= =?us-ascii?Q?k5pvE7uDIVYBQ9jey8BaxEtYOwI1A4IhMjLsOKuFS6TP00RlC8QuCV3QFxI1?= =?us-ascii?Q?3U7id8hr59swk/JXcTN5+ob716TXieqXI1620zBU/QM3j04dpxvAAwhBjWQ3?= =?us-ascii?Q?lkh0smiK2cgek8sduyrTrBJogSxEp84Yh+AHvPkHSpSnDDVwiRVHaylhHVLT?= =?us-ascii?Q?fIh3ovKnC6ATr8D9AlG1oEUJDx+W/KHc7hI3YszXqh1jZ37tuud41oFc3a8z?= =?us-ascii?Q?n563Fu0BOi/EP76a+KXdUkWMl9/W5IlL6pwcYF7n3WTCyVKJ0q+89Mu3n9xa?= =?us-ascii?Q?tCc/xovfZvnBUlCHZMuLwdr2sI/kPcTLYBnnph//E05wBFr0ZmKoilUhWcJt?= =?us-ascii?Q?dstTfGfnEPXRxxytdBmobReoWOwxqKBNsgzV8yj9RZkKRNc7goC9fA4BjSkZ?= =?us-ascii?Q?3AKC/d7anHjZSU4D8hg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2619.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba73e46e-5b10-4618-c1b7-08daf7693b4d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 02:27:36.4612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qf8uN4NVo1FJ0a/5f86KTq4+iaEX8DDSsw026+wti8JzfXyJAOqEPcKrHdetDCvr X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6466 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [AMD Official Use Only - General] Series is reviewed-by: Evan Quan > -----Original Message----- > From: Deepak R Varma > Sent: Sunday, January 15, 2023 3:16 PM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Daniel Vetter ; amd- > gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org > Cc: Saurabh Singh Sengar ; Praveen Kumar > > Subject: [PATCH 0/3] drm/amd/pm/powerplay: use bitwise or for bitmasks > addition >=20 > The patch series proposes usage of bitwise or "|" operator for addition o= f > bitmasks instead of using numerial additions. The former is quicker and > cleaner. >=20 > The proposed change is compile tested. >=20 > Deepak R Varma (3): > drm/amd/pm/powerplay/smumgr: use bitwise or for addition > drm/amd/pm/powerplay/hwmgr: use bitwise or for bitmasks addition > drm/amd/pm/powerplay/smumgr/ci: use bitwise or for bitmasks addition >=20 > drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 8 ++++--- > - > drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 +- > drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 +- > drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) >=20 > -- > 2.34.1 >=20 >=20