Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 Jan 2023 06:26:22 +0100
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Peng Fan <peng.fan@oss.nxp.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Abel Vesa <abelvesa@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Richard Cochran <richardcochran@gmail.com>,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        Lee Jones <lee@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        linux-kernel@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
        kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
        linux-clk@vger.kernel.org
Subject: Re: [PATCH v1 05/20] ARM: dts: imx6qdl: use enet_clk_ref instead of
 enet_out for the FEC node
Message-ID: <20230116052622.GA980@pengutronix.de>
References: <20230113142718.3038265-1-o.rempel@pengutronix.de>
 <20230113142718.3038265-6-o.rempel@pengutronix.de>
 <76716956-3f15-edd0-e9e2-bdba78de54f9@oss.nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <76716956-3f15-edd0-e9e2-bdba78de54f9@oss.nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Mon, Jan 16, 2023 at 09:01:08AM +0800, Peng Fan wrote:
> Hi Oleksij,
> 
> On 1/13/2023 10:27 PM, Oleksij Rempel wrote:
> > Old imx6q machine code makes RGMII/RMII clock direction decision based on
> > configuration of "ptp" clock. "enet_out" is not used and make no real
> > sense, since we can't configure it as output or use it as clock
> > provider.
> > 
> > Instead of "enet_out" use "enet_clk_ref" which is actual selector to
> > choose between internal and external clock source:
> > 
> > FEC MAC <---------- enet_clk_ref <--------- SoC PLL
> >                           \
> > 			  ^------<-> refclock PAD (bi directional)
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >   arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> > index ff1e0173b39b..71522263031a 100644
> > --- a/arch/arm/boot/dts/imx6qdl.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> > @@ -1050,8 +1050,8 @@ fec: ethernet@2188000 {
> >   				clocks = <&clks IMX6QDL_CLK_ENET>,
> >   					 <&clks IMX6QDL_CLK_ENET>,
> >   					 <&clks IMX6QDL_CLK_ENET_REF>,
> > -					 <&clks IMX6QDL_CLK_ENET_REF>;
> > -				clock-names = "ipg", "ahb", "ptp", "enet_out";
> > +					 <&clks IMX6QDL_CLK_ENET_REF_SEL>;
> > +				clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
> 
> 
> Please also update fec binding, otherwise there will be dtbs check error.

Hm, there is no restriction on enet_clk_ref use or requirements to use
enet_out in Documentation/devicetree/bindings/net/fsl,fec.yaml

Do I missing something?

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |