Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp2792439rwb; Sun, 15 Jan 2023 22:43:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXud2Hi8o8/jzffyzQnEbKPyUXGITOeH98/ZKI8QlZj006zjYcuZQk0eUIYTf7UARtZgDGf0 X-Received: by 2002:a05:6a20:a8a1:b0:b8:648f:f414 with SMTP id ca33-20020a056a20a8a100b000b8648ff414mr4863804pzb.29.1673851410752; Sun, 15 Jan 2023 22:43:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673851410; cv=none; d=google.com; s=arc-20160816; b=Qt4rKreUjr149Om1bthbg2m23drp5TKI11OQU9edvN3KKbE6MW4bfAMtVPGb0MT7sI Y1xqOjf1hb6hv9jmNZzPL5jBcWkQkwu5VT6Na6F5XB17eb6GbPRylEJs2ZFr4o9WzLtG j7Z4+782nntlkWxhetn4aM6+8hrOMgVWpBmlfAIy9nP2h9nfzscCZOezBh1nEnXcnowp qCuqBcd95dYPGczAERAhQOkJ8EekTwPmfIPpumdfNMynNDWUyx/su/jlphsEPgSuGWn2 7L1JFmE9jIrGj3t5G4mIYzgCHvMYdDZ4wb05sRn/Ie3rsQZfuz8Rv7QN6fOjtSl9pza1 NUVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ZbkXesA3z5EusFVk2I7ry0ytrk+BNjeWTEkso9sdW5M=; b=sVtXqNv6OsbVHOAHOZ9LsQmCGYH96XXCqO0dmBuiB+TKlNvDwnsriOp4YmEGujrq5c Pa099z1Kk8bKzepkbfpQtwzfglid8c9mPFYBAoiKi4uGmzEeMZjP47UzJNNy8bB1tBei /V54BoqqTq5wbqFlUunERwsriAjJKAueJ6D8mccDoCyY+58EuBGLczqSoK6vjga5pnLm MLph/pSsl0GMJhqjyV3KO8LDtaB0Q6shSBQat+rv9o6edKhjZ4FhPbAkAI8oBrh4p5f1 lfQ+vxn1Bu+GUl1Q32M/YA/UPhWoc5QDdIYeWNBCsA0sfSj4HbhZfjES4tcyn92EK4NK 9K2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CdNswiX6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t3-20020a654b83000000b0046f51cbaf53si29613898pgq.529.2023.01.15.22.43.18; Sun, 15 Jan 2023 22:43:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CdNswiX6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231903AbjAPGYF (ORCPT + 54 others); Mon, 16 Jan 2023 01:24:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231827AbjAPGX6 (ORCPT ); Mon, 16 Jan 2023 01:23:58 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB7C49ED0 for ; Sun, 15 Jan 2023 22:23:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673850237; x=1705386237; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=a+MM6LFSFN6O0Ul1MbCfo6cLTpT945+XnwjwGbaR2AM=; b=CdNswiX6B38JeV2ub5DOgNYiQxy6QDON2M76o7mmWLFts8ZplKzk2xMx XwMSDSoMJimpFsxi8FmnDTlQH6m9LP+30iAXyWkXP+h/9BDKbSgp8mfWh DyJR71dBPScS0kTZA2gbXXECYqkwvbIFKaGjIyuzVjR2VKFyYNur7FWP5 KuA00clJHX7szWPGex6GnNi7oAPBYW/KzDom1q+JuKhLsCpXHDZ2EbfpG Z3OQHKZyA9Ij472nhMCgkMlpiMG/FsGQvvg3/SbnmFE9pG0kAMNSy6Yp/ gRenF80V5RcZd2ofdonKwyL+FoFf5zrRRvUimRYhC8jdhmYM2/xr8/CXg g==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="326454287" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="326454287" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2023 22:23:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="658916451" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="658916451" Received: from dev01.bj.intel.com ([10.238.158.76]) by orsmga002.jf.intel.com with ESMTP; 15 Jan 2023 22:23:55 -0800 From: Huaisheng Ye To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huaisheng Ye Subject: [PATCH] mm/damon/core: skip apply schemes if empty Date: Mon, 16 Jan 2023 14:23:47 +0800 Message-Id: <20230116062347.1148553-1-huaisheng.ye@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sometimes there is no scheme in damon's context, for example just use damo record to monitor workload's data access pattern. If current damon context doesn't have any scheme in the list, kdamond has no need to iterate over list of all targets and regions but do nothing. So, skip apply schemes when ctx->schemes is empty. Signed-off-by: Huaisheng Ye --- mm/damon/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index ceec75b88ef9..f338691e4591 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1230,7 +1230,8 @@ static int kdamond_fn(void *data) if (ctx->callback.after_aggregation && ctx->callback.after_aggregation(ctx)) break; - kdamond_apply_schemes(ctx); + if (!list_empty(&ctx->schemes)) + kdamond_apply_schemes(ctx); kdamond_reset_aggregated(ctx); kdamond_split_regions(ctx); if (ctx->ops.reset_aggregated) -- 2.31.1