Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e0a87379-eb1c-b1d7-514e-5821e96e606f@amd.com>
Date:   Mon, 16 Jan 2023 12:29:08 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 08/19] ASoC: amd: ps: add soundwire dma driver dma ops
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        broonie@kernel.org, vkoul@kernel.org, alsa-devel@alsa-project.org
Cc:     Mastan.Katragadda@amd.com, Sunil-kumar.Dommati@amd.com,
        open list <linux-kernel@vger.kernel.org>,
        Basavaraj.Hiregoudar@amd.com, Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mario.Limonciello@amd.com,
        arungopal.kondaveeti@amd.com,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>
References: <20230111090222.2016499-1-Vijendar.Mukunda@amd.com>
 <20230111090222.2016499-9-Vijendar.Mukunda@amd.com>
 <77e35f54-323e-42d0-9e74-be984eebc0fe@linux.intel.com>
 <6bb9b13c-2829-d7c3-872b-6e9586189300@amd.com>
 <3bb2114c-cd0c-f176-c837-90a665a25343@linux.intel.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <3bb2114c-cd0c-f176-c837-90a665a25343@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUhFZTlWQ0F1MnB4aitkeEZ6RDdrdU9LQlU3U1VqVStwVi9MTDlmZnUycjRY?=
 =?utf-8?B?dkNkRlliVmoyN0RrWExaQ08yTmtvcHBIQi9sU05Xcng5MmpPWEJmcnBZMzE1?=
 =?utf-8?B?UFVTaUdpQ3d1WHlIQVl6YXBVQ0drZ1BKeGtqc3gxVk1JR29RbjliN2pRbm90?=
 =?utf-8?B?VFZZYnp1ZEFMMmsycVc5ZzNsN0Y5dTJnM1YyVHVnZWFQMHl5OWg5T1kwNkQ5?=
 =?utf-8?B?RUFoaVdrNWtWSDFiMUZPNlJOR1J5MDJtcWpXaUNaUWFGRzdIdG9URXhaZzRR?=
 =?utf-8?B?UjVJS0FUSWY0aHdhcG53M093RVpFd0ZaaVdyRERPT3lZOEQrZGxVS1RmNnVX?=
 =?utf-8?B?MllDbVRxQ055YldHM2JDQ3JVdUxhenU1S0NFOVpyZ05vQlBKMEtxNENoQXBL?=
 =?utf-8?B?RkV0d0JqOEcxTjNGbjZOM2I5VXdGL1NwR0pzaVd2RjVRMlV4TmVuMW5ka2tS?=
 =?utf-8?B?eUpOaDhScTJMbHRYK3djeVFhQWo3eG1UMTRzYVFJaTVLUVptcEhsdGRnVEsw?=
 =?utf-8?B?Ymp1TVg4TnVaeGgrRXN0UG0rNk5CM0o5aUU4RXg2TUJNcmVHdDlZVlVCUUpw?=
 =?utf-8?B?dEtSTDhFSjJiZUF0WXdEZE5tQnorSnJiZmFTbUs0Z3pQQlpyVDFTNE1PU2JI?=
 =?utf-8?B?TTkyaC80TWp5WEcwS3NMT2p5VGZRQk9DU2tEUFBJTzZFMkMweG9tWFIyV2FW?=
 =?utf-8?B?aDd3TE4xbUJ2eVBBNzZWNzNsaW4xSTFaNENVb2l6cEZSZHNDclFSOW1tNXMz?=
 =?utf-8?B?MGEwTUxWV1g3MVpMVkVUV05hMHMxTENweXByMFhyTjlpdCtKMlRjR3d3Ny9M?=
 =?utf-8?B?RFdMcWJSVm0rcloyQTNQL2FMdDJjc1F1Ym04ejhjVTV3SzhvTUZjQXIxQkVJ?=
 =?utf-8?B?azJadVlvZ3FxcjhacElZTFRpcEdkYUZ6NFg0aVBlaTdYbnlES2VKTTM2b2k1?=
 =?utf-8?B?a0c5U1VOS3lMZStxS1pDcGpwWGdUbFVTanR6cWtTcWd3SGVCZVQ5aitWalg4?=
 =?utf-8?B?SXhsTHY1MXVsNU51dXlTbXZHNDNETFY3MkdTaTV3N2xnb01iNXpEVU5VSHND?=
 =?utf-8?B?ekhjSFlvTTJ1eUg2cTBVMTN3WFpvTjJvUGNxOGVFZ3ZxQ2VzS1d1YTFFTWdQ?=
 =?utf-8?B?VG1oU0NwNUJEL0hFZnpJdFNLeUQ3aTR4ckw5Um52b01VeVdzYlBLdnhjM2J3?=
 =?utf-8?B?QjVuakEweGVXLzJQMS9xT2kyQ1lzVUlzWXRpR2o5ckdOZlRCSXNEZGhvbGs0?=
 =?utf-8?B?bDYwMUxJTmRNQkM2OXE1bjhhUkZqYnUzcy83U3ZKTEI2Wm5UN0RhMENhK1JM?=
 =?utf-8?B?ZFRoV25TZ2t2RFplRUdBdnF0KzdJSU1MUDc1N0hJeG5sVXpNcW01SXFvRUZ3?=
 =?utf-8?B?Nmp1ZThjS2t1NWNYR1FQOHh6QzJEUEtBSXZoSTRVZkIwRGlIVjRnU3E0OExx?=
 =?utf-8?B?QW9WY2VQdWw1K0RHU3JDL0ZvSHArSitYNkVQTVMyQWdaMUJ1aUM1NjBSVVpP?=
 =?utf-8?B?VllLWGhCbjFJL24zeTQ1MXgvbk9EcW1iTnJKcEUvREYzN2dueDBpcmRzaUdC?=
 =?utf-8?B?Z3pSb0pWVnc0U1RGcjBub0F0UTNESE5hWUUwTk9tbDBuYW0zeE9rZkZucklk?=
 =?utf-8?B?TjNsVmlzK3IxZS9WL3YzNzFURXpRcDhENkFIYUd6N2owck55N0NtaEFibk5E?=
 =?utf-8?B?OGU1NUtDZUIrUnZaK2FMY2dDLzVPMHZvUW5FMFhCdXpIYmFyZGk5djJHaDlz?=
 =?utf-8?B?elhuTlhJVFJMOUxWSjQvREUweXVSZXBPS3JWNEVRWXZxR2wvU2JjK1FZVktz?=
 =?utf-8?B?amY3dEo2eGhEU3UrTE5VQ1k5OWNPdTJUbklYMTh2ZTY1OGFBZFVyU2JOM2lr?=
 =?utf-8?B?cGNaTXFocHdnY2diNkpLRjMzb05CMkNmWUpEdExwNktTdWFIYXN6enpJMWdx?=
 =?utf-8?B?RHBkc3FIQmZLWU5aa1ZlYlpnQUkxNkxVd1NEVy9nczluazl6TUxWTEVtL2Z1?=
 =?utf-8?B?YTUyMHJ4SktsYU5YVVRFT3d0UEtvZ1lnd1hCOU5sWkJxZWZYcWJLMVNtcWVY?=
 =?utf-8?B?OTlRVkdrc0hjdDBtOHRwY1NHcmlZeDRHRy9WNURJS3lLME1qK0RueFMxZ1hB?=
 =?utf-8?Q?cgz4qShIfnTKixCZOShfetUWC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a90b8513-3fca-4748-e8fb-08daf78eb906
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 06:55:59.0356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6hAWlDY5PjLMkycoJSvqiLLWYOl1FQffyb96DeqoHO7CN1b9DQIiC7TMtS7vhfE+1UGrEIw0FmuVTsqkA83krA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4869
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13/01/23 22:35, Pierre-Louis Bossart wrote:
>>>> +	sdw_data->sdw_stream[stream_id] = substream;
>>>> +	size = params_buffer_bytes(params);
>>>> +	period_bytes = params_period_bytes(params);
>>>> +	sdw_stream_data->dma_addr = substream->runtime->dma_addr;
>>>> +	sdw_stream_data->num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
>>>> +	acp63_config_dma(sdw_stream_data, stream_id);
>>>> +	ret = acp63_configure_sdw_ringbuffer(sdw_stream_data->acp_base, stream_id, size);
>>>> +	if (ret) {
>>>> +		dev_err(component->dev, "Invalid channel type\n");
>>>> +		return -EINVAL;
>>>> +	}
>>>> +	switch (stream_id) {
>>>> +	case ACP_SDW_AUDIO_TX:
>>>> +		water_mark_size_reg = ACP_AUDIO_TX_INTR_WATERMARK_SIZE;
>>>> +		irq_mask = BIT(ACP_AUDIO_TX_THRESHOLD);
>>>> +		acp_ext_intr_cntl_reg = ACP_EXTERNAL_INTR_CNTL;
>>>> +		break;
>>> so there's ONE resource to deal with external codecs? How does this work
>>> if you have a headset codec and an amplifier?
>> Are you referring to playing a same stream over headset codec and
>> amplifier?
>> It's all about channel selection from DMA perspective.
>> We have tested speaker aggregation and headset playback use cases.
> No, I wasn't asking about playing the same content to different sinks.
>
> I was referring to playing/recording different content to/from different
> devices.
Yes , it's possible. We have tested parallel RX and TX streams.
Please refer patch 2 review comments reply.

For ex, speaker playback we are using Audio_TX Channel whereas for
Headset playback we are using Headset_Tx channel.
>
> Even when interfacing with a single device, there are interesting
> topologies in the SDCA spec that would require multiple DMA transfers
> conveying unrelated content (or processed content from the same source).
>