Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <n-Xd5VZl4mxdBIPvH-LgdDqAi8N9cL3TiAQ6fKEOpXLKsyDAxcf9VWQZfnMobTdIXucJJ1U2B82W6KhoODwWr_n3d-V9YkDcV92AjzxMrys=@n8pjl.ca>
In-Reply-To: <n-Xd5VZl4mxdBIPvH-LgdDqAi8N9cL3TiAQ6fKEOpXLKsyDAxcf9VWQZfnMobTdIXucJJ1U2B82W6KhoODwWr_n3d-V9YkDcV92AjzxMrys=@n8pjl.ca>
From:   Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date:   Mon, 16 Jan 2023 08:48:41 +0100
Message-ID: <CAKXUXMwbkDgwMvB-CDyDbL7CS1eSn4P=87BqfWCyvCvP+SkQ8A@mail.gmail.com>
Subject: Re: [PATCH] pcmcia: avoid defines prefixed with CONFIG
To:     peter@n8pjl.ca
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux@dominikbrodowski.net" <linux@dominikbrodowski.net>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 13, 2023 at 4:30 PM Peter Lafreniere <peter@n8pjl.ca> wrote:
>
> Macros prefixed with "CONFIG_" should be relegated to Kconfig switches,
> so we should change the config state flags to avoid conflicts.
>
> This change affects only code readability, not function.
>

Peter,

If you are interested in doing more clean-up work in this area, please
let me know. I have a longer patch series of various changes that have
been partially submitted and have not been included yet and some
changes I have not sent yet, as they are really minor spelling fixes
in comments. Further, I have a list of known false positives from the
./scripts/checkkconfigsymbols.py warnings, which you can use to filter
out some of the warnings, and some experience on this script to find
what is more relevant to address first and what could go to the
low-priority TODO list (that just might disappear, as old code is
completely deleted).

I can share all that with you if you just give me a ping.

Best regards,

Lukas