Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 Jan 2023 09:04:27 +0100
From:   Johan Hovold <johan@kernel.org>
To:     David Heidelberg <david@ixit.cz>
Cc:     clabbe@baylibre.com, gregkh@linuxfoundation.org,
        LKML <linux-kernel@vger.kernel.org>, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 1/2] usb: serial: add support for CH348
Message-ID: <Y8UFC/1vH/Y9PeBN@hovoldconsulting.com>
References: <0fa6e2b8-0585-87a3-f255-5301774a6d9d@ixit.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0fa6e2b8-0585-87a3-f255-5301774a6d9d@ixit.cz>
Precedence: bulk

[ Please fix your mailer which generates broken Reply-To headers:

	Reply-To: 20230106135338.643951-2-clabbe@baylibre.com
]

On Sat, Jan 14, 2023 at 10:05:18PM +0100, David Heidelberg wrote:
> Acked-by: David Heidelberg <david@ixit.cz>
> 
>  > +    int i;
>  > +
>  > +    for (i = 1; i < CH348_MAXPORT; ++i) {
> 
> One nitpick; it would be nice to have a "for" loop from C99+.

No, I prefer this as it stands (and we only have about 80 instances of
such fancy stuff outside of tooling it seems).

Johan