Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <27eabbf2-eff2-0964-b72b-f9db251c3b57@amd.com>
Date:   Mon, 16 Jan 2023 13:32:54 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 01/19] ASoC: amd: ps: create platform devices based on acp
 config
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        broonie@kernel.org, vkoul@kernel.org, alsa-devel@alsa-project.org
Cc:     Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
        Mario.Limonciello@amd.com, Mastan.Katragadda@amd.com,
        arungopal.kondaveeti@amd.com,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>,
        Nathan Chancellor <nathan@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230111090222.2016499-1-Vijendar.Mukunda@amd.com>
 <20230111090222.2016499-2-Vijendar.Mukunda@amd.com>
 <9f2229fb-499b-f802-993b-56a7ad2ce361@linux.intel.com>
 <257b6f1e-f403-573f-3978-13ffb14342ad@amd.com>
 <2b4c12ce-2586-0277-ede0-560f8317e4e4@linux.intel.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <2b4c12ce-2586-0277-ede0-560f8317e4e4@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VG8zY1VXbUZ3NE5uTkdpNW9EeTZMbkV6dTZaQ1NOU0hmUUlRUTZraGsyb3lL?=
 =?utf-8?B?TExEWTROcmgwanNsMG4zenJYWjRPY01DeERsR0xYcGhKTmlqT2xXbkNKaHlI?=
 =?utf-8?B?NHY5Ri9YZ2w3Slh3eDVPalowckZwZ0FpdENkbE1Wd1p0SWY2UXpWSmE2M2VB?=
 =?utf-8?B?TXJFYUpDeGpJSjRjTUhSMzlyaCt4bW1Oa2Jha3IrdnJxUWdxRDZTc2dnOERD?=
 =?utf-8?B?RHhjc2dTR1JKSkFCOThIUFMzTkttbE1ta3hFb3VmbGFSR3FDRGhLTkluMXhh?=
 =?utf-8?B?SU9ZUExHY3Y0WUFDdVBOVHl6OHkxN28rMTBqM3JVRFB5U0JPWUFKY250UWVQ?=
 =?utf-8?B?bTFGU1REOUl0QlhDWlkydm8rZXFCc1hSdHZBUDV0N0hhTXpmbHY1UlpyYjZE?=
 =?utf-8?B?ZkVseFVYeWRJbmF4L2dtQm5DYThKdko0emdHanJWckZFZEJCckpVUTgzMlc3?=
 =?utf-8?B?T2lMQ1d1eXh1ZW1hblEvNkNVd0cwOVVwN2JqbHh4RU5JLzJDZC9sVmNaY0FH?=
 =?utf-8?B?VmNFREQ1ejBoQXgycmhEcXowN3BoMklZSTZQaDNPcXFrTEFkRTE4d3RMSzk5?=
 =?utf-8?B?SWNOV1BzZFZlVDF2WHluTE1BRmhWTk9uZW1ZeGpvNlVaRlJVVVl6MEhFRVN6?=
 =?utf-8?B?NWlCVnkvS3JvdW5QMHQrcVJvYURFU2hObHhFQTFGMXZsbGRQT2VOb0FyZWhF?=
 =?utf-8?B?VXQzamxUUVRxZnRkK0ZoRktuclF0a3MzbkdxbUxMYUZjN0Voc0xrVW8wUWRx?=
 =?utf-8?B?WUJUaUFrZ3hzZDdsSE1ZMzgwN04rVW1OUDFyRGlzem05elE3M0JMbWpLZHN2?=
 =?utf-8?B?ZjhzeTlCM3g0NXFBcXJEVi9ibkRmQThmNUdQRTZZUXRyODFJVjBPdWYvTlQ2?=
 =?utf-8?B?c2RYeUFrdDZZU3dxUElSbzY2N2pJcVhLbXF1cnRSL1N6aTFNa0orb3kzb0Vp?=
 =?utf-8?B?MEt3NnpLMjVQZXFJc0ZKNlg2SGZlN2dyWlVtc2E2Q29Fa2pEZFFxQkZ0anMv?=
 =?utf-8?B?V2ZQcjEwS1BYOWhJeVFtZTcxMEhJaDZxcnFoRjhIeXF1dlo4RHdRRDlKaCsx?=
 =?utf-8?B?bTMzTmpuQWs2SWJBV3Q1TnpoMzRtT1VneFhndHIrWjRkWkNOSlBhbnFySkJ6?=
 =?utf-8?B?Z1YyM2ZnRlI1Lyt3UlAwcDJYbkc2d2hWNjFUdm5WU1ZKU3dleXQ0ZlN6Mmxp?=
 =?utf-8?B?Zi9TbGQzajRnYzZIOGMyK3VOekxzeG5MQ2o2cHk4eHFZRkUxOC85ZVVIVE04?=
 =?utf-8?B?Q3RKbllQTUhibGxSZUhSTUQ2SUlCZWc1K3h3cXBvRjJDdTU1alVRZHhoYW41?=
 =?utf-8?B?TjUrQjhQb3ZEbUNGTXAzYjAwcUdDTXE3WGcwK2h3Q2FxM1hibTJQOTNEQXBy?=
 =?utf-8?B?WDgxeHVQWllNK0NKNnUyS2RGa3hGVEdrUUNMbWFQSFN2RXFIMWViRmNDeFhM?=
 =?utf-8?B?VFZuakVwcDR4WTRHSnRKWGJHVWlRS1Q4TmtHVlk1ZmxnZmNjVjhxVVhsMEFT?=
 =?utf-8?B?TkxtVlpGWE1yOXBNSTc2dFUyRTdab3VRbHp5R2NWMnZKM3Bud05pRGRZZmgv?=
 =?utf-8?B?WGpTSEc1OFhoVVFmSWZyalpkRTVrYTFSUnUxenpDSU85T2toZkIwREE4MUdE?=
 =?utf-8?B?SmRDYmZSam5oOThOTWNWRU5Jb2E3aWFoUHRUUEZRNVErRklQazhEeFVkRHpJ?=
 =?utf-8?B?aEF0cW1PRFdXL1VQUnRLYlFoNG4ramNyYjEzc2IzODNNRnFVNzQrb1RLbita?=
 =?utf-8?B?TmFTdS9SN0VCWDZ0WUZVOVFsaVd3TFVZS2EvTEhpRHBEb2pVN1dONVVXVHVz?=
 =?utf-8?B?cEZ0d3grUDB6L01CT1hxR1Z5bnFobzVPV09QUExML2w2QTVHaVJ0L3VjSjRG?=
 =?utf-8?B?QTVxcEF2OEUyalVJZmFpT1RTenJuY3hyZzFMd09VQzYyVXVFaWVCUmtWRlAz?=
 =?utf-8?B?TVB2ckRKai9td0hNbzBFNnNZblNFOCtUNHAyVi9lcnB0OVVyb0dkVzJMMGlJ?=
 =?utf-8?B?RmxHYTRpRTdtdmpjSXh2ekJlVDdsc2Z3ckIvdTVrZ1QzbkVSR2o2Q0VSYnNu?=
 =?utf-8?B?Y1lXRFR3ajJybEhSclZiVkpoTlZwWmdhQnpkREdqaGZjeVJ5STlkR3R1a3BM?=
 =?utf-8?Q?OuPePMYWS/AVkO//CmKqKZfoU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6562e2e-33ef-43c6-9eea-08daf797a024
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 07:59:42.7109
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n+NBzKfAHN4052pgQgOpVs/doVYQdWFgTSmzQY/3nGCyCaB8+ElHr3MPl6/7S0ITb379xraVW9wycdmyoyEFvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8147
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13/01/23 22:41, Pierre-Louis Bossart wrote:
>>>> +		if (is_dmic_dev && is_sdw_dev) {
>>>> +			switch (acp_data->sdw_master_count) {
>>>> +			case 1:
>>>> +				acp_data->pdev_mask = ACP63_SDW_PDM_DEV_MASK;
>>>> +				acp_data->pdev_count = ACP63_SDW0_PDM_MODE_DEVS;
>>>> +				break;
>>>> +			case 2:
>>>> +				acp_data->pdev_mask = ACP63_SDW_PDM_DEV_MASK;
>>>> +				acp_data->pdev_count = ACP63_SDW0_SDW1_PDM_MODE_DEVS;
>>>> +				break;
>>> so the cover letter is indeed wrong and confuses two controllers for two
>>> managers.
>> ACP IP has two independent manager instances driven by separate controller
>> each which are connected in different power domains.
>>
>> we should create two separate ACPI companion devices for separate
>> manager instance.  Currently we have limitations with BIOS.
>> we are going with single ACPI companion device.
>> We will update the changes later.
> Humm, this is tricky. The BIOS interface isn't something that can be
> changed at will on the kernel side, you'd have to maintain two solutions
> with a means to detect which one to use.
>
> Or is this is a temporary issue on development devices, then that part
> should probably not be upstreamed.
It's a temporary issue on development devices.
We had discussion with Windows dev team and BIOS team.
They have agreed to modify ACPI companion device logic.
We will update the two companion devices logic for two manager
instances in V2 version.