Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7837afc3-e5f0-646b-ccae-b196d4e0b522@nxp.com>
Date:   Mon, 16 Jan 2023 11:10:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] ASoC: fsl_sai: initialize is_dsp_mode flag
To:     Shengjiu Wang <shengjiu.wang@nxp.com>, nicoleotsuka@gmail.com,
        Xiubo.Lee@gmail.com, festevam@gmail.com, shengjiu.wang@gmail.com,
        lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, alsa-devel@alsa-project.org
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <1673852874-32200-1-git-send-email-shengjiu.wang@nxp.com>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <1673852874-32200-1-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UCtMNlM2cnZhTkNhc3VTWlZwOVZoZzVkVXJ3UDFnM2NaQkNjV1ZSOU1mRXdx?=
 =?utf-8?B?eDM0QnhsbEFsVWlaRXN3cWhheDA4Qm40NzVIaU5KZUFwTGVWZHVKNTBGMjRv?=
 =?utf-8?B?WTdXN0RnWC9aSGtlZDVGWWxMUjFuRXZmMlRId014Z0M3cGwzVkhTS1B2UXBj?=
 =?utf-8?B?Um9EdWZSVlhGVnhPYkpLWnIyNWdwSG1oUStNbHpQdlJHY0VHSWN2UzhRNHla?=
 =?utf-8?B?M3k3c3p5MU1TYnFSOEdvd1lqdVpyZzZEam82T2toenVWT05xY1FHU0pGTXNp?=
 =?utf-8?B?Q1BsWkh5NTc1S0ZpTUxvMk02ZUV5eFNtdUlic0RhQjhDQUg0Z3czR25XUlBL?=
 =?utf-8?B?QXZPQS92aVJrSGo4OHhWMEh1ZXlDdUEvN0dxUUIwRkd3QmJ2VFU4c3h4cGpx?=
 =?utf-8?B?SnJLcTdHTnlqZVNlVXVlNnlpRUptZGFKNjdvVzEwMkdlbXpsRHdLcnBQdDJX?=
 =?utf-8?B?SlNEWjgyNUFBNWdQYUFkREhvZ1NsR0sxMDlnN28yOUlRTjRvUVNDWStza3lu?=
 =?utf-8?B?SGZyWTNPMGlRVUtyQ2RVRU5sVU9NSkdtWnRPZTg0TndzYmd4OXp5YjRxM2l0?=
 =?utf-8?B?aGsrKzlERzFUTGRUODNRam9tbzdQMWpEaWlEQnNFSFhpM29PRlNSZmJRTEJr?=
 =?utf-8?B?K29PMTB1VFFmeUZDN1lTNm00QUd1N3RZOUpKQm9aRGdQUDdjNHczNVluMjRl?=
 =?utf-8?B?WEtSbUMrSGNCb1d0eU4veXh0bDlnWkNKelgzNS9mNDhHUTFPWkVxR3FjTUlQ?=
 =?utf-8?B?Y2pycHY2U3R3UlBvOUlndTllbkxCWGt5M3N2dWt6cEVCalEzZnNSQW1WRDY2?=
 =?utf-8?B?b1J6RXN5UmJUeC9OaVlOWVVYQmx0bFgyVkpWR3hubW5RbnVoSkJFOW9zTFo1?=
 =?utf-8?B?bU11Ym1COHhaTmxDOHBMVlpEOGZwaVllbHcya0tNSDhLN0lCb0NjUFJra09m?=
 =?utf-8?B?WlFCTXJhQ3U2T21ZV2IvaFUxcWNTbzd3Nk80VkNIQ2FrOFJiSlNvWFR3Undz?=
 =?utf-8?B?bzFlZmRUQ3JoNENsRlFnb1JGQ3VyN2ZjSko5Wi9XS09NSTdNa2o0c2owREN6?=
 =?utf-8?B?SktkQXVjVm42bnVYeXFDL0Vna3dmQnIxVUNSL1I1ejJ3WXFPWkEycEtiZ3k2?=
 =?utf-8?B?MDNaQW1hZFhscis5QVlvUUF3NERsMGttVFoxZFdXVlpjSFRieG43ODUxQ1Rl?=
 =?utf-8?B?cDBGSEZaNjVUVllab2dBSDJlVDN0Y0tnQ1ZKYzJoL2NLYnZDRkp2a3RDRmxx?=
 =?utf-8?B?czBHMktPU2xmdzVYazBCdjN1ZENVWDd2bUFkMTRybVNpN3F5VFlBS1J0WG8v?=
 =?utf-8?B?TVpuL2F5TW13NzQ3MjFObWZFVWhxWmJKZUZmZ2hzNzBoUm5SaGp5RHRNZnUr?=
 =?utf-8?B?ckhyRzIrZG9DN0tXcThVbGlOa0QwdHpTbEdQWms1c0ZFdlNOMGgwbzBCSGs1?=
 =?utf-8?B?Q1J1SXdkdmlkZnZXdmZlRkZJeGx5d2xHQVRMTkdTRlZwd0ZQUk9Va1lKYzln?=
 =?utf-8?B?ZjdVTUsyK29tTXh1NWh1Z3pLNHc2RVJycWdYSjU4OHl4SjA2czM2c1dHbnBV?=
 =?utf-8?B?SzhEcjBncngyKzNUYmpLSjB0REJnNW9LYzR2VzYrZ0xpSFAraXpRcFVMUk5h?=
 =?utf-8?B?aEpSNnRGVXZjRTRxL0xhQW03Sm1oRTh0UmhJa2FBYkZ3Uyt6V3RmNW1hNkd1?=
 =?utf-8?B?SEV0UVhOcldoeVV2dnRtS3pHR3dtVHFmR1d3WWVUQWJnMUx6dE9NKzR1U1BO?=
 =?utf-8?B?c3R5SHRGaW1wLzBlSGJzdVBpcHFHQUVGK1c3ME1BY2crYkREZnNBNEZlaFhQ?=
 =?utf-8?B?MGlxbTNXQ1FOaE1Hcko3aHQ1Nm9MUnJrYVFhVFY3Uk9HeVkwLy9xcDcxWWJu?=
 =?utf-8?B?bEdDMzBjem9xTHpLZkdXMHoxSGMwUm1qOUt1WkdvUzl1dmFrK0VUcitaYmZQ?=
 =?utf-8?B?TjVocFJBNXhKclBJY0pwSVVhOVhyYXNZMlk4K2RHVmc4d29yYzB6V3Y3TlJN?=
 =?utf-8?B?N1VQMjVGalV4V1d3dHl2Y0ZtcDdDYVN3ZGpsa2JKa0EvdzRLcFV4VXFVSzEz?=
 =?utf-8?B?cjZHQWN5NEUyV012WGx4UFZjQTNSM3p3TWZIS0lSZFZkU2xNeUNPMWMyS0hG?=
 =?utf-8?B?YVB1MFV5VFNLU2dDOVZOZ0dYWmNucTB2TytSUEZSVG5UdnJmVVVQUTNlb3dH?=
 =?utf-8?B?T2c9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 328e8c4a-c00b-4336-7610-08daf7a18037
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9628.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 09:10:24.1851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gMfGbaT5bawtbkXbzDluUSxcqJzKVguVKZBWzBH74JHaoR1x6gQtQ7dV0ZECQ1DJbhxYRmrrwKjFVGduC9xZ4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8613
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/16/2023 9:07 AM, Shengjiu Wang wrote:
> Initialize is_dsp_mode flag in the beginning of function
> fsl_sai_set_dai_fmt_tr().
>
> When the DAIFMT is DAIFMT_DSP_B the first time, is_dsp_mode is
> true, then the second time DAIFMT is DAIFMT_I2S, is_dsp_mode
> still true, which is a wrong state. So need to initialize
> is_dsp_mode flag every time.
>
> Fixes: a3f7dcc9cc03 ("ASoC: fsl-sai: Add SND_SOC_DAIFMT_DSP_A/B support.")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

Thanks,

Iulia

> ---
>   sound/soc/fsl/fsl_sai.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 1c9be8a5dcb1..355ef29af48c 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -281,6 +281,7 @@ static int fsl_sai_set_dai_fmt_tr(struct snd_soc_dai *cpu_dai,
>   		val_cr4 |= FSL_SAI_CR4_MF;
>   
>   	sai->is_pdm_mode = false;
> +	sai->is_dsp_mode = false;
>   	/* DAI mode */
>   	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
>   	case SND_SOC_DAIFMT_I2S: