Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0ab02869-2e3a-a846-18d4-217c5c663975@arm.com>
Date:   Mon, 16 Jan 2023 10:13:40 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH v3 0/3] coresight: cti: Add PM runtime call in
 enable_store
To:     James Clark <james.clark@arm.com>, coresight@lists.linaro.org,
        quic_jinlmao@quicinc.com, mike.leach@linaro.org
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230110110736.2709917-1-james.clark@arm.com>
From:   Suzuki K Poulose <suzuki.poulose@arm.com>
In-Reply-To: <20230110110736.2709917-1-james.clark@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/01/2023 11:07, James Clark wrote:
> Changes since v2:
> 
>    * Reword first commit message and add fixes tag
>    * Pickup Jinlong's tested-by tags
> 
> ----
> 
> This should be a slight improvement on Jinlong's previous version.
> Now it's not possible to trigger the error message from
> pm_runtime_put() by calling disable twice.
> 
> It's also similar to the original pre-breaking change version where
> pm_runtime_put() was only called if the device was actually disabled,
> but with one difference: Previously pm_runtime_put() was only called
> once for the last disable call, but because of the reference counting
> in pm_runtime, it should have been called once for each enable call.
> This meant that the clock would have never been disabled if there were
> ever multiple enable calls. This is now fixed.
> 
> The third commit is a refactor and doesn't need to be backported. I
> removed one of the atomic types because it didn't appear to be
> required. Maybe it was added for a reason which I'm not aware of, if
> so it should be pretty easy to drop that change.
> 
> James Clark (2):
>    coresight: cti: Prevent negative values of enable count
>    coresight: cti: Remove atomic type from enable_req_count
> 
> Mao Jinlong (1):
>    coresight: cti: Add PM runtime call in enable_store
> 
>   .../hwtracing/coresight/coresight-cti-core.c  | 23 ++++++++++++-------
>   .../hwtracing/coresight/coresight-cti-sysfs.c | 15 +++++++++---
>   drivers/hwtracing/coresight/coresight-cti.h   |  2 +-
>   3 files changed, 28 insertions(+), 12 deletions(-)
> 
> 
> base-commit: 88603b6dc419445847923fcb7fe5080067a30f98

Queued to coresight next


https://git.kernel.org/coresight/c/479043b77833

Suzuki