Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 Jan 2023 12:12:07 +0100
From:   Stefano Garzarella <sgarzare@redhat.com>
To:     Bobby Eshleman <bobby.eshleman@bytedance.com>
Cc:     Bobby Eshleman <bobbyeshleman@gmail.com>,
        Cong Wang <cong.wang@bytedance.com>,
        Arseniy Krasnov <AVKrasnov@sberdevices.ru>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v10] virtio/vsock: replace virtio_vsock_pkt with
 sk_buff
Message-ID: <20230116111207.yxlwh4jlejtn4ple@sgarzare-redhat>
References: <20230113222137.2490173-1-bobby.eshleman@bytedance.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20230113222137.2490173-1-bobby.eshleman@bytedance.com>
Precedence: bulk

On Fri, Jan 13, 2023 at 10:21:37PM +0000, Bobby Eshleman wrote:
>This commit changes virtio/vsock to use sk_buff instead of
>virtio_vsock_pkt. Beyond better conforming to other net code, using
>sk_buff allows vsock to use sk_buff-dependent features in the future
>(such as sockmap) and improves throughput.
>
>This patch introduces the following performance changes:
>
>Tool: Uperf
>Env: Phys Host + L1 Guest
>Payload: 64k
>Threads: 16
>Test Runs: 10
>Type: SOCK_STREAM
>Before: commit b7bfaa761d760 ("Linux 6.2-rc3")
>
>Before
>------
>g2h: 16.77Gb/s
>h2g: 10.56Gb/s
>
>After
>-----
>g2h: 21.04Gb/s
>h2g: 10.76Gb/s
>
>Signed-off-by: Bobby Eshleman <bobby.eshleman@bytedance.com>
>
>---
>Changes in v10:
>- vhost/vsock: use virtio_vsock_skb_dequeue()
>- vhost/vsock: remove extra iov_length() call
>- vhost/vsock: also consider hdr when evaluating that incoming size is
>  valid
>- new uperf data

Tests seem fine!

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>