Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <715cfcd3-47c3-f7f4-7dd1-4d76c6b147f8@huawei.com>
Date:   Mon, 16 Jan 2023 19:37:37 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH -next 7/7] mm: swap: remove unneeded
 cgroup_throttle_swaprate()
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
CC:     <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20230112083006.163393-1-wangkefeng.wang@huawei.com>
 <20230112083006.163393-8-wangkefeng.wang@huawei.com>
 <Y8F9rHVHu7XsBg49@casper.infradead.org>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <Y8F9rHVHu7XsBg49@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Matthew,

On 2023/1/13 23:50, Matthew Wilcox wrote:
> On Thu, Jan 12, 2023 at 04:30:06PM +0800, Kefeng Wang wrote:
>> All the callers of cgroup_throttle_swaprate() are converted to
>> folio_throttle_swaprate(), so make __cgroup_throttle_swaprate()
>> to take a folio, and drop unused cgroup_throttle_swaprate().
> 
> Shouldn't __cgroup_throttle_swaprate() then be called
> __folio_throttle_swaprate()?

Sure.

> 
>> +extern void __cgroup_throttle_swaprate(struct folio *folio, gfp_t gfp_mask);
> 
> Also you can drop the 'extern'.

Ok.

> 
>> +static inline void folio_throttle_swaprate(struct folio *folio, gfp_t gfp_mask)
> 
> And it's not a gfp mask.  It's gfp_flags (we have this mistake all
> through the mm).  Or you can just call it 'gfp'.
> 
> 

Thanks for your kindly review and advise, will update.