Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 Jan 2023 13:11:02 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jerome Brunet <jbrunet@baylibre.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        linux-amlogic@lists.infradead.org,
        Kevin Hilman <khilman@baylibre.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Da Xue <da@lessconfused.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: mdio: add amlogic gxl mdio mux support
Message-ID: <Y8U+1ta6bmt86htm@corigine.com>
References: <20230116091637.272923-1-jbrunet@baylibre.com>
 <20230116091637.272923-3-jbrunet@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230116091637.272923-3-jbrunet@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/7ukMpQa1kdgmXwOZzhilXFYbbn1D6B8qDYTX+Qhj68TcznBWvrtivCAOGIs?=
 =?us-ascii?Q?uPA+fT+xrXSg2vr3zMdzB4HYVG3FyysCgKj14YN9Cz4uTrkO97OJ5X+26M4v?=
 =?us-ascii?Q?2jKxrv1K3OH3oDuTCgm050xG0YeTEbWSWH8U7m9Kjk5g+1sQNeLhPMerF2lv?=
 =?us-ascii?Q?1ThxYx36Js72eeI4rzngkIfJRQ/hw+mpg7gkMtQjdiC9uByx8mJortXymalP?=
 =?us-ascii?Q?8vpobK9XIDk34ibAciC6LwvGbVKkyoHxUCc6VslAzBYKdEmhyRQSFjvI82s5?=
 =?us-ascii?Q?oyAxs7gw0r4oStuksn1GixvEyv6iPF2Zvi2VcBjVShUJ2t5bi/VIaNXYKIM1?=
 =?us-ascii?Q?IK3zRSeCEDumnuvTiBX3kh4LEHy0RF28DFVFH7MAIri5Z5PJ2AbfC2A4V7f4?=
 =?us-ascii?Q?Ig7F/Xa/7JgeLtmh4rJ5bXyA+fDsvrtlEfGX/90i0kHM69o27uONAuLPBk7L?=
 =?us-ascii?Q?kcuse7WyiuNAZKteDYASxUgoFD/x9cb3rHnExrwO8FWIH7VxZp39zWZw2q/0?=
 =?us-ascii?Q?3lsL9KVWyL1uKeOdyVqcYRppTAEkL+N+ZCUjkyvJdtoFiZHdsITW+Usg3Lo2?=
 =?us-ascii?Q?/YGwpK/qB/FDDzJxw7k1wGR75bQanhNjBi6/+8oxPZ/nEne/rBIiSOHdkYCY?=
 =?us-ascii?Q?DSbZkZt/W37lxCP8yfC2oeMQEo0y/yHWp8FC44BWyQABHvvNetFLcit/2ZHo?=
 =?us-ascii?Q?B/xgAJ6E6oDMrME+TKWFhBg9NEK6AxPeJgXTOv0bcNHzGQyr/d+6nw06KRfZ?=
 =?us-ascii?Q?AJY8y/vcFQssov6oxFp10OyjywGsSIkLCc6QNQbX5AcQyx1W94TWMZNmTMad?=
 =?us-ascii?Q?4C3giq/DyXRzw04LHHwHEKCMGcKtw+9AHZ4qSWWJyIXayuQYcFYCMU8/68qj?=
 =?us-ascii?Q?y6F7owKd358GsGbqb29Tc2mvjgcL1iVyqXUJ27b//MFilrcBXGOCcuTC9oHr?=
 =?us-ascii?Q?Yp7mRO3NWvTsdolJemLXp81n+++WRz1VDlWMDkkNe189hhYni1JrdsBOj2Kj?=
 =?us-ascii?Q?RdTDbz5yoWHG3Lmg0GeA0PkQMAREecyDSBe+LKdfVgJqDeHFNAF+9a8pogxZ?=
 =?us-ascii?Q?CFljJwExdJTkepnhaxYJtg0gVArtm9/69bIzobbHnhX8zZQVxQW2KFv6pvy3?=
 =?us-ascii?Q?/UDba8QADA5LDahSxP95p8wd99CLnbwJ+ihFokHFEJYvHvrAxLi5dTfmvjvS?=
 =?us-ascii?Q?X+BMmU6KSKwfieRKXtDLkh200DQclLMGuH6S9tNlS+bxH7qA6+CWDWUGYdhE?=
 =?us-ascii?Q?lw7Z/MkM2sPmHEV8NC8b0DKRMyzvSyjk8wT1puQbIws3gh3BfR7X/iBOPvpp?=
 =?us-ascii?Q?VjTYByg6+AZaYnzaJc5/GuiFXMK0XSb8QHlcb0rl+qIW8XOUMNH/3o7xR9O6?=
 =?us-ascii?Q?x+ZsOajyt7PeFNPwzbROmZdmepy1UtYWiTWZ7Du7WekXnsH4G8JMIMmPst2l?=
 =?us-ascii?Q?zJOl4V7Z43jKnA2ZPf6l3+xpGQ2SAjLZ3lNRrsvHYF3Qgo/OQNBXeyL2vjbY?=
 =?us-ascii?Q?8yZ3+JKZnixpZeVWxu0NMMLlclxUQ2hPvcU+QVwPbwgC5KLXIKztGNB5W2VD?=
 =?us-ascii?Q?XvsZhnaIQXDcJGDv2xQxLEaNAkgNeb9OnnmobnT+V/rt8yipHQIgXVRvVj+r?=
 =?us-ascii?Q?XjSfT7Ktc1Oqa/ozusll6IuUORGbEAiJXDN4psH06g24oNSQYTsk1NtV0dSc?=
 =?us-ascii?Q?jt6QhA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ed052fd-3587-44bd-677b-08daf7babfc5
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 12:11:08.4708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c+20h9rANB9rvDQjw6apKfzudvxUX9stvYaFTSn6Y1b4vFoZSM5BBjg6qKJiaf2coOmYDZrl349BvJIqZpeUt6AKPn4BbsysDcb11A+XCPE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR13MB5230
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 16, 2023 at 10:16:36AM +0100, Jerome Brunet wrote:
> Add support for the mdio mux and internal phy glue of the GXL SoC
> family
> 
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  drivers/net/mdio/Kconfig              |  11 ++
>  drivers/net/mdio/Makefile             |   1 +
>  drivers/net/mdio/mdio-mux-meson-gxl.c | 160 ++++++++++++++++++++++++++
>  3 files changed, 172 insertions(+)
>  create mode 100644 drivers/net/mdio/mdio-mux-meson-gxl.c

Hi Jerome,

please run this patch through checkpatch.

...

> diff --git a/drivers/net/mdio/mdio-mux-meson-gxl.c b/drivers/net/mdio/mdio-mux-meson-gxl.c
> new file mode 100644
> index 000000000000..205095d845ea
> --- /dev/null
> +++ b/drivers/net/mdio/mdio-mux-meson-gxl.c

...

> +static int gxl_enable_internal_mdio(struct gxl_mdio_mux *priv)
> +{

nit: I think void would be a more appropriate return type for this
     function. Likewise gxl_enable_external_mdio()

...

> +static int gxl_mdio_mux_probe(struct platform_device *pdev){

nit: '{' should be at the beginning of a new line

> +	struct device *dev = &pdev->dev;
> +	struct clk *rclk;
> +	struct gxl_mdio_mux *priv;

nit: reverse xmas tree for local variable declarations.

> +	int ret;
> +
> +	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> +	if (!priv)
> +		return -ENOMEM;

nit: may be it is nicer to use dev_err_probe() here for consistency.

> +	platform_set_drvdata(pdev, priv);
> +
> +	priv->regs = devm_platform_ioremap_resource(pdev, 0);
> +	if (IS_ERR(priv->regs))
> +		return PTR_ERR(priv->regs);

And here.

...