Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f5d5d474-35b7-3dd3-6d06-be6f8f3e1103@huawei.com>
Date:   Mon, 16 Jan 2023 19:31:43 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH -next 3/7] mm: memory: convert do_cow_fault to use folios
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
CC:     <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20230112083006.163393-1-wangkefeng.wang@huawei.com>
 <20230112083006.163393-4-wangkefeng.wang@huawei.com>
 <Y8F6ozvZPPlewmC/@casper.infradead.org>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <Y8F6ozvZPPlewmC/@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/1/13 23:37, Matthew Wilcox wrote:
> On Thu, Jan 12, 2023 at 04:30:02PM +0800, Kefeng Wang wrote:
>> -	vmf->cow_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->address);
>> -	if (!vmf->cow_page)
>> +	cow_folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, vma, vmf->address,
>> +				    false);
>> +	if (!cow_folio)
> 
> I have a patch I've been sitting on that converts vmf->cow_page to be
> a folio.  I think this series is well and truly wrecked at this point,
> so let me go back and dig it out; see if it still makes sense.
> 

For now, as vmf->page and vmf->cow_page used in do_cow_page(), it only 
supports cow on a page, and after converting, the folio still is 0 order,

> I'm a bit unsure about it because maybe we want to allocate
> high(ish)-order folios on COW fault, and if we do, then maybe we want
> to align them in some way with the virtual addresses, or the other
> folios in the VMA.  And then we might want to indicate the precise
> page for this page fault rather than have this page fault be the
> start of a multi-order folio.
> 
This means that if high(ish)-order folios/multi-order folio on cow, it
needs additional jobs and precise page for this pagefault, but for 
order-0, the converting is right but could break/mislead future logical? 
not very clear about this part, but let's wait for your patches.