Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 Jan 2023 14:17:25 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     "Somisetty, Pranavi" <pranavi.somisetty@amd.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Kubecek <mkubecek@suse.cz>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Rui Sousa <rui.sousa@nxp.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        "Katakam, Harini" <harini.katakam@amd.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v2 net-next 02/12] net: ethtool: add support for MAC
 Merge layer
Message-ID: <20230116121725.wsf3hfv3biyozno4@skbuf>
References: <20230111161706.1465242-1-vladimir.oltean@nxp.com>
 <20230111161706.1465242-3-vladimir.oltean@nxp.com>
 <BN8PR12MB28529854BAE0543212FF8E13F7C19@BN8PR12MB2852.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN8PR12MB28529854BAE0543212FF8E13F7C19@BN8PR12MB2852.namprd12.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bU84YpP2HKKgC2gXa3Cu2fUZ+0UsYJ+oBCCcro0fiYql4QrIR8HVGKd0wwvm?=
 =?us-ascii?Q?zsWLi5xZ9rSuq1nPXIDTADLUqxxVlMeZdFc6PNDp/A7NWsZ49G4n2AeFIagT?=
 =?us-ascii?Q?TwQxeamE6WmC/4R2eI43Xw7DsDPblBpxPdoLSLqyo+I5tPkb8tEEsw3ejxdG?=
 =?us-ascii?Q?Y8uAzD+xYE4DpEajWRBMGyEoC+Rc3G7xRQqVRXvDzIusW/OiuM3IMUnRhIZw?=
 =?us-ascii?Q?VpZtRs8x9Czxye8v1pUMrb3Y9xhQ6roixtwyIoW9J3bUas3JLRAtDqFnlCAW?=
 =?us-ascii?Q?8y6qBmIZ+S/LRbXHFWzJqranAxQTFIhuOpd5jt/zXZHlb44F0ausabX6ZttW?=
 =?us-ascii?Q?4hCQAeQJaU0EmIKmR251JINNdpfJ6v7Z1YLNaCdtTpe2jytL9SLQnQEI+MVl?=
 =?us-ascii?Q?6p+LFfBYdnwemo/RwP9Vgqm/3P2dcK0zw9w4YMUNNYA4OE7lCGaHHO+Cc7BF?=
 =?us-ascii?Q?KztDepjFoq9/7x3zIQlkh8KeLZ0Iol5bjHkmzi29fDF0uD9IjHIl3D1IV9/0?=
 =?us-ascii?Q?1IvRT4zvtPBrQU0HBRqwIl6DZ1ORxpfT48DInbters/gFct2nAB5uWKT3MhV?=
 =?us-ascii?Q?k1aoQIUn0f86DaepCPuIJjMdg0XCIphWbTgkOzcsr29/n1Si/6PoN1nwx3Fa?=
 =?us-ascii?Q?itkq7XF4eam3VEdgtFI8nBUf+Nk0TJ8WwPv4fcDYkGHi3nw6doUd64ioASsZ?=
 =?us-ascii?Q?Ur/1wxapWTg7/isXPySVPKq/rk8YH05rDF1oW2VVlI3vXGRRyoSkdfZ86NUX?=
 =?us-ascii?Q?d2Vs3dn4vAQfvyH7MKDZsE0ZodNfVRKcsL2MTaVFbwQ/U4jTdySdkEw6Y9m7?=
 =?us-ascii?Q?f8pJiYqyzVvfgp8irHriYXAdfdJBDkhDsr+DfPmZ72ma4CwPm2ZD6ND9YDLv?=
 =?us-ascii?Q?fto3lSexeu0RueoOy7pSq70K6iyNo/4vOMegKRkle3asm8SrWW0Rfd3GeaqX?=
 =?us-ascii?Q?xgk50SyjAZw5V5XRbfyWQO2ZWEzyVSCOCnDvbF2l3hp1gcT2CVd8+zb61xeN?=
 =?us-ascii?Q?aNe1gV5/o+hp3RmFDiqE8E9QYBJezrH1JBni6WsFmhBK6mAUF5E9p4jWheRc?=
 =?us-ascii?Q?9ZXJ3034MQxZC4VetJ1CeWZ37+sdjM/mY+2wycXbvlzZmQg8CWT+cdZqV0VW?=
 =?us-ascii?Q?mqp9sjrGFGL9nSnpJeMR3qZnD1bmJf+Cpl7MRaIl2lt8zX2hss12YUAUFkY/?=
 =?us-ascii?Q?/EZM/m/clsQSEMOJX3jHM+j4REGT+/YtAD2exI+6gNzzmSplPIo9Pcz1+mAq?=
 =?us-ascii?Q?BiDouGfkwD1yJSC9vKXAU+9UozDyYrjyVo2I7tnSo1jNCA1Aks7SKWR9v2cN?=
 =?us-ascii?Q?1f9ir9873efMuJo3h/LM6uMgYHyGI1f/vB0KK++QE1wpHHySf5vBvviLlLfj?=
 =?us-ascii?Q?ywEyYPzHkkRct5LXRpXl2g8z9Y9X3PHwfRphzrgHRiM7t6iUr4QBuHN0PkTo?=
 =?us-ascii?Q?AVg3H03rjkpPe+y7t44czAE6M0QYrUaKDspyo65LkfpnWxaGOnUrtYD26FnR?=
 =?us-ascii?Q?8qvODEeCSB19BK26NcUeSeG+qJ/16vv+JRGFb2SVOc3h39lirFu4N+cgTkPP?=
 =?us-ascii?Q?w+qud5QfZLYgQ5yq696BADz6OZ8fn4mlD9Jy6EtefRSnQZHwkWQhy++u/qJS?=
 =?us-ascii?Q?EA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa8620d0-d859-4e2f-e391-08daf7bba2eb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 12:17:29.3784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tgSoXCpU4cZ5DkTvrd+JUFmxOTo3DYXIymht4ykTw++fGMiys94jl+KwuwnVRugZC+DE7E8U8glDkfFNnnQYdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9313
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 16, 2023 at 09:02:55AM +0000, Somisetty, Pranavi wrote:
> Does it make sense to have two separate functions, one to
> enable/disable pmac and tx preemption status and configure additional
> fragment size (both parameters can be configured after negotiating
> with the link partner), and another to modify the verification related
> parameters, i.e, enable/disable verification and verify time value?
> 
> For example, if the user wants to change the verify time value, Is
> there a way to change it without disturbing the value of the
> additional fragment size that has been set through LLDP after
> negotiating with the link partner?

Could you please clarify what you mean by "disturbing"? The handler for
the ETHTOOL_MSG_MM_SET message first calls get_mm(struct ethtool_mm_state),
then mm_state_to_cfg(struct ethtool_mm_state, struct ethtool_mm_cfg),
then set_mm(struct ethtool_mm_cfg). In other words, a SET ethtool
command translates into a read-modify-write in the kernel. If user space
did not request the modification of the additional fragment size, just
the verify time, then the set_mm() call will contain the old additional
fragment size and the new verify time.