Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp3195646rwb; Mon, 16 Jan 2023 05:07:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXuddiRJB53svKNVens5Q2g5uKoP4MSCiOYoJsXDW/DtisPVBlOrMVwZGtcSdAjBDQaeUs04 X-Received: by 2002:a17:906:280d:b0:7c1:65f5:7b95 with SMTP id r13-20020a170906280d00b007c165f57b95mr82527974ejc.26.1673874474537; Mon, 16 Jan 2023 05:07:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673874474; cv=none; d=google.com; s=arc-20160816; b=jgDgHpl1h5VfPCaltJHVndhoza6JPqLN01G2sEEAVddfkEin6yh53GZZTuJ/B5qw0h Vs5AKGmXxLQDATEsIu6miNGhgdd1VPerpPdqTvk0JRHO921UwnivHJdvO+NxONoMvOC/ M5smtHBF6BlkM3WDgAMwbbspqWVoFeY8ZcOjTGTpFpImp9cq6evKz+OgRo3hsxwhzQW6 cMAZItacdmGNmLzUeGXKipT24nISO9iDCXt6we40bMhetdWtDnxcpoxggEBvcWPQzdvl vnOQTA7mpUAb2O1+ysd6WOCUCIHQ8Jj8niVuBUXy0vX/xJJQCQzp+JoLqYu9ibovRuRL DtQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=B5/iVeVBdVXrocHtZ180TXyoEE8wL7WPR4BW9U+jFhM=; b=q6fAwV8q/642v+7rNkem15eVsWneyezgoWhFkfezuAszpOTuZA1C7irItK5Vnq/mQP jPSOJHyLWxDfmOBzOXiwLqHxDFekgKHraW+j8EciTwSiPxIuSBf0NVCJLZvdqKFPCGme dAz0rG8yk9MROscG8pAcgjz/mI4dgxPgyQorGwcwSVzJ7BboASfJ9nwO83fgS3fx51+P qw082TuPLwbxDUBPPhUmwfG827v/ijEGXxzaVrWW9lIOpp8eRE9l9rAyOLp8fXsM6RDl kQCPsbIXRQtw08nr8199dgVPHMCF2rZfRCNfWkdTU/r/5JsEvV3RRBKJNNZCfdhGYfY3 rT4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Beu3qnju; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gn28-20020a1709070d1c00b0086689c8fae9si52229ejc.829.2023.01.16.05.07.42; Mon, 16 Jan 2023 05:07:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Beu3qnju; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbjAPMjR (ORCPT + 51 others); Mon, 16 Jan 2023 07:39:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230286AbjAPMjP (ORCPT ); Mon, 16 Jan 2023 07:39:15 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D68F51BAC7; Mon, 16 Jan 2023 04:39:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673872754; x=1705408754; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=NsxSQXRA1+OPD1T485eedwEPZNoRWfbPHxonr1F3p8k=; b=Beu3qnju9uLthjzEgi0/9LCMeWckAWx64yieew4T3rV/mvTpORs51y5Y a+AkyVi1eMNmjSYTvCqeSbWpevRMpUvNY4ulx/vCc0+uBaljoXXEUygV1 r3sp4PM7kX9+YZZq/1fYfwNnjYKXMWsXKxClWYxe0XYE4Ecy8kfx4y6OG JDdAzPMXDSab/X5GUgHwsd3fgAyDrOy7KDKzu7dxg/ZjMgLYeBQmbmdrv zMBUJNrU/IVwdw0KcanqRKV749rgbuWMchvszNzbVeCpypVwuiPzpWHBw 0zb1Xia41B1s+MVG5AUHRyAMracGYNIlMD+oUCrYB/Rrp/eecba+jUefl w==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="325717846" X-IronPort-AV: E=Sophos;i="5.97,221,1669104000"; d="scan'208";a="325717846" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 04:38:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="766869030" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="766869030" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 16 Jan 2023 04:38:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pHOlD-00A4JX-0L; Mon, 16 Jan 2023 14:38:47 +0200 Date: Mon, 16 Jan 2023 14:38:46 +0200 From: Andy Shevchenko To: Jan =?utf-8?B?RMSFYnJvxZs=?= Cc: Borislav Petkov , "Limonciello, Mario" , Borislav Petkov , Hans de Goede , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com, wsa@kernel.org, rrangel@chromium.org, upstream@semihalf.com, Muralidhara M K , Naveen Krishna Chatradhi , Yazen Ghannam Subject: Re: [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access Message-ID: References: <33d5cc27-474b-fdec-a6b0-84ac16f7d386@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2023 at 11:19:00AM +0100, Jan Dąbroś wrote: > Hi Borislav, > > > Make init_amd_nbs() arch_initcall_sync() so that it executes after PCI init. > > I described earlier in this thread why such option is not working - > let me quote myself: > > It's not enough for running init_amd_nbs() to have only > pci_arch_init() done. We need the pci bus to be created and registered > with all devices found on the bus. We are traversing through them and > trying to find northbridge VID/DID. Due to the above, we need to run > init_amd_nbs() only after acpi_scan_init() that is invoked from > acpi_init() which is registered as subsys_initcall. That's why the > trick with switching init_amd_nbs() to arch_initcall_sync will not > work. > > We have a kind of chicken-and-egg problem here. Or is there something I missed? > > I wonder if there is upstreamable option to control order of the > drivers' init by forcing link order? But what exactly do you need from North Bridge? Is it only its existence or do you need to have fully instantiated PCI device (if so, why?)? -- With Best Regards, Andy Shevchenko