Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20e51ef8-15ae-e0cc-9a90-2694cbbcee7c@foss.st.com>
Date:   Mon, 16 Jan 2023 12:59:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] ARM: dts: Fix User button on stm32mp135f-dk
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Fabien Dessenne <fabien.dessenne@foss.st.com>
CC:     <devicetree@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20230111100725.463136-1-amelie.delaunay@foss.st.com>
 <98d2af06-8ef3-bb6b-1f29-4e33c1c748d6@linaro.org>
Content-Language: en-US
From:   Amelie Delaunay <amelie.delaunay@foss.st.com>
In-Reply-To: <98d2af06-8ef3-bb6b-1f29-4e33c1c748d6@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/11/23 11:38, Krzysztof Kozlowski wrote:
> On 11/01/2023 11:07, Amelie Delaunay wrote:
>> This patch fixes the following dtbs_check warning on stm32mp135f-dk:
>> arch/arm/boot/dts/stm32mp135f-dk.dtb: gpio-keys: 'user-pa13' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
>>  From schema: Documentation/devicetree/bindings/input/gpio-keys.yaml
>>
>> It renames user-pa13 node into button-user so that it matches gpio-keys
>> bindings.
>>
>> Fixes: 57012d79fefd ("ARM: dts: stm32: add UserPA13 button on stm32mp135f-dk")
>>
> 
> No blank lines between the tags, but I would drop the Fixes anyway. This
> is not a bug, but convention and coding style.
> 

Blank line + Fixes tag dropped in v2. Thanks

>> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
>> ---
>>   arch/arm/boot/dts/stm32mp135f-dk.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp135f-dk.dts b/arch/arm/boot/dts/stm32mp135f-dk.dts
>> index 9ff5a3eaf55b..931877d6ddb9 100644
>> --- a/arch/arm/boot/dts/stm32mp135f-dk.dts
>> +++ b/arch/arm/boot/dts/stm32mp135f-dk.dts
>> @@ -40,7 +40,7 @@ optee@dd000000 {
>>   	gpio-keys {
>>   		compatible = "gpio-keys";
>>   
>> -		user-pa13 {
>> +		button-user {
> 
> Best regards,
> Krzysztof
> 

Regards,
Amelie