Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <error27@gmail.com>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <joe@perches.com>,
        <Horatiu.Vultur@microchip.com>, <Julia.Lawall@inria.fr>,
        <petrm@nvidia.com>, <vladimir.oltean@nxp.com>,
        <maxime.chevallier@bootlin.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/6] net: dcb: add new rewrite table
Thread-Topic: [PATCH net-next 3/6] net: dcb: add new rewrite table
Thread-Index: AQHZJsEGC96Yx9M0kE+chXGjz/NRZq6b7RcAgAUYNoA=
Date:   Mon, 16 Jan 2023 12:52:36 +0000
Message-ID: <Y8VIk3SKwTC3rqfJ@DEN-LT-70577>
References: <20230112201554.752144-1-daniel.machon@microchip.com>
 <20230112201554.752144-4-daniel.machon@microchip.com>
 <Y8EChkENXkUjfUQf@kadam>
In-Reply-To: <Y8EChkENXkUjfUQf@kadam>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Aut7RG50EkfwERpb7wg1eqoroXaC2y+d1+bC0YQR0QGQzI7DnlnxYhifh0e5?=
 =?us-ascii?Q?oQ59yhzI99x7bCwUfMaZoeDGiagYoMPx2KPhT5elTjbqpV7DD4zSpf2JBJ7J?=
 =?us-ascii?Q?H/O0L8uL/AKv1jyB8/y2CU2Yyhqejn/Hx/AzoC+xY7piDNKuraBFpcCLf+mh?=
 =?us-ascii?Q?SljJHfvTOgTjFg8Qbyh1KEZKRVzrylDAuXDz8WbGYFUC7hmEWIfMngrvqy7v?=
 =?us-ascii?Q?L5O+9aw/WTgciof2FwiAPnysxjx0NChdbGp2uHSfELb+y7fOeFlML0IlzRMO?=
 =?us-ascii?Q?H8feO9gKI/K04bHkHrZAJEUuB+SFyIuLUB1GNYvQdBK+DiQH6gyw7NQB3vVc?=
 =?us-ascii?Q?Pi1sEXGRx83EI9jpVLeqV/z6jTCOX25y/o5HOoFskdujIbfdNkHVQLHlrtbR?=
 =?us-ascii?Q?YYDodgrqq1kcKVqpSIOitVXXzDwSwIqVfBAgim+wu6Db/UTg9daHpulL6fx2?=
 =?us-ascii?Q?04NF/8tvo9M5mNI/PEzutxZ9QXAzQebYZ+GKdFd7DkDFWYhy3gFjHwtLimdF?=
 =?us-ascii?Q?UCg9KLWxqavxzrTWzeVFn//1H8JqJuTpyr+r4sYpAkqBzvj5PTGYltaVGHb3?=
 =?us-ascii?Q?PxehohqQScyV42EHiN2TucLwGSvUvEDjizsCMwoEZQ1QLeAMNS5mx2R3AM+S?=
 =?us-ascii?Q?cf2cx4WWvsFj3+iFR4So7VlLvL9r70ZSxZ7vdJW20E4nbccL3pnlB9ZAFu7Z?=
 =?us-ascii?Q?jnjOoDlbgXSDMEaF5icoUHe8V5BXan7yBlOnRDk+PI+Fjp+T5uO+H/J1i/re?=
 =?us-ascii?Q?o/kHP5iZ+gqj4c1HygzHnnUx27Z7PCIpLmZamMqxoMCvh4LHUGZlF7EVgcx3?=
 =?us-ascii?Q?fV6mIPIe1VYR0xdcp0PsOwEj6aVqEPMgQwDfj0Uf4AlLGSZwTUolsPYE0OcA?=
 =?us-ascii?Q?dbMteHl38B/mNi26EY8rwLOJAE6kk7GOOXjp6/jvLfDH1OvaeRjHPtqgUR9g?=
 =?us-ascii?Q?4IOiVd0W/sLAJq7kH7HHrT7UxiNtugkaZhKqZ4M81BSDboQ7P7BBuSjvpIMr?=
 =?us-ascii?Q?EtTwrs/9ABjlWWY0KUXneat+b3BvQezMVAHp68Qr2aHUElrqM/An13jdT5rR?=
 =?us-ascii?Q?OJ7Jxf4TCR3oxNOULKK0C+AqAYCSWYDDPHCX/w2qeBlWPkITqlJQYdK53vq5?=
 =?us-ascii?Q?nqb3MBZ4hC07Vl299NbtsO9fcfBH6rqt4dm9xqHmmtrp4zN0baTGHk51+U58?=
 =?us-ascii?Q?cqc4Q2gSNWq62N0Yu5htJrWkcg/vbJndNsg2QrVTwl3Y7KCG6afCUbRTfJiS?=
 =?us-ascii?Q?49UAS+EXyI6dLhuo0tz5hFNTIhW2+I+caaey6Qo4UnB2InfRtuM42wh6fcKM?=
 =?us-ascii?Q?GXMi5BsyQlHZwiRMQRhWoQtG4KncwG5CdPiTbPGNQM7z0kDLrvH/O+DwUS7l?=
 =?us-ascii?Q?/gCocz3iDNwrMBaH0k94/xc3zhu17XgojjJuQvZ+N5GaVxwkwOiSGJzi8Zge?=
 =?us-ascii?Q?xylAr9OtWD+DHHsrRltjeI70G1xjiPTAv13TdSuRFmWA5bLMSIBSMWRp8qTf?=
 =?us-ascii?Q?FsKZltHG7GDVvWRtHhiOtUcYbICZmLm60uPOgTa7IDRSRvFp44yGPicjHPIT?=
 =?us-ascii?Q?+LWnP7/awUOG3grNkJ85PK4XL0eXDbQ45C/ltma4qc7OYz3WHSE9Kw9V/6FD?=
 =?us-ascii?Q?mA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B678C6B9A6D354419A275148091A72DE@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5580.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dee431db-b7fb-42d7-a808-08daf7c08b17
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 12:52:36.5242
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MaMfwsE4fzmZM+2AoEd+Se4F32TL3pU6RI0gqIQXxUU/yZYBNdcTC4qClgkhN+T+D66iU/zsIcl8QnzrFE0yyIbYj4J9SCwCz92GYAd68Ko=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB5968
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dan,
Thank you for your feedback.

> On Thu, Jan 12, 2023 at 09:15:51PM +0100, Daniel Machon wrote:
> > +/* Get protocol value from rewrite entry. */
> > +u16 dcb_getrewr(struct net_device *dev, struct dcb_app *app)
>    ^^^
>=20
> > +{
> > +     struct dcb_app_type *itr;
> > +     u8 proto =3D 0;
>=20
> Should "proto" be a u16 to match itr->app.protocol and the return type?

It should.

>=20
> > +
> > +     spin_lock_bh(&dcb_lock);
> > +     itr =3D dcb_rewr_lookup(app, dev->ifindex, -1);
> > +     if (itr)
> > +             proto =3D itr->app.protocol;
> > +     spin_unlock_bh(&dcb_lock);
> > +
> > +     return proto;
> > +}
> > +EXPORT_SYMBOL(dcb_getrewr);
> > +
> > + /* Add rewrite entry to the rewrite list. */
> > +int dcb_setrewr(struct net_device *dev, struct dcb_app *new)
> > +{
> > +     int err =3D 0;
>=20
> No need to initialize this.  It only disables static checkers and
> triggers a false positive about dead stores.

Yes, you are right :)

Will be fixed in next version.

/Daniel=