Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp3217675rwb; Mon, 16 Jan 2023 05:24:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXvwBacdTHdhPrJfFe9wDQyKZcvVFIwMABuktMK8Zr4mlEq+jw77FiEplLBSNef5PONfwf9V X-Received: by 2002:a62:e519:0:b0:58d:bce0:2bdb with SMTP id n25-20020a62e519000000b0058dbce02bdbmr1018962pff.7.1673875454289; Mon, 16 Jan 2023 05:24:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673875454; cv=none; d=google.com; s=arc-20160816; b=SOJx9WKN6Z5VgAx09u7HRSzplssWT2QDGT/aKXXacEfebQBGF09e8PENWNhB2RKH4+ cPDDVC3CCcvoBhM/oGx7HOTuynkP7agseIF6+X9SbWE27y3xrIVZ/y33WkYokqkoaXd1 PXVYLEeg63bEdQwYmIzuHuMhybzI89PF2zrqG3yGv1feAITgzdkkKjVpmUI76aFRJFAu IVSSAXzXz9t45RcMNlkFAVPSN8fIQnqiVk9AfDhj23GKhcAup4YkjFO/wZ4lxHmAeOEd 39rowcnah0NuoTqZ0ginwHRl1bp7M0usYl64dt8SZbAII2YfEiNjg6bzWPIKl6PM3cOL szqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=tu5OJOBIgMLHuUpsp6UpRFubmqLqzfGdVmO7CU8EkKs=; b=kpnXRFLEdOqtmXSfjM8pygMb/9wm0IfBQzaHvahlCafMvr+CAGTdS2gLpO6l8BQ87L yL8lpn5/CmKgH74BQhfHwqAso4+GnZEr9pHluvhHFHJlXPX/6+k0AyZ3TXKSPoO1yQlq DEUvXCfO39yrXYN/g5GZTBJKpsI1F9GuZhRGSyDWiKNsbGSRg3W0zZ39lFUSozcXpktK TGmZojMPe0CQdy74yvjakA4+ihin9faaniHua/EgXpP7yYlSnr0UIVfxzw+CT5luCNeF kmdgPJVNoYooHOng9sG36+iR4vVkG842wqdEXTdbIp2UoLT/lNg/+pBJKQmU0278+YnE gB4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="I4tjtw/U"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a056a0010c100b0058be9a977d8si7081830pfu.380.2023.01.16.05.24.08; Mon, 16 Jan 2023 05:24:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="I4tjtw/U"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbjAPM33 (ORCPT + 51 others); Mon, 16 Jan 2023 07:29:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjAPM30 (ORCPT ); Mon, 16 Jan 2023 07:29:26 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 968C81CF73 for ; Mon, 16 Jan 2023 04:29:25 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id i65so17359300pfc.0 for ; Mon, 16 Jan 2023 04:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tu5OJOBIgMLHuUpsp6UpRFubmqLqzfGdVmO7CU8EkKs=; b=I4tjtw/UCFox/srRbt1s5pAj87hrugXKw43CBMeH86AXlSaAAwipyCqo2EdfOZLTnh n9ijnEfgcThnWNV7FYPAOgzV5oHG+5F+e4kY6x/llVkrrr53Ehym4fkIrfPbKvqLR6Ds 1NY+lxiUt9ma9a4/JGkI/hsgSN9hEjqQAnNPjkYlLLrl+m6gjBMxa9WjLxC0Uj1o/ePo yr/XLGNv77kMWeNfiWCg3Dr8El1QQiQrboFfpJxXasmr2YKjYI/5QtzN9e2cjfsR3k98 W3fFOChDz+/s7wqaL0cb+cyJFM9jKT/qmMAfdRF9Um0TZEbj0bIknjS4AxX+Ai507ixT b9UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tu5OJOBIgMLHuUpsp6UpRFubmqLqzfGdVmO7CU8EkKs=; b=sj52+xhZ4H3oq0uhQt/VJ20yeeGOi6DJudZH9Wx0+oCSEKvDRM4T7rzv6UOaLd37Cd LJrrtoBRR1vw5qH34ZkjK/a1Bmgq8TwLZbv02jUkPTvtvTVRF1EuJn3NXHj1IaZOOCYj ysxu0oGVBqz8AIutlM/RD4UDgXE2AM+Zb1lDsRKwzd3WPE64I4nVnz+c7JHCYTHbSpzZ uHRlXmDKv5cj+l1178W5WhVa7QIWgOS/gvf8lYfuHMWvs9PPT7SpjEsixqrY0uXTwJbn cBAk/X52RWsP+cTWL7rsBClzk3pH9d7kkP4bsKpxMmV9yhdnJ3cFJKdyKjEEEibE9zQQ WVcA== X-Gm-Message-State: AFqh2kpiILCB+D6725gADwsuu3DpHEaqtnEN0IZoMfrvJGD/RVehBmTe zhPucRD+eCr5JPHMV3yUaJCrLRUAxcKH2qTE4fuV4Q== X-Received: by 2002:aa7:88c5:0:b0:58d:aeb6:2d66 with SMTP id k5-20020aa788c5000000b0058daeb62d66mr200816pff.66.1673872165004; Mon, 16 Jan 2023 04:29:25 -0800 (PST) MIME-Version: 1.0 References: <20221219234638.3661-1-mike.leach@linaro.org> <20221219234638.3661-5-mike.leach@linaro.org> In-Reply-To: From: Mike Leach Date: Mon, 16 Jan 2023 12:29:13 +0000 Message-ID: Subject: Re: [PATCH v5 4/6] coresight: configfs: Modify config files to allow userspace use To: Christoph Hellwig Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, suzuki.poulose@arm.com, acme@kernel.org, james.clark@arm.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'll rework this in the next set. Thanks for the review Mike On Tue, 27 Dec 2022 at 17:10, Christoph Hellwig wrote: > > On Mon, Dec 19, 2022 at 11:46:36PM +0000, Mike Leach wrote: > > Update coresight-config.h and the coresight-config-file.c & .h > > to allow use in userspace programs. > > > > Use __KERNEL__ defines to filter out driver only structures and > > elements so that user space programs can use the descriptor structures. > > > > Abstract memory allocation in coresight-config-file.c to allow read > > file functions to be run in userspace and kernel drivers. > > That's now how kernel code is written. -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK