Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8d44d547-2da0-008a-e0eb-e42d40ab993d@amd.com>
Date:   Mon, 16 Jan 2023 07:17:38 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 0/4] iommu/amd: Force SNP-enabled VFIO domain to 4K page
 size
To:     Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Cc:     joro@8bytes.org, robin.murphy@arm.com, ashish.kalra@amd.com,
        thomas.lendacky@amd.com, vasant.hegde@amd.com, jon.grimm@amd.com
References: <20230110143137.54517-1-suravee.suthikulpanit@amd.com>
Content-Language: en-US
From:   Eric van Tassell <evantass@amd.com>
In-Reply-To: <20230110143137.54517-1-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkZkVnUvZGk5OGVZVkdiNnhRdGZQZ25WbXhCM0ZjcE9vN3FqZW4rcGRtTHFt?=
 =?utf-8?B?VXRDRldHSkRmeHpBWnVYL2pySVA0ajJZSDI5MHgvSkNTblozOFlDSXRNTTRs?=
 =?utf-8?B?U0ZBNDVjNlBrWFlkZzNjZkxXR3hsNlZrRHJvK0xKRDlUOCtrcmhHbERIb1Rq?=
 =?utf-8?B?czZUeUhsek0xZ1ZFSzI1dVA5a3l2dUZUMlI0YnFKRUtuaEZLVXdpWHpjVGM0?=
 =?utf-8?B?bTU1VjZiR1FVN0p5RTR3TGI2OG9TeGI1MDdncWhQNm1qbEZmMzBUM24reGZv?=
 =?utf-8?B?TFppemRmNlpGTHZ6aDJoUzdTRFUxYjZUU214SlErMFliWUJUZVlCK2l0SzFm?=
 =?utf-8?B?TEJVMlErSXh0MDFnaWNsMmU3d0h6ZVNmSjYvR2tVWTF1djczSWVKdGZXc21u?=
 =?utf-8?B?dzFjeE1GMnJZbGtQMk1Kb29BV3IzMlpqVnNScnhPMG1ZVFd1OXBvRlpHV1NT?=
 =?utf-8?B?Wk1uVDdJVjZ5Zk9UbkUrOFdzajN2bVowTndReWdUbFd4WU94akNUczFFMlUy?=
 =?utf-8?B?OEFIU0JCbEdxU3JiU0lENW9IdzlUb3FYQUFLUWVLZ1ZoVlp6S2RNdzJDd1Fx?=
 =?utf-8?B?NUM4WnRoUURxV3FIRGxHM3NQaVBxbEZWcGJPTFB3QXVjZXFvR2hxZlZNaFlW?=
 =?utf-8?B?RzJvUEJ2QlY2VEVERzBoV2QybHlvYWRBREFETUJzSFYyS3Q0S0Z2Ni8yQkh5?=
 =?utf-8?B?b1ozbDNLWVloTnhQU3UzdnREaTJlOVdXMUVMeU9VZ0ROcFFLY3pmYXRid0xO?=
 =?utf-8?B?OVVwN0d0WkRRV3lXN0dTdE5Dd3FZZktxd0JtZFVZcUNUelRaejlPTmZpTGhM?=
 =?utf-8?B?WnVnTWc5bzFuaGNoOXhSWUhRcCtIUmYwWnhHdjdaWll2VWM3Yzd6QnZNcHRZ?=
 =?utf-8?B?MDhYNis2Q3VISHp6YlJEVGJELzd0eVBVNDJvSmxnUUszZWt2SUJrZ2QxamZz?=
 =?utf-8?B?YWJkZUFjdkhlRGpxdHJZSVFYNitCdzJmemNoaG5nc0lpTGZ1WkVlajY3Uk0y?=
 =?utf-8?B?b2duNEVvaFhYL1lKc3R0S0hHK2VaRTk1NUxuSWhDanRockR4S3VleStRaWhE?=
 =?utf-8?B?ZmZYRW5IcFBDNW9YeFUwL0tVZkpwOXZETnZpcTVNL3J1TTE1TWRvTkU4aTkw?=
 =?utf-8?B?SW5yejlaVnlhTmJCVThGOXNxdlBLZWpNTTg3dWF2MjQwM2IvKyt6NlFOSnBK?=
 =?utf-8?B?MkVQZ0RPdzB2QXk0TGxCeUYxZWZtMnZuaGpXUUFEaEpycU5DQ2Q2UW5iUW12?=
 =?utf-8?B?R0NxZ3RiS2pKUUxvK3EvUnVDZlN6S3ZxSlFtTi9IeW41STVVaVFweFBHSHVX?=
 =?utf-8?B?THhWVmpDMW53V0tCZmV1NmRFUXBLa1dFaldmQ1NoL0dYNEt6WCtDV3B5dnR1?=
 =?utf-8?B?bW0zOGdmMHFpMlB4R0RTbXgyZTFRNm9VakErVHkrT2JmaEZKdWt3NEtWcGxY?=
 =?utf-8?B?TnZ3eW8wMVByMVgrT1NPMVQyN2I5N1BjVFBmdDRlK1RxazRDekZuSXBIcnhZ?=
 =?utf-8?B?YVdLYm12bkZOQUdEb1JubGdoekVWdUdSb1FLZXBaRFlLUFhJNDkyNGovb0Iv?=
 =?utf-8?B?TXROSWd2RnRNMk5NdVBsUjZZNzQxd1IwWTcyNGE4NHllOHJSREdKTk1ucWw0?=
 =?utf-8?B?V2tBbnVOYVZSM1ZEdUMzcXBaU2xoclRnRGxXc3hYakdCQXZUNGIrM2p5UGdQ?=
 =?utf-8?B?VUk3aTR3NjJwRWNGUVU3U205SjVJeUsydjBDQURRMHA2Vml1cmFDZDdVUVBz?=
 =?utf-8?B?OTBMbnlXQkdNV1g5eHlPZHpxbnJVOVNsY21qSTA0M3FnNjNWVUdBTENJZ3Iv?=
 =?utf-8?B?UTVyL21QSlNJQlhsZDNVNnBZbjZraHJuVGZjOVVUSWVPYmRMMDV0UnhFN1dN?=
 =?utf-8?B?N1BTWFBPNnpvUTh2K2txejY2SklJdlZrb1pna291VnlFK1pmY0lRZm5hZ0F3?=
 =?utf-8?B?dVVHS3M2QUVMcDNRV2VMMVBsY2JuVUJYUTNGVWt0Z1lHMnNjRXpHeTNMdHlI?=
 =?utf-8?B?VzBUWDZPaVd0VG1PdDh4TEJ1akhFclhjM0QzZE9OQnhiNk5zTXlxZ3lpdmcy?=
 =?utf-8?B?b2hCZ3NMcmZMMGxTUTRib1J5UDZzV0xuVTlXdzJKR3BTbVJUMTZpSTI2Mkd4?=
 =?utf-8?Q?GrRbFQ027JgIPCdJ4BZQ5hISF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c28c6a5-2147-4b4b-9284-08daf7c40b6a
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6481.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 13:17:40.5560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wn3Y7vXuBlgjmNjxuvDUNeFjFOu3CtOo6Ihd+XF1NDLYBdGrZsGmGQgD9x7l0M8CQupUZ4n64dOAmTnFMQO1XA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5617
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

what commit should this series apply onto?


-evt

On 1/10/23 08:31, Suravee Suthikulpanit wrote:
> To support VFIO pass-through device with SNP-enabled guest, IOMMU needs to
> setup IOMMU page table with matching page size to the RMP. In order for
> the IOMMU driver to setup page table appropriately, it needs to determine:
>
> 1. If an IOMMU domain is a VFIO domain (PATCH 1)
> 2. If an IOMMU domain belongs to an SNP-enabled guest (PATCH 2,3)
> 3. Appropriate page size the IOMMU domain (PATCH 4)
>
> Please note that patch 2/4 is a preparatory patch for an upcoming series
> to support SNP, which implements the call-back for the struct
> amd_iommu_svm_ops.is_snp_guest().
>
> Best Regards,
> Suravee
>
> Suravee Suthikulpanit (4):
>    iommu/amd: Introduce Protection-domain flag VFIO
>    iommu/amd: Introduce structure amd_iommu_svm_ops.is_snp_guest()
>    iommu: Introduce IOMMU call-back for processing struct KVM assigned to
>      VFIO
>    iommu/amd: Force SNP-enabled VFIO domain to 4K page size
>
>   drivers/iommu/amd/amd_iommu_types.h |  3 ++
>   drivers/iommu/amd/iommu.c           | 45 +++++++++++++++++++++++++++--
>   drivers/iommu/iommu.c               | 10 +++++++
>   drivers/vfio/vfio_main.c            |  1 +
>   include/linux/amd-iommu.h           |  6 ++++
>   include/linux/iommu.h               |  4 +++
>   6 files changed, 67 insertions(+), 2 deletions(-)
>