Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <571d5a60-dfcc-d8f9-8c42-0da70b0913f2@linux-m68k.org>
Date:   Mon, 16 Jan 2023 23:15:57 +1000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v1 1/1] gpio: Remove unused and obsoleted irq_to_gpio()
Content-Language: en-US
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-doc-tw-discuss@lists.sourceforge.net,
        linux-m68k@lists.linux-m68k.org, linux-sh@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Jonathan Corbet <corbet@lwn.net>, Alex Shi <alexs@kernel.org>,
        Yanteng Si <siyanteng@loongson.cn>,
        Hu Haowen <src.res@email.cn>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>
References: <20230112133942.58471-1-andriy.shevchenko@linux.intel.com>
 <CAMuHMdXSc-H5TKBGisthv3DH3sZmF3fV_15FuMEt=typwTWUtA@mail.gmail.com>
From:   Greg Ungerer <gerg@linux-m68k.org>
In-Reply-To: <CAMuHMdXSc-H5TKBGisthv3DH3sZmF3fV_15FuMEt=typwTWUtA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 13/1/23 01:14, Geert Uytterhoeven wrote:
> CC greg
> 
> On Thu, Jan 12, 2023 at 2:39 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>> irq_to_gpio() is legacy and unused API, remove it for good.
>>
>> This leaves gpio_to_irq() as it's used yet in many places.
>> Nevertheless, removal of its counterpart is a good signal
>> to whoever even trying to consider using them that do not.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>   Documentation/driver-api/gpio/legacy.rst             |  8 --------
>>   .../translations/zh_CN/driver-api/gpio/legacy.rst    |  7 -------
>>   Documentation/translations/zh_TW/gpio.txt            |  7 -------
>>   arch/m68k/include/asm/gpio.h                         |  7 -------
>>   arch/sh/include/asm/gpio.h                           |  5 -----
>>   include/linux/gpio.h                                 | 12 ------------
>>   6 files changed, 46 deletions(-)
> 
> [...]
> 
>> --- a/arch/m68k/include/asm/gpio.h
>> +++ b/arch/m68k/include/asm/gpio.h
>> @@ -66,13 +66,6 @@ static inline int gpio_to_irq(unsigned gpio)
>>                  return __gpio_to_irq(gpio);
>>   }
>>
>> -static inline int irq_to_gpio(unsigned irq)
>> -{
>> -       return (irq >= MCFGPIO_IRQ_VECBASE &&
>> -               irq < (MCFGPIO_IRQ_VECBASE + MCFGPIO_IRQ_MAX)) ?
>> -               irq - MCFGPIO_IRQ_VECBASE : -ENXIO;
>> -}
>> -
>>   static inline int gpio_cansleep(unsigned gpio)
>>   {
>>          return gpio < MCFGPIO_PIN_MAX ? 0 : __gpio_cansleep(gpio);
> 
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Greg Ungerer <gerg@linux-m68k.org>


> Gr{oetje,eeting}s,
> 
>                          Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds