Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp3254596rwb; Mon, 16 Jan 2023 05:53:53 -0800 (PST) X-Google-Smtp-Source: AMrXdXv4iHxpm6tQFw2Sc7kCv+bR8hPRUSV/FPSvCinQObxkg2u5l1vmOql9WTbCs3dEfBCpW9GJ X-Received: by 2002:a17:907:8a24:b0:846:95f9:5b4d with SMTP id sc36-20020a1709078a2400b0084695f95b4dmr102861925ejc.42.1673877233176; Mon, 16 Jan 2023 05:53:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673877233; cv=none; d=google.com; s=arc-20160816; b=SZ7IvRpWFkXHjoAdzDsjOFnpwBakJftBGHS+iKgNEZ+VuL8OuA/u9SuogeYMZpB7te EBpXYmey88bbmXFj0PDdr1OUjfBFDajlEI/sbBFoNWDJjJlx9ajpizT87vMvtCQOuh6a 7gCNCmxG6MSNaTnvf5dC0UppOMLPYmflXt66tazhmpAfIZdktJ0dOtQ7+xSUCsWTxkLE e03cBchXXFftgFLtKcnGrWLcNQOhE+Tue3Eatduz7i76XmgeRmdR9MhbNn0jDTwtaedJ p7vBCz3ZaLoryXN4oUs6bWJcgR7BvayiFaLGaz9yPtk76Be71jjutv4MgxSSDyH+ZDXY w2tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=2FzpQyVm83f/04L7+FxV9gBbjrZflnMg82zsuvYJlxc=; b=oFWytvZhsv+Rdmz01/dlmnU2WfL1fNRJDMWUn6eaA8imUdh1GrjcjipViVdvOSU/ne Z079E4lNRZfpRp+A9vTzYOA1Cz7FxI8sN4dWm3ZucdD1IpKLhS52kDrBjZBA4JoOovnJ xiufjJ0ID1wW70tKX4v4q1IA0D7/gmgiHNIrJSCaJBA8QxqemUdWVSO9PRF2LVZD68zA amebDCDsRGBFUWXIeCcmZzBhQbIUMCsnTMnJyUcqcXs69XQcxlY3qYmF7FTggkJ3oxaW esirTXOU/54iTzFt+/hA5UOmXUFzxvU7xJbf690TqE9pJgg4Tnalbx9BIMsubGaKSDiB s/aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ji7hoiqf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw9-20020a170906478900b0086d67a10566si7897037ejc.190.2023.01.16.05.53.40; Mon, 16 Jan 2023 05:53:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ji7hoiqf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbjAPNSI (ORCPT + 51 others); Mon, 16 Jan 2023 08:18:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231589AbjAPNRn (ORCPT ); Mon, 16 Jan 2023 08:17:43 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16B1F1EFE3; Mon, 16 Jan 2023 05:16:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CE7CAB80D31; Mon, 16 Jan 2023 13:16:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AB12C433EF; Mon, 16 Jan 2023 13:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673874968; bh=5Y3OayCpNahHzw9Xu2OoIo50BHoizMUaQvkXJFa58jc=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=Ji7hoiqffDLLiyyHf0MQuVT4t+x2VkeKFh2OvBxm6GGBp1tBuMO3b6X9fpD2WOY1H VUKulXpprZWegUh/ActP4x8MtUal3gP5W1zJUfFNUI/TTyX2fBWz+7rNmtkZeeo+Ks YmNXMQ6OIABQdK2Vyy+9wy8UPNh0uDH/r8AFXuXAAWGdcEQH/bcLju5LIj5/OHMrZm lg6x6aUaQlpHyUYZ6Ckwy8cQkuWOBZ54LuZwImESBmSfVeklfwL2lmFcfkRbu722V/ 0QxZX8HURk0cFoKUG9MF/Bg/SHdRKSaydaKSGiKJfE1Vhj8lCoVx9lWfLbidzXmypJ IeoDqHksqQWkA== From: Mark Brown To: Serge Semin , Andy Shevchenko , Serge Semin Cc: Alexey Malahov , Pavel Parkhomenko , Andy Shevchenko , Sergey Nazarov , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230113185942.2516-1-Sergey.Semin@baikalelectronics.ru> References: <20230113185942.2516-1-Sergey.Semin@baikalelectronics.ru> Subject: Re: [PATCH v2] spi: dw: Fix wrong FIFO level setting for long xfers Message-Id: <167387496509.317866.16090598149927325020.b4-ty@kernel.org> Date: Mon, 16 Jan 2023 13:16:05 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12-dev-69c4d X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Jan 2023 21:59:42 +0300, Serge Semin wrote: > Due to using the u16 type in the min_t() macros the SPI transfer length > will be cast to word before participating in the conditional statement > implied by the macro. Thus if the transfer length is greater than 64KB the > Tx/Rx FIFO threshold level value will be determined by the leftover of the > truncated after the type-case length. In the worst case it will cause the > dramatical performance drop due to the "Tx FIFO Empty" or "Rx FIFO Full" > interrupts triggered on each xfer word sent/received to/from the bus. > > [...] Applied to broonie/spi.git for-next Thanks! [1/1] spi: dw: Fix wrong FIFO level setting for long xfers commit: 9ef7b7b43eb708c114bb3ce6c0acadd74065bf4e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark