Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp3401570rwb; Mon, 16 Jan 2023 07:33:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXtlyxdNQViyM6JN8eq9StSKat1QVgquzaVCr8kzkLxaNBglsRdiKGz0Dye5doBo9PmWwFJ6 X-Received: by 2002:a17:903:491:b0:189:dcc3:e4a1 with SMTP id jj17-20020a170903049100b00189dcc3e4a1mr177304plb.9.1673883223999; Mon, 16 Jan 2023 07:33:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673883223; cv=none; d=google.com; s=arc-20160816; b=AcyJiU7UcSC8vBpCdRgbDy7mDjh8ssLQz1Nn8YZhkJw4Dl85qAIC1vSBd62jwRlMFu 3rDaRbUYSq7JQjIoquw6fjQvlLABTrG/ntqghP0bcKHF5/xFIh5vMTLC9Mk1fJ4IY5ZJ pva14ZH9STGF1hmOcwcokB7Gu87LE6EQC+/qAuIRw5p4vFphx4Nn69W2FByc+dWERFUy rnzu5qm4aAV+vKo4BgK+m3e1ltM90dwlXEyHbZ/RL6ePYFLo/SkNL1xMIkRqR0Owb+pN b/RCSUV8YL4ruZuuELPnwyv9WOPwXAhco1qJzSccsT64U+sOrR3v4gzuMLItJrT5kD8t tecA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qCQNprj6nr0lXLsaTVV6wQyMOyfyBoo19yyE5Px7Q6M=; b=UDrvDWWIpTbscHJzV0eCWgepLp+jVu6sp2mJe+nyGV6dm0nMtTO+AwQhZSOo/XQXog VO/44wHe8lklFvV6w3hzjEmhBdQggf93Dy5bUcguCWW+U95av+jG32cR/I1P1cMJQO2p G86bVzg7JvL0BQzX48PxaGyApTsu6V1oRSQhMhhzj3yg+2SoVn8zdPOOafWmEdWe+dW8 uEFIVarY7lnIGqZCqExGmVLflEFAdlomxIA0azCUomLOtOCJ9Iqck05W28AR3n/Y/JIk h5Oex+IVRQ/P6ARErN9SXxXDcQBHyJcA9UTaa2sssxVmL8AC9wVg0NQIyL/wJ6omaNVd segQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AztPyLCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q5-20020a170902dac500b0018c166e2304si32295109plx.299.2023.01.16.07.33.37; Mon, 16 Jan 2023 07:33:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AztPyLCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232681AbjAPOxg (ORCPT + 50 others); Mon, 16 Jan 2023 09:53:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbjAPOwg (ORCPT ); Mon, 16 Jan 2023 09:52:36 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1656023D8A; Mon, 16 Jan 2023 06:40:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 88DE7CE1169; Mon, 16 Jan 2023 14:40:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14F89C433F0; Mon, 16 Jan 2023 14:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673880009; bh=qCQNprj6nr0lXLsaTVV6wQyMOyfyBoo19yyE5Px7Q6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AztPyLCvQ1+2OjD3/3xu098AjFJSckBiTwktM+DJ28eiB3Y+stOtqnFYFCMT6HfQ9 qXtHaqi4wSjVQtG7mZF8QubhbSEvAXnI9WlgEod94njvyXRPBT6zoiQ0Vg/2TTtxyF Mz8pLE+Is2dJMe4BB2r+ud4E6thGUU+/mplq/5vov+YC7k79AwJz5ep+Xm2yZtyiJe MxTjWaKC741NCzNH6QAw0qCiFgLRYVvVgwwF6VTnNYqx5ayrBK9ZtWxzVRKiSRMzj8 vxhNiw7bbJXv09e6MHUyNad67D22/lUTHs51V6ks1rT/iTEd9jmyFOqaq42nZIEKgT l5frAUxY1xLMA== Date: Mon, 16 Jan 2023 14:40:05 +0000 From: Mark Brown To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bartosz Golaszewski , linux-spi@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.10 11/17] spi: spidev: fix a race condition when accessing spidev->spi Message-ID: References: <20230116140448.116034-1-sashal@kernel.org> <20230116140448.116034-11-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HRyw640IPxuIZjTZ" Content-Disposition: inline In-Reply-To: <20230116140448.116034-11-sashal@kernel.org> X-Cookie: Serving suggestion. X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HRyw640IPxuIZjTZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 16, 2023 at 09:04:42AM -0500, Sasha Levin wrote: > From: Bartosz Golaszewski >=20 > [ Upstream commit a720416d94634068951773cb9e9d6f1b73769e5b ] >=20 > There's a spinlock in place that is taken in file_operations callbacks > whenever we check if spidev->spi is still alive (not null). It's also > taken when spidev->spi is set to NULL in remove(). There are ongoing discussions of race conditions with this commit. --HRyw640IPxuIZjTZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPFYcUACgkQJNaLcl1U h9B32Af/c2VYOXgQmB1VgAWYJ1esiMKPBMqNlhspvd31are1grJmxa1QlA21KMXR 9meJyt94TbUOs22oJhx5Mrcegc80jfoRKFgtlOmWDviFBfDC634HOUuYGfVQHy1B croJdlBxTXJmSZwfarZxhFrXnQr0DBN/xs/6LWGNEErpiF2H9bJJg5rD5NsGBUcT b33P0Hdurru1D4HKBUzU0woy32SipUzn6fNmbAxyf5xOGvLiQJXbERWeYZQYyhpP y6vH91cIcrfxWDh5UaWIHrJtWsNcpZOgGgTZWCMzv8g7OIJGUKc2wkRyKqN9F8nW CEjbOAkOSsrMDrPVvgdJC2n7V3tdTA== =OmQE -----END PGP SIGNATURE----- --HRyw640IPxuIZjTZ--