Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pierluigi Passaro <pierluigi.p@variscite.com>
To:     linus.walleij@linaro.org, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     eran.m@variscite.com, nate.d@variscite.com,
        francesco.f@variscite.com, pierluigi.p@variscite.com,
        pierluigi.passaro@gmail.com, kernel test robot <lkp@intel.com>
Subject: [PATCH] gpiolib: fix linker errors when GPIOLIB is disabled
Date:   Mon, 16 Jan 2023 15:08:11 +0100
Message-Id: <20230116140811.27201-1-pierluigi.p@variscite.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+eYNetVPmwKZqZMlkzqUuci7+Y8jnfC5fVUsOOqtZSLNTGygU3T6DOrpiSPf?=
 =?us-ascii?Q?KGxe0MdDCm9PA3v0ENC7QefoPYquu/E8Q/7TnqkfQzpzOGxXtf59KHBVT94J?=
 =?us-ascii?Q?EXus2tbLW6D7KIptMnA3LGTUXAXPLlwql0ELtBA1vK/1SuyiuqvJyEOhpL+f?=
 =?us-ascii?Q?2QCpfYQNrkqwH8TkzpK/YK/e2quT1WRiN5gE8Io2QTNh2YjV40OegTwMtfi1?=
 =?us-ascii?Q?KXbOtseLvaw+bBjg/AdfbRG7LLhiltAdal/FSIqQe9IYv08vJYcjy3lncvDf?=
 =?us-ascii?Q?ED+a7xJ+1W1SyvreJh3dLJ1UOoOpihlR86aGfMKVvrvIMHzXjjAWySCOscPs?=
 =?us-ascii?Q?hHKGIijDQy9YCN1a598FpgFNNhc+TFrVV43TGPa7IFSPax+WB0I6Wof1cvIX?=
 =?us-ascii?Q?RTFzk/BexFu8/MtytHWq76nyzteuvjH0IYxt9j8oaAqyvQlK6qWc+M6gnloU?=
 =?us-ascii?Q?tqOL0nqmWSD/J0v4tCmegdtFOr6IyTKtS/0qzhYMmhSpr9Pow5o4hCB2liyi?=
 =?us-ascii?Q?0tkCcJP8L2NiVohpLSVgpFPSPJhYUCn5VBtlglBJZmCyfE7NbbUIUFj0yttR?=
 =?us-ascii?Q?L7oYbRylSsIcERxQMQQU2wrAFfvXaGl+4tVY+Ul2aVXtdlDmBo7dujF1GdM5?=
 =?us-ascii?Q?jMhswAQTmgaMCkKaBtIZYQfPr0GfsD09YGzpUkcBvEb4/jGVYQCuL5wus0jZ?=
 =?us-ascii?Q?/23MBM8io0dDcTCU7Eo+LSpMykoBGrgcg1P0d5qihDty1v5SqvFjf+JwSzfR?=
 =?us-ascii?Q?81V1V+QYkNg9b2Alhe+iAsMkMoowWZppbm26dy7ylhYo6I7qF9xHCHmiHjWi?=
 =?us-ascii?Q?nI6NjzMVtX+2+Y7ORX+mlu0i/6IE3QC+qj0lI0Dw5qpZTztftAJw1y5+W4gl?=
 =?us-ascii?Q?F9MPm1Vf9GF1vYJbHNhLaY/4sfJPB1YxFbNk8ORjawLjHm9HB0WynFsaxMGY?=
 =?us-ascii?Q?y1A33KLv57aW1AD3OIQaUSTamvZgXSA59eiB3yoav3KK4K32jZ0RrsQDjQic?=
 =?us-ascii?Q?rlJR4V0biephiaHdkjkDKLqdiOD7Jiu4omXLLfoX5xiUqeXkPhtW8rF8Jxa8?=
 =?us-ascii?Q?+6fUrXznsmW1+Z7g4Z8BHqYzivXw3vYMAT9MNZ3UofU4GARaSlewaiE/byU6?=
 =?us-ascii?Q?8NkPSiBDiDM1ZIRDFubVD5UE8GsYw0OUvXLp5pGGnvafsLYRux18fs2IIoR+?=
 =?us-ascii?Q?a20R4mNzDgs7WbSnRAEQ3lSjEW8SuSnS41FbRrFY2CJykl2bPmylbRABAxOa?=
 =?us-ascii?Q?mh9ISjfZW8V2y9cHDqOFenQxDB/zwXMOYNRtSCw/taeSJVYFVeyX38NC393g?=
 =?us-ascii?Q?WTJPFTzln9eXon+5a3YXCXVoF7prUHSmjOPjr6VGYLV3C6AMk/JcJobEu5Uy?=
 =?us-ascii?Q?Iq/TdX8M+xQdNvRlSGkJdKTKFoMtTHmTd1bfKUymm3vKX2asgY4XekHR95po?=
 =?us-ascii?Q?26tb+w/k0ch+mXxKnxEVEKwjTqeXaJRtHRQdAPlNwV3KsmAu5t9PXW+YRpa/?=
 =?us-ascii?Q?ktQ2G1LRVCKyMLGFS//YF4P0edGPXOt8ZJkxBzay/2foqQH2srdmntbqhQcD?=
 =?us-ascii?Q?BE4ypUorhGNOkVkU8v0V8pl7Uii/w6141AU7acwhmnLq/k+G2iE8Uo+8TQca?=
 =?us-ascii?Q?Ag=3D=3D?=
X-OriginatorOrg: variscite.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19ff2746-841e-4421-f309-08daf7cb1e8e
X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB4376.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 14:08:19.4296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 399ae6ac-38f4-4ef0-94a8-440b0ad581de
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pp4xQjzR4iOScJCY0VCKJHR4uKmMAaIxxGH1btWvOZ/G22NaaTBGbGlyTySS3zqoXL8RWLa+1hcKNfPDVAvCR5Vu10GLksWplZ3veR3Sx3A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9080
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Both the functions gpiochip_request_own_desc and
gpiochip_free_own_desc are exported from
    drivers/gpio/gpiolib.c
but this file is compiled only when CONFIG_GPIOLIB is enabled.
Move the protototypes under "#ifdef CONFIG_GPIOLIB" and provide
reasonable definitions in the "#else" branch.

Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
Reported-by: kernel test robot <lkp@intel.com>
---
 include/linux/gpio/driver.h | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 44783fc16125..ed77c6fc0beb 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -758,6 +758,8 @@ gpiochip_remove_pin_ranges(struct gpio_chip *gc)
 
 #endif /* CONFIG_PINCTRL */
 
+#ifdef CONFIG_GPIOLIB
+
 struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *gc,
 					    unsigned int hwnum,
 					    const char *label,
@@ -765,8 +767,6 @@ struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *gc,
 					    enum gpiod_flags dflags);
 void gpiochip_free_own_desc(struct gpio_desc *desc);
 
-#ifdef CONFIG_GPIOLIB
-
 /* lock/unlock as IRQ */
 int gpiochip_lock_as_irq(struct gpio_chip *gc, unsigned int offset);
 void gpiochip_unlock_as_irq(struct gpio_chip *gc, unsigned int offset);
@@ -776,6 +776,22 @@ struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc);
 
 #else /* CONFIG_GPIOLIB */
 
+static inline struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *gc,
+					    unsigned int hwnum,
+					    const char *label,
+					    enum gpio_lookup_flags lflags,
+					    enum gpiod_flags dflags)
+{
+	/* GPIO can never have been requested */
+	WARN_ON(1);
+	return ERR_PTR(-ENODEV);
+}
+
+static inline void gpiochip_free_own_desc(struct gpio_desc *desc)
+{
+	WARN_ON(1);
+}
+
 static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)
 {
 	/* GPIO can never have been requested */
-- 
2.37.2