Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To:     Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Geert Uytterhoeven <geert+renesas@glider.be>
CC:     Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Chris Paterson <Chris.Paterson2@renesas.com>,
        Biju Das <biju.das@bp.renesas.com>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Jacopo Mondi <jacopo@jmondi.org>
Subject: RE: [PATCH 1/2] watchdog: rzg2l_wdt: Issue a reset before we put the
 PM clocks
Thread-Topic: [PATCH 1/2] watchdog: rzg2l_wdt: Issue a reset before we put the
 PM clocks
Thread-Index: AQHY+nqlXRu/6yqD8kG6N6RyQH2tma6hiOYw
Date:   Mon, 16 Jan 2023 15:28:16 +0000
Message-ID: <TYWPR01MB8775AD226DC8128F3B353AEDC2C19@TYWPR01MB8775.jpnprd01.prod.outlook.com>
References: <20221117114907.138583-1-fabrizio.castro.jz@renesas.com>
 <20221117114907.138583-2-fabrizio.castro.jz@renesas.com>
In-Reply-To: <20221117114907.138583-2-fabrizio.castro.jz@renesas.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Qi5u+/xlS+ewjcdtPHynggjrhE1qs9HxL6JtrHwljaIHm7MPeNtzw7SvwrW+?=
 =?us-ascii?Q?khnA7J7WGRjGwPdcYVF+mAO5nuV9URbntCYRQ+EO8wB/MylDDxgTCHXpFC7W?=
 =?us-ascii?Q?JiIU3lkorGw3dtJhL+DffBgsT3q/TbV/VZLHfTKmoLyczV85TClJmUBAAt/H?=
 =?us-ascii?Q?eKD2JSF5EZB2FmPoGpMF+nhCgRUGbM25X6WTJMTH61CPojdUt0ubP+T/t0mw?=
 =?us-ascii?Q?5IIRkctiv++/0ugNkn5NvP+iE1OGl8CGw6kMc92KV36aPW8l/qGwzVqbRpEJ?=
 =?us-ascii?Q?M6BK2ePdQ2T89eoaYigbEekG01dCmINoVAmOeF6INR5UcEEwMRa/LuEWYpj/?=
 =?us-ascii?Q?JMsaAL+/k5pQ1lM9htzK4SU5K+a1vu82zK3Q8gEX5H0s0qX8J+e8YZfqRIFW?=
 =?us-ascii?Q?Q6i2As1shDW4imVqHo4mi1iAATboxgpkiaPlg1kUkk+3KwevK/q0L2VKAkGO?=
 =?us-ascii?Q?7yvSavO+ZGNPqYwNLOlceN7FY2EZkR6d2A2iIAofq7uE78YhCjDrh3PhzN+M?=
 =?us-ascii?Q?6+Ee61WdsbyOG2M11XqPxUe0vsexgCG9yEI2aHqXUC9fXTmIKBOHg06LFsFk?=
 =?us-ascii?Q?Cl+Z0QFzC/ck5AExfmz691mesNfF3iCAA8aRW+v9LB2l6SWjGVwR1P4La44J?=
 =?us-ascii?Q?sNmVm7OUICF8q9cFVIvc5n+Zq6BPnxfKw47UJcSWYZx0eMtJ5pkwuJId49bX?=
 =?us-ascii?Q?5qkCp/8He9BJXbP6FXZxPKssaa/Nb+wesGPiZyolWX+hyj3ZQNTDvTENK3nS?=
 =?us-ascii?Q?nL1qq6XsKhaXr6QSv5nWEUQJisjCB9rZVX7Ihq762n21YrC6cclx5lHBlF/M?=
 =?us-ascii?Q?f7EaU28e7uB1PwWhwx487n6yktii0bucECbDKPELu+oIdOiQ8A81XutKoKsX?=
 =?us-ascii?Q?THMb84dgMhaXF3ltc0LxTZ0Gyhn26hWhpDBONiJ9Nrsgmh9fduk+FwELXnWQ?=
 =?us-ascii?Q?g+/itogmvf3nnHIGYwv1Aw4eOOIFkbHUE4tGDp4xuwRE+1658Z9N1Qqj44/T?=
 =?us-ascii?Q?YL+hKdUkmSfrMg+Neml9RhyL7Fr8nMevLxTxzzWYokHTfMWkrE4/xs2VeVBe?=
 =?us-ascii?Q?tS+6depPalZjk6sLhlFINrvEdM2hWVkcjssTaKomMV1kVAFbpY9GBkMaGp/g?=
 =?us-ascii?Q?EIfU5aSQalEFfiy6LfaWJLwdhZyxYivx4tGLY57hdmZVEAQDOJUK9reXqFPn?=
 =?us-ascii?Q?zNhIiExmrUvQZpy7IvQJbRRKehtiWg7QfQo2nHce2VBy4fH9J12xJ+sS0U+q?=
 =?us-ascii?Q?dnqTYhUIgP9hZKrZOi3JgaajNXT6kBs+G+evTFSCIhK0eHL2N/o8giZNeCCV?=
 =?us-ascii?Q?jaJ7wnqunEIj/DAp770UV1KplVSfMBcEFUyWM5QSCuPQMRVNDdUZ24qoWasM?=
 =?us-ascii?Q?x0ZhaLd72GroESZHuOetWAgt3Lpjglp/XBaoDKUMFaG3tKd8BtnXcgJnF6R4?=
 =?us-ascii?Q?9Lsmf3kCgxuGzR9yP0RzuwiWh++80bMR/wQxgPlRFwPlQl6vC7UtZPWLJHJv?=
 =?us-ascii?Q?GqNFbhDaIOiyFqLEZeWasFjjCmPpVM1arNNzbjZ0ulMD5vN4eQa6QyCqmVUh?=
 =?us-ascii?Q?9Hh9DNx/b7x4AA/O8xegGKeZGR3RNuYnHE0llqqWD5jC2d9gVNYb0GmDbzrq?=
 =?us-ascii?Q?jg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYWPR01MB8775.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f4dc40c-f2b4-47b9-8dff-08daf7d64a49
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 15:28:16.7430
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H0UYvD7mIsoqVXkvck272cYlXeeNrjYuPvdwASq3G4fSuQZ2F3V0fp/3aQorxsd8sa/hkLX0XI24dbeizVIakM3tYX1khsriaVyYKXaSLE8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB7841
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi All,

It looks like this patch has been reviewed by both Guenter Roeck
and Geert Uytterhoeven, any chance that it can be taken for v6.3?

Thanks,
Fab

>=20
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>=20
> On RZ/Five SoC it was observed that setting timeout (to say 1 sec)
> wouldn't
> reset the system.
>=20
> The procedure described in the HW manual (Procedure for Activating
> Modules)
> for activating the target module states we need to start supply of the
> clock module before applying the reset signal. This patch makes sure we
> follow the same procedure to clear the registers of the WDT module, fixin=
g
> the issues seen on RZ/Five SoC.
>=20
> While at it re-used rzg2l_wdt_stop() in rzg2l_wdt_set_timeout() as it has
> the same function calls.
>=20
> Fixes: 4055ee81009e ("watchdog: rzg2l_wdt: Add set_timeout callback")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  drivers/watchdog/rzg2l_wdt.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c
> index 974a4194a8fd..ceca42db0837 100644
> --- a/drivers/watchdog/rzg2l_wdt.c
> +++ b/drivers/watchdog/rzg2l_wdt.c
> @@ -115,25 +115,23 @@ static int rzg2l_wdt_stop(struct watchdog_device
> *wdev)
>  {
>  	struct rzg2l_wdt_priv *priv =3D watchdog_get_drvdata(wdev);
>=20
> -	pm_runtime_put(wdev->parent);
>  	reset_control_reset(priv->rstc);
> +	pm_runtime_put(wdev->parent);
>=20
>  	return 0;
>  }
>=20
>  static int rzg2l_wdt_set_timeout(struct watchdog_device *wdev, unsigned
> int timeout)
>  {
> -	struct rzg2l_wdt_priv *priv =3D watchdog_get_drvdata(wdev);
> -
>  	wdev->timeout =3D timeout;
>=20
>  	/*
>  	 * If the watchdog is active, reset the module for updating the
> WDTSET
> -	 * register so that it is updated with new timeout values.
> +	 * register by calling rzg2l_wdt_stop() (which internally calls
> reset_control_reset()
> +	 * to reset the module) so that it is updated with new timeout
> values.
>  	 */
>  	if (watchdog_active(wdev)) {
> -		pm_runtime_put(wdev->parent);
> -		reset_control_reset(priv->rstc);
> +		rzg2l_wdt_stop(wdev);
>  		rzg2l_wdt_start(wdev);
>  	}
>=20
> --
> 2.34.1