Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <05a28cc6-0070-9117-368e-ade7561f6727@kernel.dk>
Date:   Mon, 16 Jan 2023 09:14:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] block: check disk flag before setting scan bit
Content-Language: en-US
To:     wangjie <wangjie22@lixiang.com>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230116083832.27305-1-wangjie22@lixiang.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20230116083832.27305-1-wangjie22@lixiang.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/16/23 1:38?AM, wangjie wrote:
> No need to scan partitions for disk who has set flag GENHD_FL_NO_PART in
> driver code. In disk_scan_partitions function, the same checking is
> existing, so we believe this change is reasonable.
> 
> In our case, some virtual block devices are not managed by GPT, then scan
> partition operation is not a must. So we set GENHD_FL_NO_PART flag in
> driver intended to avoid partitions being dropped/added.
> But GD_NEED_PART_SCAN bit was still set by bdev_check_media_change, which
> causing problems here.
> 
> Signed-off-by: wangjie

Signed-off-by is in the wrong format, and the whole email is badly
mangled...

> ????????????????????????????????????????????????????
> ????????????????????????????????????????????????????
> ???????????????????????????????

This didn't quote well, but the original is also useless. You do realize
you send this email to a public list? Please get rid of it.

-- 
Jens Axboe