Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d1244b25-9ae6-33b0-e6b7-3e3c463b1224@kernel.dk>
Date:   Mon, 16 Jan 2023 09:13:27 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v3 07/14] blk-mq: make blk_mq_commit_rqs a general
 function for all commits
Content-Language: en-US
To:     Christoph Hellwig <hch@lst.de>,
        Kemeng Shi <shikemeng@huaweicloud.com>
Cc:     dwagner@suse.de, hare@suse.de, ming.lei@redhat.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        john.garry@huawei.com, jack@suse.cz
References: <20230111130159.3741753-1-shikemeng@huaweicloud.com>
 <20230111130159.3741753-8-shikemeng@huaweicloud.com>
 <20230111054520.GA17158@lst.de>
 <c51cbadb-bfd8-5f26-6bc3-5ad975b5db39@huaweicloud.com>
 <e2ba1495-e9a8-8dfc-4eee-d9a2984bc0d2@huaweicloud.com>
 <20230116160958.GB23434@lst.de>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20230116160958.GB23434@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/16/23 9:09 AM, Christoph Hellwig wrote:
> On Mon, Jan 16, 2023 at 09:07:00AM +0800, Kemeng Shi wrote:
>>>> Why?  I think always having the trace even for the commit case seems
>>>> very useful for making the traces useful.
>>> I think unplug event more likely means that request going to be sent to driver
>>> was plugged and in plug list. And the current code do only trace unplug event
>>> when dispatching requests from plug list. If so, would it be better to add
>>> a new event to trace commit?
>> Hi Christoph, which way do you prefer now? Keep unplug event consistent to
>> trace commit of requests from plug list only or trace all commits with
>> unplug event. Please let me know and I will consider it in next version.
>> Thanks.
> 
> To me always having the trace feels more useful, but let's see if Jens
> has an opinion on it.

Agree, that is probably the saner option.

-- 
Jens Axboe