Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Jerry.Ray@microchip.com>
To:     <olteanv@gmail.com>
CC:     <andrew@lunn.ch>, <f.fainelli@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <linux@armlinux.org.uk>, <jbe@pengutronix.de>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v6 2/6] dsa: lan9303: move Turbo Mode bit init
Thread-Topic: [PATCH net-next v6 2/6] dsa: lan9303: move Turbo Mode bit init
Thread-Index: AQHZJHABkK7DClBc80KHKpZcwORjQq6eaqUNgAL12sA=
Date:   Mon, 16 Jan 2023 18:03:02 +0000
Message-ID: <MWHPR11MB1693247B3AA9D532B1B0E1ADEFC19@MWHPR11MB1693.namprd11.prod.outlook.com>
References: <20230109211849.32530-1-jerry.ray@microchip.com>
 <20230109211849.32530-1-jerry.ray@microchip.com>
 <20230109211849.32530-3-jerry.ray@microchip.com>
 <20230109211849.32530-3-jerry.ray@microchip.com>
 <20230114204943.jncpislrqjqvinie@skbuf>
In-Reply-To: <20230114204943.jncpislrqjqvinie@skbuf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?42tee2nC5UMFQNPHiVq75xCbSRR2XoPaPOpTtZ7fLej81s9Q14vH+qiPslL2?=
 =?us-ascii?Q?qTqY0AZ0w4O0Hh7OsbSjiijneEs3FxcnjT+kRrP79DOwHI19vHV3T7TZRIDe?=
 =?us-ascii?Q?1AsdjM45NGQiieSv6ZeF5Yp6SQX8bXxo6M8fKDa6jo7YiAFLf7r9LMG+CB9/?=
 =?us-ascii?Q?qA8OynFXrQaq0sZuYyj2j+W1ulxAsAIujzd7tQukiOwrK4z3Hfa+O8/mLOiA?=
 =?us-ascii?Q?Bu0wvxLWQCTNQnFRa5p+YiAg+IjonSw4nw7YukTQrPVcKdyDOneH15E5ZIag?=
 =?us-ascii?Q?DhjOBv+L8YysxbhrrzgM8SaaZ17bR+uqeQoeMSbTlqYuKGxFjXY9kExfu5FH?=
 =?us-ascii?Q?ZWT1BlqohvNiGMjSoPZQUNq5ZwxZ8JT4/9d7afA5T3OikYK6CCfRdCTJOaNn?=
 =?us-ascii?Q?AflIY43sxYP0JEDWF4Oi4NcJkQRIX0qAePzOrJXA0xLP2b8wP7LeQeZNWO39?=
 =?us-ascii?Q?sWqYQl4ZXLvjmJC+rQA3zsmXyJwSGs1L/CBoGdhwTDC2edLdqaJDfUIu9gRy?=
 =?us-ascii?Q?AF3ScdUT4jWM+5Z3h4dqc/aAP8PcsoCmB7F8t2dtdmeRcN0qlAMYj0gCs6Pw?=
 =?us-ascii?Q?+FKKC1oEb2T5PsOxQQOUSXrnEqvqL8XCQThpixr5sTS+716drYE8ZXrXH3JH?=
 =?us-ascii?Q?5jMmKa4Hk3lU6J0fVvRdRn43yUy5c342kdBKqRPqIJbgsJEOy0iN3IOKhkWJ?=
 =?us-ascii?Q?K5Yq6+F0Z6VG3lQtiC9qnWQLn321T3qinxw6YQGnoqmAoofI5RZPsBQR+Uf1?=
 =?us-ascii?Q?hKSAq7uw1aAxZuK2UhY3iZzQgu8Wqi/TSp53STtRtqwDXtO4nNQGJYpuhdPk?=
 =?us-ascii?Q?9A14znCjIzHqHgrptT9u+CneprsmmFa6fprvG3LURINb0ZBnzB7G98jgWPUY?=
 =?us-ascii?Q?dUbFWxxcxUJJ5D2bFUKD2h5XVSSfOleYGKcksccO07Uhow7CQKBzTDL8FG5T?=
 =?us-ascii?Q?6fqDxz3oreCu2bVCZT1C26NjRaDoy8jblGSOOsKZ6SRc+YZ0nUxmnHPros3d?=
 =?us-ascii?Q?ZzFXUrkGBKgJbjnYM7ILj3GoZ6xCU0G89SNlL1jswb7DM5uP3W+hHCshbxNy?=
 =?us-ascii?Q?+cRsNFlkFnaSrqHFz/s9kX7MZKmlMOW3SW6IVblFLxkVLjt7N9H5zQlDySsx?=
 =?us-ascii?Q?gifPghzQS+T9NW6pD5bFz5Ffr8FwQo67UxO6tlrqqT0xhNOJ57tW49xhfuA8?=
 =?us-ascii?Q?RSYLJm+e44Ff60lgGdCKPRrn9fTmLYupfJFJJLRDOPgvrDlgIixbikdJ8AOi?=
 =?us-ascii?Q?HpyJ654IHylFLWQ/kCqS5rOdD55vDpn5PrdfQMNCLl259A0hX/5l3NG2WuFh?=
 =?us-ascii?Q?XK+P2J4Do9/z4FMobCp5hPQhctk6VpQdhcuJka11cRiy100ikgjdSVM6TbUg?=
 =?us-ascii?Q?wV0657ED70pkdgyVXGJ4zaj2ee1N9+dpsfvDrEwUUEN8i+3xmRLOHrGpeg5l?=
 =?us-ascii?Q?skW944amLKnVA1wIeqtFVtq7BQAaQOY3BcTiyT/0wMMN7MNJW4/KmnSNWW1w?=
 =?us-ascii?Q?cUWyHJbpl48GbsORDHvJR+M6UC2ATL1VrOftG01fFr4GY8S857DvvJS6l8kO?=
 =?us-ascii?Q?xFWsb6DkQ3QvySlqkSy1uwsHwJG1e6AUIarvhd0Z?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1693.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fb20dc5-25de-4bc3-b771-08daf7ebe90e
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 18:03:02.5465
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZiCxJJr2DhVI3riHjFi77Zxt4Tn04+xDC+THr1CLrVjqSavUEl3FPgVbHlCmGfE8XxgYlRjwGMn5YaM1/Pztjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7679
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> > In preparing to remove the .adjust_link api, I am moving the one-time
> > initialization of the device's Turbo Mode bit into a different executio=
n
> > path. This code clears (disables) the Turbo Mode bit which is never use=
d
> > by this driver. Turbo Mode is a non-standard mode that would allow the
> > 100Mbps RMII interface to run at 200Mbps.
> >
> > Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> > ---
> >  drivers/net/dsa/lan9303-core.c | 15 ++++++---------
> >  1 file changed, 6 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-c=
ore.c
> > index 5a21fc96d479..50470fb09cb4 100644
> > --- a/drivers/net/dsa/lan9303-core.c
> > +++ b/drivers/net/dsa/lan9303-core.c
> > @@ -886,6 +886,12 @@ static int lan9303_check_device(struct lan9303 *ch=
ip)
> >               return ret;
> >       }
> >
> > +     /* Virtual Phy: Remove Turbo 200Mbit mode */
> > +     lan9303_read(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, &reg);
> > +
> > +     reg &=3D ~LAN9303_VIRT_SPECIAL_TURBO;
> > +     regmap_write(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, reg);
> > +
>=20
> Isn't a function whose name is lan9303_check_device() being abused for
> this purpose (device initialization)?
>=20
I will move this into lan9303_setup.

Regards,
Jerry.

> >       return 0;
> >  }
> >
> > @@ -1050,7 +1056,6 @@ static int lan9303_phy_write(struct dsa_switch *d=
s, int phy, int regnum,
> >  static void lan9303_adjust_link(struct dsa_switch *ds, int port,
> >                               struct phy_device *phydev)
> >  {
> > -     struct lan9303 *chip =3D ds->priv;
> >       int ctl;
> >
> >       if (!phy_is_pseudo_fixed_link(phydev))
> > @@ -1073,14 +1078,6 @@ static void lan9303_adjust_link(struct dsa_switc=
h *ds, int port,
> >               ctl &=3D ~BMCR_FULLDPLX;
> >
> >       lan9303_phy_write(ds, port, MII_BMCR, ctl);
> > -
> > -     if (port =3D=3D chip->phy_addr_base) {
> > -             /* Virtual Phy: Remove Turbo 200Mbit mode */
> > -             lan9303_read(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, &ct=
l);
> > -
> > -             ctl &=3D ~LAN9303_VIRT_SPECIAL_TURBO;
> > -             regmap_write(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, ctl=
);
> > -     }
> >  }
> >
> >  static int lan9303_port_enable(struct dsa_switch *ds, int port,
> > --
> > 2.17.1