Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Jerry.Ray@microchip.com>
To:     <olteanv@gmail.com>
CC:     <andrew@lunn.ch>, <f.fainelli@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <linux@armlinux.org.uk>, <jbe@pengutronix.de>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v6 5/6] dsa: lan9303: Port 0 is xMII port
Thread-Topic: [PATCH net-next v6 5/6] dsa: lan9303: Port 0 is xMII port
Thread-Index: AQHZJHAfAi0Nk7E6jEC4WJFxnKf0Pa6ea7yAgAL1iGA=
Date:   Mon, 16 Jan 2023 18:05:37 +0000
Message-ID: <MWHPR11MB16933112707D97121C67E5C5EFC19@MWHPR11MB1693.namprd11.prod.outlook.com>
References: <20230109211849.32530-1-jerry.ray@microchip.com>
 <20230109211849.32530-6-jerry.ray@microchip.com>
 <20230114205351.czy2fkfrulrl4w6k@skbuf>
In-Reply-To: <20230114205351.czy2fkfrulrl4w6k@skbuf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wDSiNEQokKIP8EYRWDP0WrWZXnmIFf+nXmt4YGBR686eD656g67PIMDsWt9J?=
 =?us-ascii?Q?gTVnIGWeGqE91RnfzkvIjyCrSJnlBhk27q10WuK++LOJ5i+UFXyZjAHzppYg?=
 =?us-ascii?Q?mUH+Dr3ERmrKdpcdRbA1TfOU8yQQUpmvZVeXnzL6ZP+ej3GpIxd3fnQPBlJR?=
 =?us-ascii?Q?yyWE5rfVlA1wFegkjP5u1UbLrQRpRhe7TQmx2zylEU22MUnznc0RUYNCUEO8?=
 =?us-ascii?Q?DDubQ/4Lse9xMYaR2zvBbNp0qjTvSjMf9IE4a9G75d5GhHfiZhuNSFouLhUN?=
 =?us-ascii?Q?We6Id2Za6sk4sYf4czzyy83mJN69pAMtyNbnAL4w2JxWZhYn/7OPBFJHmiQD?=
 =?us-ascii?Q?56MFBkNhPS2/bo0W9MePLEtvxFD2sA84I5EEydlZnuShrFhM1XrKK0xBSk4R?=
 =?us-ascii?Q?2okRPkAjFB/BO9hZpJTUJsO9Il+FICgXvU4hrQ6+kvYYYSVcqKtgpyoKBPEP?=
 =?us-ascii?Q?kP/VOmrfq0n06cTFt95kkSIg4i+4xK1VrfYG0uZxFmTUQnAaKpFZwIlGGtEH?=
 =?us-ascii?Q?I7WRvJdt3tDx63JVXkzpycz2wZTbCMqvvy0ZkfsXdC9Mq1STv7/rW+ec8b6Y?=
 =?us-ascii?Q?abcS3zuq3T4oHrYMG91Zl3pc0BFlzvn1WkqukhmM61QWNAjGw5aZdSdvUjDn?=
 =?us-ascii?Q?8yoJ2KlOmDCE9fMWflr+2+WnzZ35YZuyuC8weRGp0yJUQ56EWWd+I9D3NEj4?=
 =?us-ascii?Q?v2jgUxxGvtGhRM8To+SLS3ogMR8DeuyEo2AGHcF1hMwfraNyWU85s8yyJHbC?=
 =?us-ascii?Q?a2DKCgcvDEEH2+2sGzdQRhC4Aw++v6l+V2xk4QZo7GPHeDLrvpIZsZQqg9Xo?=
 =?us-ascii?Q?L52U4Ebd+3kg2+l32pKLhWHUkJ7CrILOv+OpDhOtskWHVg5s1vEBtEPhQSv/?=
 =?us-ascii?Q?mf4d9kBhP61v6Ly20lIzK/cam2BW902iaGHdScQTKtfMfx1R2X3r/Qjz4lIH?=
 =?us-ascii?Q?+hZ01oQm0EK4HBLDz/iKkbMq1GYz3MAqGxqKbX8cXYk6jzBFwncy3C+IXLrh?=
 =?us-ascii?Q?OigbOXiGmgFA1TAPcFvajzHmChhNKy6Ram52pVWh97hjdhLQ9Ty8K9ZKhuxI?=
 =?us-ascii?Q?RCRtsk7xlnvlt9GYV1eKQy8mWde/Ktp+kiqTZOkDZPTt6acOQqZe8b1eHBr6?=
 =?us-ascii?Q?YpcZcrDnBIKEwqcn0bBWy4Jo+B/AsHrfAntquS89r7ohmuEKia2wnrtPkhxT?=
 =?us-ascii?Q?Sp7EjynSOg2Q7GFquTtVk6PeOosLiB/yzHMKGhIsH7SyfvScHnk1ilYN0Aqp?=
 =?us-ascii?Q?PJUWzJeSeB0ZvVnti94cSynPoVhPC4flwiGMQNzVHcqlY/XD23wukk0tVH3R?=
 =?us-ascii?Q?1z9LF7ooTuCJ3UNXG4PnL9ClcCV10QCCpnC3YqeHXhocDRgfKg/oRNf7qJX9?=
 =?us-ascii?Q?JwjYvNYuRwXkAsgXcXjv3SPoPDG/iXCPqVVlGEvrAYJNwTCDq1kTN/qE/LNm?=
 =?us-ascii?Q?4zPt4sbTfkusFU6z1IhZDihxyF8dZCJelwqwhUhvOiFFLVsIHGKRlxQb+kTJ?=
 =?us-ascii?Q?yH0puubS+qO2vYUvwomDgB/fIrXcoz+H8rlWtWJLpKEedwLFfnseqt5HqhQJ?=
 =?us-ascii?Q?wJYYqf6sEj0EcnF8bVDgDKOLebRyizs4fjvdkbnD?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1693.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14750465-8ec7-428a-c543-08daf7ec4551
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 18:05:37.3207
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wQ9hnEdlq1TasGiMBypK1FEqr8+Y4U7QtwPNpGhvtzMjHK8UPcB7JD+TThhhk2EtC4x5KF5DGBvWHLUXxf5rHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7679
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > In preparing to move the adjust_link logic into the phylink_mac_link_up
> > api, change the macro used to check for the cpu port. In
> > phylink_mac_link_up, the phydev pointer passed in for the CPU port is
> > NULL, so we can't keep using phy_is_pseudo_fixed_link(phydev).
> >
> > Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> > ---
> > v5->v6:
> >   Using port 0 to identify the xMII port on the LAN9303.
> > ---
> >  drivers/net/dsa/lan9303-core.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-c=
ore.c
> > index 792ce6a26a6a..7be4c491e5d9 100644
> > --- a/drivers/net/dsa/lan9303-core.c
> > +++ b/drivers/net/dsa/lan9303-core.c
> > @@ -1063,7 +1063,11 @@ static void lan9303_adjust_link(struct dsa_switc=
h *ds, int port,
> >  {
> >       int ctl;
> >
> > -     if (!phy_is_pseudo_fixed_link(phydev))
> > +     /* On this device, we are only interested in doing something here=
 if
> > +      * this is an xMII port. All other ports are 10/100 phys using MD=
IO
> > +      * to control there link settings.
> > +      */
> > +     if (port !=3D 0)
>=20
> Maybe a macro LAN9303_XMII_PORT would be good, if it was also
> consistently used in lan9303_setup()?
>=20

Agreed.  As I add more devices that have different capabilities, this will
change. I was hesitant to add this logic now as it is uncalled for until
multiple device types are supported by the driver.

> >               return;
> >
> >       ctl =3D lan9303_phy_read(ds, port, MII_BMCR);
> > --
> > 2.17.1
> >