Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp3651769rwb; Mon, 16 Jan 2023 10:52:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXtRUH5dgqJXS4SI2rmkJzt0p7E3s8N5KurC1/k187gCDPnv2GMG/xfo+13DMJWC7GiGdYen X-Received: by 2002:a17:907:2b1f:b0:870:1550:82bc with SMTP id gc31-20020a1709072b1f00b00870155082bcmr9310ejc.55.1673895132306; Mon, 16 Jan 2023 10:52:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673895132; cv=none; d=google.com; s=arc-20160816; b=tbgS/RnBgTCuLo9kLE4c1bwlK7goUByDmz+ecfj161GUOZGPpaHnbEUdG4IxOu0E0g cmGAuTEz/gNEKcrAAQE74Jyds+CQ3vty9PE1zFUQvP2jMNx2Vxl+o3gdMGwU+zLJDUAc Ap64UE9fO2o+rwE89Cp1KFMUZtriDFxZj+GxXsvxEgIY0K2yjGzpsmEutaigUL3yceQk jCtjoiMj5DXVg6ySbDXRJT/QL27dhZkSOF0jk73kaWcB165J05MKwrciODb3z3wTvhGs ajy0UMZB3Kb/ZhUwuWp1f4NwrNUHbpzUJI6BY8ASbZx6PbhrOhPPtoM66uFD7tSylZbF RF5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=H7m//z6+GefngOX6iJLku3GLGnd3MjXpKpNTxDDHVRg=; b=f6JFp4tZ4D86xHhkpgRSemtxuKMQLFdF/xOGyWE70dC0eVv8108uFB+FjKB9PkHpeB Zh7lCJzZDRgWUW8Bi5KsAQMzZQyEg33GqDHn8Y29z8ZWslNAv1BYysPmzLhOTVCP0rD7 2mRyUxMLzU0uKKCkle9M9F/BNdmXptDmVYnCSi8NnIomDxDCWd+9/OOSGguW0rTIGBxd Ejrr2a6x1rRb6PISgwFStsLSMUZGHZ4Tyu49ffEqAUIguocUl+8A190ytuSKxD4kVkHK BbKDE+NNGN8jBJLS5KFblWFkaoxrps9jHJQ9PGDw+rtKUUBLJorrpDivPB8K8QRPk1jF HJWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KDR7LYGf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw16-20020a170906479000b0078d9d67841fsi6692358ejc.400.2023.01.16.10.51.58; Mon, 16 Jan 2023 10:52:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KDR7LYGf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232527AbjAPSD2 (ORCPT + 50 others); Mon, 16 Jan 2023 13:03:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232168AbjAPSCq (ORCPT ); Mon, 16 Jan 2023 13:02:46 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E284279B4; Mon, 16 Jan 2023 09:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673891296; x=1705427296; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=TNgX0mCKMCl8fMMol+o+7jJ7FmDZK6TmzIACPGFpF3U=; b=KDR7LYGf4oSJFO5wBYvtH5i1U9WcypcD43JTqC5R9YGc59wOuWv8BhN4 nxcAyQpvuxQtjqr8vLQalrCScPvoPLpu4MYDNbY6W0zZI5RNIwgQMlljR KqsrOLC1vLoDZfrSe1fQmYUglyK3nU6r57rcBlEpqAcEYs0JOHvmBbjvM upNE/aAEq99TKdfD9YVnEEl/pw4N10EdjCQ6wEgqndksSMZpHheAVdX1h 6UeGRA2rH0hryso3Q2Rt5u8k+sTC3iJbf0CLRB8tuoLVD5qb6gYQaq5mw zwEFhA/1JdnI+tvGM9p50k9iNGpRROcA8KoIG9mfLGnfTQ7eQZ2uGNeoG g==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="312366869" X-IronPort-AV: E=Sophos;i="5.97,221,1669104000"; d="scan'208";a="312366869" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 09:48:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="659114269" X-IronPort-AV: E=Sophos;i="5.97,221,1669104000"; d="scan'208";a="659114269" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 16 Jan 2023 09:48:12 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pHTac-00ACas-0G; Mon, 16 Jan 2023 19:48:10 +0200 Date: Mon, 16 Jan 2023 19:48:09 +0200 From: Andy Shevchenko To: "Limonciello, Mario" Cc: Jan =?utf-8?B?RMSFYnJvxZs=?= , Borislav Petkov , Borislav Petkov , Hans de Goede , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "jarkko.nikula@linux.intel.com" , "wsa@kernel.org" , "rrangel@chromium.org" , "upstream@semihalf.com" , "M K, Muralidhara" , "Chatradhi, Naveen Krishna" , "Ghannam, Yazen" Subject: Re: [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access Message-ID: References: <33d5cc27-474b-fdec-a6b0-84ac16f7d386@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2023 at 04:22:09PM +0000, Limonciello, Mario wrote: > > From: Andy Shevchenko > > Sent: Monday, January 16, 2023 06:39 > > To: Jan Dąbroś > > On Mon, Jan 16, 2023 at 11:19:00AM +0100, Jan Dąbroś wrote: > > > > Make init_amd_nbs() arch_initcall_sync() so that it executes after PCI > > init. > > > > > > I described earlier in this thread why such option is not working - > > > let me quote myself: > > > > > > It's not enough for running init_amd_nbs() to have only > > > pci_arch_init() done. We need the pci bus to be created and registered > > > with all devices found on the bus. We are traversing through them and > > > trying to find northbridge VID/DID. Due to the above, we need to run > > > init_amd_nbs() only after acpi_scan_init() that is invoked from > > > acpi_init() which is registered as subsys_initcall. That's why the > > > trick with switching init_amd_nbs() to arch_initcall_sync will not > > > work. > > > > > > We have a kind of chicken-and-egg problem here. Or is there something I > > missed? > > > > > > I wonder if there is upstreamable option to control order of the > > > drivers' init by forcing link order? > > > > But what exactly do you need from North Bridge? Is it only its existence or > > do you need to have fully instantiated PCI device (if so, why?)? > > There is a need to be able to write and read PCI config space. So, it's available even on early stages, are there some specifics why it can't be done using the respective APIs? -- With Best Regards, Andy Shevchenko