Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Jerry.Ray@microchip.com>
To:     <olteanv@gmail.com>
CC:     <andrew@lunn.ch>, <f.fainelli@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <linux@armlinux.org.uk>, <jbe@pengutronix.de>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v6 2/6] dsa: lan9303: move Turbo Mode bit init
Thread-Topic: [PATCH net-next v6 2/6] dsa: lan9303: move Turbo Mode bit init
Thread-Index: AQHZJHABkK7DClBc80KHKpZcwORjQq6eaqUNgAL25eA=
Date:   Mon, 16 Jan 2023 18:06:30 +0000
Message-ID: <MWHPR11MB1693C77544D2AF002A58DD68EFC19@MWHPR11MB1693.namprd11.prod.outlook.com>
References: <20230109211849.32530-1-jerry.ray@microchip.com>
 <20230109211849.32530-1-jerry.ray@microchip.com>
 <20230109211849.32530-3-jerry.ray@microchip.com>
 <20230109211849.32530-3-jerry.ray@microchip.com>
 <20230114204943.jncpislrqjqvinie@skbuf>
In-Reply-To: <20230114204943.jncpislrqjqvinie@skbuf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LZUclFjZuxTIYLCL9gKiGFBZdpf/4oHU5kKfSaMlAvB89TnHwL4z2/Xpr42G?=
 =?us-ascii?Q?Pa1hybZTQfSiyI8LrbxppFZM79jHZlG6kYWKNIqdQLkUu80HkwkYEYOzd7rR?=
 =?us-ascii?Q?gOpKEkZXj4SD+N3PFHulwG39RUY31GlPSO/MQHMoy74G9+yHjwmsvXVfA2bu?=
 =?us-ascii?Q?zsNAxFgTszuR0TsqySwQZh2MvcLnByfmzWEZzYqzPv+uI/74GNHsIZNzoJ2S?=
 =?us-ascii?Q?8neHYo4DhfqRpE0cA5O1iENh0zsMwo7aCqxbjvonhW1/RqFENqRWX/iWdbUx?=
 =?us-ascii?Q?n1YSe5BJM6WeauqaEkphbfkDtVyj+7iJ+EyD5G7URYOnL4Ev8f7egwUqGdTe?=
 =?us-ascii?Q?r817NtEg7fFRUstjwYED19/YejMvf08lCwYNYSkWbqPSmRkeRiz9TeKpevd/?=
 =?us-ascii?Q?XR1Q4SaNGldJWCMxshF2KirfdulTJuFwfa9yLjsltPZj1KmEedkbtcPGHirM?=
 =?us-ascii?Q?D8iELcmv7fcuaeAxY1Z5j60NRp3h5P0pt5Gxaz1bY6SmpRSwyuUB99vJKX+Y?=
 =?us-ascii?Q?Xoi+nJ1s92vkyQ68pxGGOG79hUzHS5e14lucI+CxPIXqLG/xOqXcVeJsdbag?=
 =?us-ascii?Q?0n3rBDa0aoHGMGUug4M5a+8ZYN/KQPuqY25UsiJA/Rf8Er/Cyp+OXNawQSKP?=
 =?us-ascii?Q?ru9HJXWIUejRG1PdjPS+Qj0UE5oYqUKZ6gEvJj4b5r8PmN1GjLS6rBH5eYhP?=
 =?us-ascii?Q?mWge51d3qfE08jIXFxY1TtqwlscbIQj0xUIjmviiXXGPPygBpkoLSEDeIVdK?=
 =?us-ascii?Q?jmQ6YJvdxFf/M5L3sxeluKXT+y+nKaVTKcqX+LqBb9o1+IzfA/yxZJ9abAFt?=
 =?us-ascii?Q?8N4FZOFpEizU9IFMM1bf106DdXjpq55xUxsdhbJJEFBEGhltrl+Eaq2JWrXr?=
 =?us-ascii?Q?iz8Z3TH5IfHIe5JA/N5sJ8NTwQmVIR6WGDFFizFXMORNWsOo7eFT4KUaIzKb?=
 =?us-ascii?Q?1uLE4xY9snwDKjP72avrRjf6oD8SdinRJpEfAZilWl3nF2F3WHQ2V/wHLpNW?=
 =?us-ascii?Q?CJIYeghud3aigdLDXpDGV8kSt93TBWgWd7azykxhAmMWFp2aB5yT/umSjZqs?=
 =?us-ascii?Q?2o9/pEjjWcTzDZWOeouZ6t1C1QN4xWO4Hv/0mYIKa6JJTDZ6xAcjbZtd8pfs?=
 =?us-ascii?Q?MKJcTL3oEf8u62EfKi9hU+nOPH+93jE5VjZiK6CsRtu0fxBqwAsxYi6cb8KX?=
 =?us-ascii?Q?6T4dZty2KjnDVREaBKex8Hhxm/eKyhXH2kEmvU33CIz9ApfQKGIlaQagHQm4?=
 =?us-ascii?Q?ZnhKFkUg/NOPgpy2NDL3s3xeKGZ7O6B88TXTvoFZEOzKSrx7ucw4BAVOqOVV?=
 =?us-ascii?Q?8oWzoxhT2A8bkOLREXiCoRsyg+6NhSHTxdfa5KW9oPyhyRFyW3HxOOK4gkvJ?=
 =?us-ascii?Q?ITREeGaYJmLxw3e8+fQIwq7Hs+o91jhIorViaIO77l4DZWfn9jzc9L35fpFX?=
 =?us-ascii?Q?PBnofQAjvkqu0uhmysEPxOIm4/v7RdNuCnHT3o/E1XhNgHzlvfalihULYc6a?=
 =?us-ascii?Q?OINkDrARTSYIRAgbcw+QUUFsgkmMzoXN7DqtR5OsIEHaUmpfHDWsO0fRwALu?=
 =?us-ascii?Q?DnGrU5Hhzh22Zzk4gcIeWey7rJk4M5opxqRVK/QK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1693.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 052206e2-9d69-4018-552d-08daf7ec6500
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 18:06:30.4584
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: K2cZN0JSaUqv0HpETskz8X9i0h10a8GVWSVIjFFx8kYXWyGFWrAyl1Z22VdDMZS/PzkLDypBan+eOrjm9ldBIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7679
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > In preparing to remove the .adjust_link api, I am moving the one-time
> > initialization of the device's Turbo Mode bit into a different executio=
n
> > path. This code clears (disables) the Turbo Mode bit which is never use=
d
> > by this driver. Turbo Mode is a non-standard mode that would allow the
> > 100Mbps RMII interface to run at 200Mbps.
> >
> > Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> > ---
> >  drivers/net/dsa/lan9303-core.c | 15 ++++++---------
> >  1 file changed, 6 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-c=
ore.c
> > index 5a21fc96d479..50470fb09cb4 100644
> > --- a/drivers/net/dsa/lan9303-core.c
> > +++ b/drivers/net/dsa/lan9303-core.c
> > @@ -886,6 +886,12 @@ static int lan9303_check_device(struct lan9303 *ch=
ip)
> >               return ret;
> >       }
> >
> > +     /* Virtual Phy: Remove Turbo 200Mbit mode */
> > +     lan9303_read(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, &reg);
> > +
> > +     reg &=3D ~LAN9303_VIRT_SPECIAL_TURBO;
> > +     regmap_write(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, reg);
> > +
>=20
> Isn't a function whose name is lan9303_check_device() being abused for
> this purpose (device initialization)?
>=20
I will move this into lan9303_setup.

Regards,
Jerry.

> >       return 0;
> >  }
> >
> > @@ -1050,7 +1056,6 @@ static int lan9303_phy_write(struct dsa_switch *d=
s, int phy, int regnum,
> >  static void lan9303_adjust_link(struct dsa_switch *ds, int port,
> >                               struct phy_device *phydev)
> >  {
> > -     struct lan9303 *chip =3D ds->priv;
> >       int ctl;
> >
> >       if (!phy_is_pseudo_fixed_link(phydev))
> > @@ -1073,14 +1078,6 @@ static void lan9303_adjust_link(struct dsa_switc=
h *ds, int port,
> >               ctl &=3D ~BMCR_FULLDPLX;
> >
> >       lan9303_phy_write(ds, port, MII_BMCR, ctl);
> > -
> > -     if (port =3D=3D chip->phy_addr_base) {
> > -             /* Virtual Phy: Remove Turbo 200Mbit mode */
> > -             lan9303_read(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, &ct=
l);
> > -
> > -             ctl &=3D ~LAN9303_VIRT_SPECIAL_TURBO;
> > -             regmap_write(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, ctl=
);
> > -     }
> >  }
> >
> >  static int lan9303_port_enable(struct dsa_switch *ds, int port,
> > --
> > 2.17.1