Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f7189ca-afd6-25cf-38a0-80b53526c2fe@oracle.com>
Date:   Mon, 16 Jan 2023 15:46:39 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH 0/2] x86/xen: don't return from xen_pv_play_dead()
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
References: <20221125063248.30256-1-jgross@suse.com>
 <d0c6363f-d5c9-a53b-5275-e5134b54f09a@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <d0c6363f-d5c9-a53b-5275-e5134b54f09a@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG11WFg2N2NpcHhTY2N0RWlIaG4za243MGJTZEo3aE40UDk4SmRBS1Y3TjAz?=
 =?utf-8?B?UURHUDZVcmkwSGNoY1R3RVpralBia2Q4c042aXlOUGdqTE5lczZoR2lWSno5?=
 =?utf-8?B?U1psZTk5NTBXOWNlNVlrOWNEbVBINnJnSEVDMzBJM1FOMDEvUlVFK1pzekFK?=
 =?utf-8?B?aEdKdW1yWFVoM3hhTndZL2ZyaUxKMm1tYWUyaDVRU2xTR01SZXNBN3VQVWZ1?=
 =?utf-8?B?eGFFQ2xRVFlBRGlwVkhpS0s0cFc3MGhQSjJqMWNJSFRSblQ1bW1tblVWTTYz?=
 =?utf-8?B?c21IelM1ZjAvc0lsMEJyUmlNK0NJU2JPbzdLMzVZS2lIdkJxNWJDOTBKa0tw?=
 =?utf-8?B?UElUTU1TTDY0bWZWb1FGdk9mNTh5M3ZGWHV4MnRyNWw4OExOWXVScm02UTl4?=
 =?utf-8?B?TWJCSGhHQzZoWGhpZ29hRjhYdEgzcyt2M2s0U1BkUXhBYlI2U0EvazFnSm9O?=
 =?utf-8?B?NHVTSXFNVmEvVGt2a0I1OWRsMGErZm1xbms5R29TVm1ZaTc5NFArbmp1UHJz?=
 =?utf-8?B?dmxxRFU2dHZhSytXcDJpcWh5Y2JCdFFOeUFlR3czMzdsTjVLT0dDY1VXak9u?=
 =?utf-8?B?UHlYcTgrak85eWlHQnRZZndIZUg0RnB4YzJ4enFjTjlvSjRoV1NxVkVScHJW?=
 =?utf-8?B?d25WMjl2SmNVZjFaNE54WEoxaCtyaWk1dFBRdDlneXp1YjhRZFpMZVh0Sk94?=
 =?utf-8?B?b3Q2VUJrOWUvUGhxTUJFc01YeTRZTFJrSm9tZjR6cS91MENhMWZKcllsUzBl?=
 =?utf-8?B?Vm9mcjhGblc2UmRGSWNMRzNwYlpxamlmdlhSM3QxRnFjS2N4cjUrUFRLTzJO?=
 =?utf-8?B?ZHNoL0cxN0kxemt3Y1JTY2V2RGE0aHVTNFBTeWU4SzZQTHE0VnUvNFZtaDRq?=
 =?utf-8?B?UUxoMEMyZUhqZ2dKZHRKL3pZN2RES0poZHQ0VEFYL0JYNWFHdUxWNjhxb2tK?=
 =?utf-8?B?dU5oeDV6dGNjV2p4Q3VnM1hnZWsyTWEwV0NDQkdLNVliOHVkdktIRWxaS1VU?=
 =?utf-8?B?TjhUUEVySU1qVGNJNVMxdGU3M3U0S3hPd1JoY2NiaVBzQXBSZWQ1YmdtVmNp?=
 =?utf-8?B?RlBNdmZpYi9raDlLN0VWZ0RJdmNiWERTNE9rYVJoN08wZ2VzVUpORS9WZk12?=
 =?utf-8?B?MVhVRmN0SmZETC93cjZqZ1pRTGVCRnpmRS96ajNDRGlGWGk5c3ZVSFQ1ZGM5?=
 =?utf-8?B?MndhandqcnBjSmlaUE5lMk1LMkV6MzROVVp6SzFRcmNOcU1KR2pVWC9nbHpL?=
 =?utf-8?B?N0ZBc3FiMlE2bEpEY1dWN2NNaGp2dFY5YzhhS2ViTWY3TFZ5eUFTUlVYRDRN?=
 =?utf-8?B?MWo0ZkxUWUJpaXc0WEkreXk0TDJTcnRJT0x3UmE1YzRLY3hiVUlDYXJFS2l1?=
 =?utf-8?B?S1RFUlo4M1ErYklZMHBSa1pld1dNanQ2elJORWROUGZDRkZXbWo1elhlWlVi?=
 =?utf-8?B?d3BoRWxSWW1MczE5bHVLWFYzenZxODlGbjUzeEwxdjgzMGt6RFNYYkRZa3FM?=
 =?utf-8?B?Ri9GR0tJU0lqS2hVQ1RIL01Kc0psVndIaEkxMFRBMzBWTHFNckxUYVRqTUNa?=
 =?utf-8?B?UUhyOHY1b3hDa0RXYUUzRkQwU0FWT05JOUhYdDZ3YzJsUWNtK2N3d0JLQW1O?=
 =?utf-8?B?RHMzbzBudkpFMTg4MXd1cER5TVZNcHVvKzNsSFJmZTRpZXJPajZxZUNpNEpv?=
 =?utf-8?B?RGZmWFNGMExkcmlNUEpTcGUwQXJJUUpKNWNMYnVScVFIN2JVUzFQS2ZkR210?=
 =?utf-8?B?K0dIdjhCTktPejBMVWg4TmFhVzhxQ1B3YjlzeG9PQnN1S0pyWlUxUmpQZWpZ?=
 =?utf-8?B?ZWJ3c01TRmlhM2wyTHdHTklQdlFXQjFVT0dDb0VnbWtaUWFiVE9IZGVyc3NR?=
 =?utf-8?B?RDBadjVETTV2OWRpc1BBQk5uZEEyZFBRYUdQT2pnNXBpS083bWpyemdYMkZP?=
 =?utf-8?B?anpXYm9PZklQRlcydFltY2hFUEhURlpFWUsrNDN2UWNpcUxGVWVSeGVGSEJS?=
 =?utf-8?B?YVZ1Y1BJUzMySWtKTm9Kb3lqT2R4bDZ1UUxWWWNKVVVjTmtqSnFFNTY5bGV0?=
 =?utf-8?B?Q3EzNE9ibmEyOHo0dmhtSkpqMmxMRjc1VGNxRGJSK3Jrc1ZOVlVleHo3Rm5K?=
 =?utf-8?B?UlFQWEg1NE5qVm1qVmlkTFVlWDRDUHIrVUE3S0xGd0xXdnpUc0ZZNXNmNHNE?=
 =?utf-8?B?WFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?WVpXMW5aaDZDL1RqbEg5anRWcEhkZ3ZXSUhaZm9CT0Z3T0Z3dDFCUEw2VGZy?=
 =?utf-8?B?L1BQRm1VUFBwZUVFM1Y4SHY2MGpjT0o1K3VoZHZENmZ5QllqMEhmSW9FSS9S?=
 =?utf-8?B?WURQT2N3dWkvUGYzTHBYNTN4ODlaV2FFT002RG5tMmRoamg5NXhZSkdCZUxk?=
 =?utf-8?B?a2phUDFoK25NZWxYd1dMbkoxZXpTL0tFNTlZVStkbGV5OUV5YTRGcG8vREp6?=
 =?utf-8?B?cXJYMEkybEZWQTRkTmZqd1hoaWVnZHdpd1pOYjIwbnVuTVB0SE9RaWh1c3Fs?=
 =?utf-8?B?TTF2QU1QK2F0NWo2bktGT1hUL2J0Tm94amJWcUVzYmhQQ0U0ZFNMTkFiNkhw?=
 =?utf-8?B?bG52Z25ONTVibmRudEtXMVM3ZTJWQ0V1MmNJd2RlQ3pvUUR4VDVjaWxwSFI4?=
 =?utf-8?B?NXV4RkZodnhURmtxZzlwUG5CZG5KT2IzNmlkSEFKQ1d6ZzBKV3RwQVFWNzF3?=
 =?utf-8?B?VktlTEFNVnlYd0RNR2tma1BvdFdKbE5zWVBTU3V5aUtUWlBTVzBQUGQ5Z014?=
 =?utf-8?B?ZVJzZ1RNOGFya1EwWXRYeFRjM0ZuWlZaa01wclRjdWNMMktrWFE5Z3M5a3Rx?=
 =?utf-8?B?UHEzeGRUdEZlVEtnZmx0V0hNTDNlUEhENjVBV2JGZm1ybXY1bmJkTXBLNmJU?=
 =?utf-8?B?K09DWjI3bE9lYUxTTEorUHZXOHZFaEE3VGg4NGVOZGxBdGVPZkFHc0hlUFpR?=
 =?utf-8?B?QktDYXlZd3R4bDFEVWFjZzNrOW5Ya1BQd2wxMVhaWTRGYlpSQnFmOGlzWm5r?=
 =?utf-8?B?cXdHcllDbzhmak1UNldYbVVVRit3STl1cWk3bUltaUZpS3R4RnA1M05KcUNV?=
 =?utf-8?B?K1h2aHhXTFZoSmNXVWR2MmpxeThieVcvTk1uYXRhMVFVV3ppampIRGhObSt6?=
 =?utf-8?B?djNQNzF6ZE5sRWlXSUtNUDdXaDcvUmZEdVFaaUZacVJzTE1ublJUK2hab1M0?=
 =?utf-8?B?QzZ0T3FqV0cyNXNvQ3RqTlRCMmVlU2crMHNUVERNN2NDbTltdndTd0l1ZHJM?=
 =?utf-8?B?UnFKcmdKVng1Q2ZCQUMydERDWi9pTXdyVzcyV3FoeHVXTUc0eUhadERLcUor?=
 =?utf-8?B?YmliTGxycDd6UjhEUUZWNmhaRFJiUyt0ZGpKeUdFUFZnVEJDcWJIN2g3a0FM?=
 =?utf-8?B?eHYrYkpqcHMyckRHWEdKbHpsd2hzZkNMMlVibHBGODVKNVZYTHY1OVZueWFy?=
 =?utf-8?B?RFE0YzdLZ1U5VUdHbExzdDVsb01wTGZzZWpjT25zb2pFM2pvUSt5T21qNWhF?=
 =?utf-8?B?MlJFVlEzaUR5dTVNSWZVRFJzNmNzc3NCU2RPMDNDZ1IyWkJ4c3VHcUNtSjZn?=
 =?utf-8?B?M1VlVU1vSEZmdGJCWG9NdDNHUEtsaWxYNTZLMVk5NjZHZmJjRmVoOGZiOUJt?=
 =?utf-8?B?eEpiRjJLSmxPQjN2bWI5bGFJb25vbmFyRDJrZjdyUmN0R0hYaDFhNjE5cWRy?=
 =?utf-8?Q?Iw5vAlsE?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 281a061b-9b48-4396-eb91-08daf802c670
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 20:46:43.0956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jh+zWXRjnN8XnU/dXvrD9oucnVt5mZMsvYWam4qejdEHw43dAM3qD8InEsdD++Lg008EaVyVlVBk2yI6uRPSaaep89kTSo7VKebVFL8SR7E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4247
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-16_16,2023-01-13_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0
 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxlogscore=999
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301160152
X-Proofpoint-ORIG-GUID: JeEdyMrcvD2DTVv8_5PvbLdEmKMc4q9w
X-Proofpoint-GUID: JeEdyMrcvD2DTVv8_5PvbLdEmKMc4q9w
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/16/23 2:49 AM, Juergen Gross wrote:
> On 25.11.22 07:32, Juergen Gross wrote:
>> All play_dead() functions but xen_pv_play_dead() don't return to the
>> caller.
>>
>> Adapt xen_pv_play_dead() to behave like the other play_dead() variants.
>>
>> Juergen Gross (2):
>>    x86/xen: don't let xen_pv_play_dead() return
>>    x86/xen: mark xen_pv_play_dead() as __noreturn
>>
>>   arch/x86/xen/smp.h      |  2 ++
>>   arch/x86/xen/smp_pv.c   | 17 ++++-------------
>>   arch/x86/xen/xen-head.S |  7 +++++++
>>   tools/objtool/check.c   |  1 +
>>   4 files changed, 14 insertions(+), 13 deletions(-)
>>
>
> Ping?
>
>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>