Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765442AbXHWSIh (ORCPT ); Thu, 23 Aug 2007 14:08:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761585AbXHWSIa (ORCPT ); Thu, 23 Aug 2007 14:08:30 -0400 Received: from waste.org ([66.93.16.53]:60364 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758743AbXHWSI3 (ORCPT ); Thu, 23 Aug 2007 14:08:29 -0400 Date: Thu, 23 Aug 2007 13:06:58 -0500 From: Matt Mackall To: "Paul E. McKenney" Cc: Andrew Morton , bunk@kernel.org, josh@kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu Subject: Re: [PATCH] Make rcutorture RNG use temporal entropy Message-ID: <20070823180658.GQ11166@waste.org> References: <20070816024904.GA5312@linux.vnet.ibm.com> <20070817115356.cb201e42.akpm@linux-foundation.org> <20070817200022.GH8464@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070817200022.GH8464@linux.vnet.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1672 Lines: 35 On Fri, Aug 17, 2007 at 01:00:22PM -0700, Paul E. McKenney wrote: > On Fri, Aug 17, 2007 at 11:53:56AM -0700, Andrew Morton wrote: > > On Wed, 15 Aug 2007 19:49:04 -0700 > > "Paul E. McKenney" wrote: > > > > > Repost of http://lkml.org/lkml/2007/8/10/472 made available by request. > > > > > > The locking used by get_random_bytes() can conflict with the > > > preempt_disable() and synchronize_sched() form of RCU. This patch changes > > > rcutorture's RNG to gather entropy from the new cpu_clock() interface > > > (relying on interrupts, preemption, daemons, and rcutorture's reader > > > thread's rock-bottom scheduling priority to provide useful entropy), > > > and also adds and EXPORT_SYMBOL_GPL() to make that interface available > > > to GPLed kernel modules such as rcutorture. > > > > > > Passes several hours of rcutorture. > > > > Please explain what "conflict with" means so that I can work out if > > this is a needed-in-2.6.23 change, thanks. > > Not needed in 2.6.23. This change falls into the "preparation for -rt" > category. Also in the "don't unnecessarily eat entropy, leave some for > the people needing crypographically secure randomness" category. We've had several calls for a more fast and loose version of get_random_bytes. Generalizing one of the cookie generation functions is probably a good way to go. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/