Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 Jan 2023 23:44:34 +0100
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Alexey Gladkov <legion@kernel.org>
Cc:     Linux console tools development discussion 
        <kbd@lists.altlinux.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [kbd] [patch] font: Leverage KD_FONT_OP_GET/SET_TALL font
 operations
Message-ID: <20230116224434.sjo2ez4j6l4av4bc@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Alexey Gladkov <legion@kernel.org>,
        Linux console tools development discussion <kbd@lists.altlinux.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org
References: <20221218003209.503539532@ens-lyon.org>
 <20221218003339.263695493@ens-lyon.org>
 <Y78VRTF6cxHhio+s@example.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y78VRTF6cxHhio+s@example.org>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Alexey Gladkov, le mer. 11 janv. 2023 21:00:05 +0100, a ecrit:
> > @@ -54,13 +55,13 @@ do_loadfont(struct kfont_context *ctx, i
> >  	int bad_video_erase_char = 0;
> >  	int ret;
> >  
> > -	if (height < 1 || height > 32) {
> > -		KFONT_ERR(ctx, _("Bad character height %d"), height);
> > +	if (height < 1 || height > 64) {
> > +		KFONT_ERR(ctx, _("Bad character height %d (limit is 64)"), height);
> 
> Hm. But max_font_height is 128. Shouldn't it be height > 128 ?
> 
> >  		return -EX_DATAERR;
> >  	}
> >  
> > -	if (width < 1 || width > 32) {
> > -		KFONT_ERR(ctx, _("Bad character width %d"), width);
> > +	if (width < 1 || width > 128) {
> > +		KFONT_ERR(ctx, _("Bad character width %d (limit is 128)"), width);
> 
> Same here. max_font_width is 64.

Oops, sure, fixed it, will send an updated kbd patch for that.

Samuel