Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <04dc1bc9-05ed-f6ed-f01f-7d28600fc0ce@amd.com>
Date:   Tue, 17 Jan 2023 11:20:37 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 3/4] iommu: Introduce IOMMU call-back for processing
 struct KVM assigned to VFIO
Content-Language: en-US
To:     Robin Murphy <robin.murphy@arm.com>, linux-kernel@vger.kernel.org,
        iommu@lists.linux.dev
Cc:     joro@8bytes.org, ashish.kalra@amd.com, thomas.lendacky@amd.com,
        vasant.hegde@amd.com, jon.grimm@amd.com
References: <20230110143137.54517-1-suravee.suthikulpanit@amd.com>
 <20230110143137.54517-4-suravee.suthikulpanit@amd.com>
 <e4d5db37-a7b9-9b33-4ecf-c168b6d41a9a@arm.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <e4d5db37-a7b9-9b33-4ecf-c168b6d41a9a@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3pQeVB5d0IzeTlvaFdUQjg1RmZvYlo5RUx1S0lxTTRiWThtK0hJOXdMQjFn?=
 =?utf-8?B?ek9HU0NBelEwRDQwcldLTXo4eXFnK2VRSTVlQWZkczRWVTN3MHNyRzc0YmZK?=
 =?utf-8?B?bVBkcGU3ejg0b1hvU25Yejh4NzFpd3AyYytuWXNKV3l0TE5QcTIybmR1TW41?=
 =?utf-8?B?ZSs3NjJJOFVWTkFvaDN1NHhQTjU2Vy9TMEhzdTZ6dElMOXZQd0xaeUFkdHQw?=
 =?utf-8?B?RXdwVHdSNzNPS3dENEQvemVZM3ZaRW9hU3JGZzkyUEt5MnVlamlEWVRiV2pm?=
 =?utf-8?B?YmJYUWhYeUJxTzJySXZGdG8xV0xQb0ZrUjNFT2pWN1RYWVdORlcrTXdub1FX?=
 =?utf-8?B?RStNWjdjazRuZFFwQWxZRzVKNHkvekZicUNSVHdmRmkrYXAvOVJmb2VIdVc4?=
 =?utf-8?B?THduOXJlSGVDcWxaK3pyZDlDWlZQUk9ObXMrQkdoUzAvc21Db3o0YVkvaXM3?=
 =?utf-8?B?NnVPYnVkNDZPSGtRcWwwYUJoUTdHSURZdmZLbXpQTGZwSGdpLys5a200Wita?=
 =?utf-8?B?R1lWU3ZBV01rQXFrdnVPL1BydlJqUFY1T0Y5VDJxL3JNTys3RVhZTThNZVFG?=
 =?utf-8?B?RlZzb1RCRzB0UDJiNDM0bDZqaWFjT050U1lLUHhPV25xMkgyZmZORWJ6K3Rm?=
 =?utf-8?B?YVhpMHQ3bGZXU2YvbkFqUlczSnhjRU9CeVIxR2NwQUVmSSsvY2R5MkEzNW84?=
 =?utf-8?B?bUJjVVl3WUFXeU5ybUlWckFFTFNoaURDc0NML0hhcjRnN1loTDhoZTQ5U0hB?=
 =?utf-8?B?SG8rYTdUaEhiaThKOC9vTHVCZXB5ZUZtcHc3WHRrYm5PUjJXUjF1aklqazF6?=
 =?utf-8?B?Y3o2b0V1VHNJT3lXR2NZSitzRXpNVWl3WDlzUzNYa2NuOWVTZStkZTQ4Zktm?=
 =?utf-8?B?NDdZcjcyaEVNMmlyaUJlTENqWnJTQ3ZwTjFLTHgyS013bnFiUmxFRm9jUG1B?=
 =?utf-8?B?aWJvblpIcHJjSW0zUHBPOFF2blBMUEVkSHdZME4xOUlSWXIzR0dycE9CMTRO?=
 =?utf-8?B?cjZiaHAzbzlMTjgwSVl3YWZXbTZ2Rk00SWFuVm1HbHRVSjhuSWRhbmdWYTdV?=
 =?utf-8?B?bnEzcEtkRWxwajBQVWVGdXQ4cDFGZGkxZmp2Smh4MTl1blJqdGl5RmtTTUly?=
 =?utf-8?B?TUV2aUhuU3ZXSVRXYThlN3NwbWpRbDZ1dDZsNzBoU1VSeXFIdWFvUFl2bkw1?=
 =?utf-8?B?Y1VUQ3BwZms5V2I5TTZabENCcWVpVGFldURHUFlQS1BBV01vUXJDWUVCd2VZ?=
 =?utf-8?B?YkorZ3A5TWEweHYzeE9ncDVhckFHVWhsTGYyT216ajJxZnJUVzJuN1o5Uk16?=
 =?utf-8?B?MjdGb24valNYenpybWV3TjNNdXdvKzdaQi8rZjVFOFo0NmJjRWRqYUd5MlY0?=
 =?utf-8?B?QWd4dlVMTFpGOGRreExySlQ2cTlqZnF6QzFuYVN4OFRZTjh3Z0JwK1FsSnFj?=
 =?utf-8?B?QmJpOC9oOGk4WlQzVkhEeVlrWnJBUHNUeGRYb0I2MUJPNkErcG5GWUh1VkNu?=
 =?utf-8?B?N1hidmVJbGZsYUkwaFE2ejFPL0hlLytSTkJwTXczL0l4Mi8veFhvRWtlRVIz?=
 =?utf-8?B?V2crSGVVbm5EbC83T2o5QlVMY0pJVlluNnhuZUdDZ3R5YTFrQ2pzTzFVN2VN?=
 =?utf-8?B?OW1FUmhqaG9ZMHlDUFJJcE5oN0tFZEFvM1Q0YkhlQm1YK0l3dktVRzFpYVha?=
 =?utf-8?B?c2lYNjJXaE1RaXNzTGhJRVl3VEJoek5yOVhmMHhjNFlsTC9UMjhtdzhDQUNz?=
 =?utf-8?B?di9HTWkvRGVaZzVibUdZWFpQTlAwQkZCbG1QZlpCbXdrMjVZUlZSeXZYSjQ5?=
 =?utf-8?B?ZDRoM0txY3FNL2FtRXNua3B6WVQxbUFxUlAvalNZWit3aUY1VjNOS1hNbG5w?=
 =?utf-8?B?L0o5Z1JlN1R1MnYwbG9vYllRNTNRR0swbmcwamlIU2U1aHNUelV3alV2Yldv?=
 =?utf-8?B?TUY4eGdqbnRtUHdid1d5c2NSelRsSnhWYjZoTm1vKzBzbFhBQWFZR2dKOExK?=
 =?utf-8?B?dWRGMUFiVjZHK0tVVFJDeXZ6c1FJdnpObTcxeHRTK0VkSHBxa1YrbTUzcmVI?=
 =?utf-8?B?SzdXRFpoazg3VDNWVlArNUk3clRYUHBUVkVUcEdiRFU3a3hpOVZWWnkwVENT?=
 =?utf-8?Q?1ZrgaLbZtHXsiYbXN2E1PtYRs?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4648155-fcf5-4960-9657-08daf8423522
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 04:20:47.0898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xg8lVj+yJIXLA8D1o7Tj/uHqmRLMQkPMGzyCSpY5mtFlMC6H1JwLdkiTfIkcukP4kO0A510Jm7cfVUezM7xQpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6204
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Robin,

On 1/10/2023 10:11 PM, Robin Murphy wrote:
> On 2023-01-10 14:31, Suravee Suthikulpanit wrote:
>> Currently, VFIO provide an kvm_vfio_file_set_kvm() interface for 
>> assigning
>> a KVM structure to a VFIO group. The information in struct KVM is also
>> useful for IOMMU drivers when setting up VFIO domain.
>>
>> Introduce struct iommu_domain_ops.set_kvm call-back function to allow
>> IOMMU drivers to provide call-back to process the struct KVM assigned.
> 
> Hmm, it sounds like this has quite some overlap of intent with the 
> existing "enable_nesting" op, and my gut feeling is that it's not great 
> to have two completely different "this is a VFIO domain" mechanisms... :/
> 
> Robin.

Actually, the intention is to communicate KVM information, which is 
already available to the VFIO down to the AMD IOMMU driver layer. I am 
not sure if the enable_nesting() has enough information or the same 
intention since that only communicates VFIO domain information.

Thanks,
Suravee