Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: idc91472f:Fastmail
Date:   Tue, 17 Jan 2023 07:31:59 +0100
From:   Klaus Jensen <its@irrelevant.dk>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: regression on aarch64? panic on boot
Message-ID: <Y8ZA30EoAFaFPwVC@cormorant.local>
References: <Y8XINx8fpGPKudW6@cormorant.local>
 <20230117055819.GB13795@lst.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cUqTUeXB0r3Qvrag"
Content-Disposition: inline
In-Reply-To: <20230117055819.GB13795@lst.de>
Precedence: bulk


--cUqTUeXB0r3Qvrag
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jan 17 06:58, Christoph Hellwig wrote:
> On Mon, Jan 16, 2023 at 10:57:11PM +0100, Klaus Jensen wrote:
> > Hi,
> >=20
> > I'm getting panics when booting from a QEMU hw/nvme device on an aarch64
> > guest in roughly 20% of boots on v6.2-rc4. Example panic below.
>=20
> This smells like your setup somehow doesn't wait for async driver
> probe.  Does the hack below work around it?
>=20
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index b13baccedb4a95..f47e19c701d520 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3508,7 +3508,6 @@ static struct pci_driver nvme_driver =3D {
>  	.remove		=3D nvme_remove,
>  	.shutdown	=3D nvme_shutdown,
>  	.driver		=3D {
> -		.probe_type	=3D PROBE_PREFER_ASYNCHRONOUS,
>  #ifdef CONFIG_PM_SLEEP
>  		.pm		=3D &nvme_dev_pm_ops,
>  #endif

Good morning Christoph,

Yep, the above works.

My setup is a buildroot qemu_aarch64_virt_defconfig booting from an
emulated nvme device:

  qemu-system-aarch64 -M "virt" -cpu "cortex-a53" -m 512M \
    -nodefaults -nographic -snapshot -no-reboot \
    -kernel images/Image \
    -append "root=3D/dev/nvme0n1 console=3DttyAMA0,115200" \
    -drive file=3Dimages/rootfs.ext2,format=3Draw,if=3Dnone,id=3Dd0 \
    -device nvme,serial=3Ddefault,drive=3Dd0 \
    -nic user,model=3Dvirtio \
    -serial stdio

--cUqTUeXB0r3Qvrag
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmPGQN4ACgkQTeGvMW1P
DekUlQgArSA3SHObjDm25ViUP7dge6sNgHpVj03FApy3trji+haPhfnLk7M8Uruo
Qqw5rCbESeL3xVYSPdyzJRX/JsQDYaRnzs2EzH+yygD+6NmD+nIakOTx6u00Tiqh
r/3fY+KBIc1B1VfGHFQbUMVHL2lye6tqdSiBUsvCmHmYLXJGcLUD+vXXhy8jGpU9
fglg63OMtZ9Dkf7iUVC5PL/RDAhgCUxhXmk5b0EIUIgr2zJUy7+xUC9hCNmcYjaz
k6G2e0UFc6xbk/5N0svNPc0Q4PJ8Z0pT9ru1xvUNoHUHdYhtaeMkKdgogzo54m7w
5taBf7+AiPseaxTMjJKc5GXBdqTFZQ==
=KGuL
-----END PGP SIGNATURE-----

--cUqTUeXB0r3Qvrag--