Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "S.J. Wang" <shengjiu.wang@nxp.com>
To:     "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        SOF-Team <sof-team@msteams.nxp.com>,
        MPU AUDIOSW-AUDIOSW <Mpuaudiosw@nxp.com>,
        Iuliana Prodan <iuliana.prodan@nxp.com>
CC:     dl-linux-imx <linux-imx@nxp.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: RE: [PATCH] remoteproc: imx_dsp_rproc: add module parameter to ignore
 ready flag from remote processor
Thread-Topic: [PATCH] remoteproc: imx_dsp_rproc: add module parameter to
 ignore ready flag from remote processor
Thread-Index: AQHZKf14CghgbIrDOUyXQHWXGPt9Ha6iLbIQ
Date:   Tue, 17 Jan 2023 07:36:47 +0000
Message-ID: <DB9PR04MB935597568D763916CA4ECA13E3C69@DB9PR04MB9355.eurprd04.prod.outlook.com>
References: <20230116225343.26336-1-iuliana.prodan@oss.nxp.com>
In-Reply-To: <20230116225343.26336-1-iuliana.prodan@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UKzHkcyp1Y0mu5o9EIV81dy6S1N94+aWZMysNpUfEEldF5mDGb9TxwUdVK4K?=
 =?us-ascii?Q?+kavJO2xXWaDqo4BrI0kiFEwKnxjkYvp6T7NzuSF2gOBperwvrXyYV00EVT4?=
 =?us-ascii?Q?7CY2ns+lllyBs/OE18x9An1wAbHDjEl/vKQbfbYv1BAHOrE4t+2ehEjtQszt?=
 =?us-ascii?Q?TPQ9C6gh+O+/a7QUFJSfWQSfaADeJAHBOPFAhhg1erk5kQRG6bc4oSl3pcM0?=
 =?us-ascii?Q?kqq32jxXhF6Fk5dpqmS7mqCPLpMCSrxhutBfg+4ksnvbIdX/zhmhgX8k43Hz?=
 =?us-ascii?Q?/u1CBm+BaZGNlXM2KbJF+552GeWjxQkCcYQnKv4xwvok4L4XTsl5E2sFqqfD?=
 =?us-ascii?Q?GuzaV0ugMGnQc449w9NZZENNx+qzumZazJSRAeTq72OA1dEzOOR51nIoVF6f?=
 =?us-ascii?Q?T3vNR/EkDnkJKVfvyZ7z879cEhZfySSYtu6M+Ejm+3zb/bC8i3EjuxLtsGCE?=
 =?us-ascii?Q?qAkE/YJcR/2YycQiR+/1R6Fg42ecl2sW4jngaNq6kzmpIxlioFxwbDrkvzH2?=
 =?us-ascii?Q?S6jXnhjkxVf5YXC6o1zy25YlrUAU+bHXsJwcvvs0PQ6YD5ame4ECEcevck2N?=
 =?us-ascii?Q?+QUBqfIRv+Vg5K8aV1w8lHDG2YvR/wJifrAlumhlwqVwOFx3Gu88IdUytqxF?=
 =?us-ascii?Q?lNvInuNl2KXrw1pjsAr6oe7hweN8KEknsL35IgFpI3xKDKBLbRHe1ADe+i45?=
 =?us-ascii?Q?zpVNCTAjMdmKJVbXI1zmEdOEwjBo3cTt1+jSy/9SJ0Nmq2SzP1cEOBYXHOp1?=
 =?us-ascii?Q?n9kLw9UF/5VvPNCwb/WOfHKYWEW2kfJZtqbevVePYQ1qmCoR3ThXhuUI3d/j?=
 =?us-ascii?Q?Mns6TVjymyq4VmjyS3zTK0IFSM38MRkhLX43VIHvpSAyV2j5zzw7FErFZ5F2?=
 =?us-ascii?Q?MRMt5+Opi0yTQfjAb+yV449dCdf1ChaDG2kWwQ951QXBjcoojXI13BRhG4BT?=
 =?us-ascii?Q?Yr0NQvDTilU0wkQCt2ANs0VINcyRjmOdv83eEzI2uayRVdEI9L7HALgpNfKm?=
 =?us-ascii?Q?jmJNu4O453uKzYqWf1YpaR0xcadNIvWgaIZlcvUm8XDLeIY35AbrHsIDy9IR?=
 =?us-ascii?Q?rITC1rpZvRPq10S6hp1zwHjBDa8/YXrJPUbvyW2Dy10cg7A1y1MnQtHE+/Zc?=
 =?us-ascii?Q?/ffEElmGv21X6HHg2O0cVrjgUiEKLQho27xq+0DiRfXtcmkGYOfjQztc0MFC?=
 =?us-ascii?Q?+ciKkeY6E6+/f1JNvJlkdu454bnqANJ/Cxjk+8+TikUK5qXbZQRtFrJduDyb?=
 =?us-ascii?Q?tWKk9YtX6FAC6ryXxJQC7OzuHzidbTiomIqS8PE0DZ3AvuGsZAxUC9uFpc58?=
 =?us-ascii?Q?saXovYPYwgmB5ez6LnB4kNVmXHXf9IuNDP4hIgLk4qPjvj0bJ5mPE6SffG+5?=
 =?us-ascii?Q?e4lrfJ6GtB8iIBRP1uSYnCqazTheiq5r23d9HKbHZ/U9jwJ0jTa2GzDh7Xkx?=
 =?us-ascii?Q?6XzcE2GJ3IWDuwUhBFZXeo+XWLYu8WWXq/Be3i7sk1BsVE1cElvlmfEdWKyW?=
 =?us-ascii?Q?u6ILuXzvMJ6fLDxJbzAhsxV769eDD2gWIoZmobvL0qQU99uV6QjdHK9vQ+5d?=
 =?us-ascii?Q?TtM/pCcbm4UwewWuVB9ZgzYcCuI08XQjWUOuMxzG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9355.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f869d8a3-b32b-4d27-3481-08daf85d9716
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 07:36:47.6495
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3mWbklB+axDQ7wmrWfsCn/BPdm/GKxU+Aou2u+wgewSxhDwjC5cWhc3/NmKxj1vGd3zawBXR4OAgBsHapsQJNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8457
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> There are cases when we want to test a simple "hello world"
> application on the DSP and we don't have IPC between the cores.
> Therefore, skip the wait for remote processor to start.
>=20
> Added "ignoreready" flag while inserting the module to ignore remote
> processor reply after start.
> By default, this is off - do not ignore reply from rproc.
>=20
> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> ---
>  drivers/remoteproc/imx_dsp_rproc.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>=20
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c
> b/drivers/remoteproc/imx_dsp_rproc.c
> index 95da1cbefacf..ec298f8b019f 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -26,9 +26,20 @@
>  #include "remoteproc_elf_helpers.h"
>  #include "remoteproc_internal.h"
>=20
> +#define IMX_DSP_IGNORE_REMOTE_READY		0
> +
> +/*
> + * Module parameters
> + */
> +static unsigned int imx_dsp_rproc_ignoreready =3D
> +IMX_DSP_IGNORE_REMOTE_READY; module_param_named(ignoreready,
> +imx_dsp_rproc_ignoreready, int, 0644); MODULE_PARM_DESC(ignoreready,
> +		 "Ignore remote proc reply after start, default is 0 (off).");
> +
>  #define DSP_RPROC_CLK_MAX			5
>=20
>  #define REMOTE_IS_READY				BIT(0)
> +#define REMOTE_SKIP_WAIT			BIT(31)

Can we use a close bit with REMOTE_IS_READY,  like BIT(1)?

Best regards
Wang Shengjiu

>  #define REMOTE_READY_WAIT_MAX_RETRIES		500
>=20
>  /* att flags */
> @@ -285,6 +296,9 @@ static int imx_dsp_rproc_ready(struct rproc *rproc)
>  	if (!priv->rxdb_ch)
>  		return 0;
>=20
> +	if (priv->flags & REMOTE_SKIP_WAIT)
> +		return 0;
> +
>  	for (i =3D 0; i < REMOTE_READY_WAIT_MAX_RETRIES; i++) {
>  		if (priv->flags & REMOTE_IS_READY)
>  			return 0;
> @@ -903,6 +917,9 @@ static int imx_dsp_rproc_probe(struct
> platform_device *pdev)
>  	priv->rproc =3D rproc;
>  	priv->dsp_dcfg =3D dsp_dcfg;
>=20
> +	if (imx_dsp_rproc_ignoreready)
> +		priv->flags |=3D REMOTE_SKIP_WAIT;
> +
>  	dev_set_drvdata(dev, rproc);
>=20
>  	INIT_WORK(&priv->rproc_work, imx_dsp_rproc_vq_work);
> --
> 2.17.1