Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4429421rwb; Tue, 17 Jan 2023 00:15:46 -0800 (PST) X-Google-Smtp-Source: AMrXdXvTJJolZUp9vezSIhUg3gjjkvo03Fw9z+fVnJBYt/kuWj6ttQbmXnucj1T/PclKXG3mrifW X-Received: by 2002:a05:6402:1f8b:b0:499:b4b1:5266 with SMTP id c11-20020a0564021f8b00b00499b4b15266mr2319132edc.40.1673943345830; Tue, 17 Jan 2023 00:15:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673943345; cv=none; d=google.com; s=arc-20160816; b=0/gSRY4mLfpDoKHLb7AGx4fK6fQ70kagjL3Ki7TXrGLdbL47wL7HRS6sAGaZt+6OBp AJTQoMqL7VRzqOpQ02NOABYgCttRQtHHfjILn+49e+OmcEqMqr64Jb5q6oCILHCNA5lq 973o5Kqthx2JFWBWjict/DoqQL6kUcJd6+VBL6DxsryFnwCCUMDS9Z4lXwYVKgpbl9n4 cv1/bfb3FzKK+KSWpn7NiWcJT8kf3ZwS+JNJ5IRZc/SELb9Kw/wpREQctU2oVpnNiXr3 xaqMmzjinslPSfht25BmAU4Id3F79Tzc+1tWG1sT6eIcGx+ddIFD7cYXKAAud1fmCSmH CjWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Doys/SC0QOZ3upK94vMab3sn1eoA5ffBssidJQpR6WE=; b=tgf/naaK+/Y+OaMh2ZY5yxQVpPiSuzdj7mOl/5pg/ogwtg2F/wH5NSTVpBLLSpzIBx wEECaeUQyd/sXyXbV7+uw4je2NKNg5HwWXh808Iu18Bi/+gicGXWQHGPVScgD1Bv7l3/ Rdn1s/qZJYmXbwAjPHYGoQEHnNCkScjJXjYx8cZw2qCygrRznOfnE5k0KRlg+sNoxfFF K7ISyWxENrNnVHWh2yvrNbPma0S1zYrLJ/J/WYISwuEwijdIObjH9jt1z0TJxPz7HvFY e2XP7AR6oa5J/XhavkbyPdGvmxd2DPZEGgvqoWywiguCay2pUV+IPKCAe4yAO3FFHUTs T9hA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=T7vjsLXA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e20-20020a50fb94000000b00497431159d4si10531834edq.532.2023.01.17.00.15.33; Tue, 17 Jan 2023 00:15:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=T7vjsLXA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234106AbjAQHz2 (ORCPT + 49 others); Tue, 17 Jan 2023 02:55:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235772AbjAQHzW (ORCPT ); Tue, 17 Jan 2023 02:55:22 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F0BF24480; Mon, 16 Jan 2023 23:55:18 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id hw16so61516467ejc.10; Mon, 16 Jan 2023 23:55:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Doys/SC0QOZ3upK94vMab3sn1eoA5ffBssidJQpR6WE=; b=T7vjsLXATy6+GqiZT3hsLButMHNBLRladrcF5/He5OPGnFCjvUiXtlLVxdY+dP7iWW hdkiuhaAaYo0QJZFRu1k6OoyFL6wLHV8LGBM2mGhlr9Iljzq792ZX2Rtxr0LeYNE2z+S 7wEMFCxC5mNwH5rI+dVxhl3mJJEyTNHkUydVBnrCMPeS7GLQ1tYPnKnBZzj3ASUom26S aQwcHsr7MuzGbWyiCUhq9RYdpK1a+M5sM+WsZSIJQcVy5X1stM/STILqMb37S8hW2ngU O/3sOPeR1n+CsDp7jjqrRUKfbu5WQsTwa3DlB4VV1CP7r+rEH1lhs3m67s8kiiZBTmOQ TtmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Doys/SC0QOZ3upK94vMab3sn1eoA5ffBssidJQpR6WE=; b=MOSiVSI3hRPexEkEWV9xT5muetD4T3NUmyJQjH1NB3h9XUqysKj6AgoMx+Veu3Mp4B 1gI7q0wcM6I/0Q4VBpuYkkcJ20qCbdXM5+rNpi/ppU/4GaIBgK3FJlCH8BL7nuisZp1J 12yFWmRspV/hzhkp8HB5iYHgHQRBV+F5CrE+/Vq+vWq2fgjgVdoWQUtMF88jsBFQwqNj VHXBBf9c7JnocklqTh0Uw9SGnv7+kKJXTfO4HRHwfsC/BrCZaVJGhi6uc6okHEqKQFbn SMnUMp/LnAcNsK6e0Dhj9JRQiPCLnZ9XITgrvNP7c0g91Fu1X3NbPRvRd7Gv0cgwv+bj 0fkA== X-Gm-Message-State: AFqh2kqhzO97heZcunE7uWYQTKvDxK3aGxUX3oYXWH5hcn+4u3it89e4 L05ItuThH5cs+ulmb6ZLp4sl/0BYxPv1+zzixx4= X-Received: by 2002:a17:906:ce36:b0:7c1:6f86:ec4 with SMTP id sd22-20020a170906ce3600b007c16f860ec4mr200821ejb.621.1673942116562; Mon, 16 Jan 2023 23:55:16 -0800 (PST) MIME-Version: 1.0 References: <2b4bc0b22fac32ab3a7262240019486804c1691f.1673806409.git.christophe.jaillet@wanadoo.fr> In-Reply-To: <2b4bc0b22fac32ab3a7262240019486804c1691f.1673806409.git.christophe.jaillet@wanadoo.fr> From: Daniel Baluta Date: Tue, 17 Jan 2023 09:55:04 +0200 Message-ID: Subject: Re: [PATCH] firmware: imx-dsp: Fix an error handling path in imx_dsp_setup_channels() To: Christophe JAILLET Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Daniel Baluta , Paul Olaru , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2023 at 8:35 PM Christophe JAILLET wrote: > > If mbox_request_channel_byname() fails, the memory allocated a few lines > above still need to be freed before going to the error handling path. > > Fixes: 046326989a18 ("firmware: imx: Save channel name for further use") > Signed-off-by: Christophe JAILLET Good catch. Reviewed-by: Daniel Baluta